disable tests for shared lib builds

Author: Gogoshika-ga

CMakeLists.txt

@@ -206,13 +206,13 @@ elseif(LINUX)
 
 endif()
 
-if(${GA_BUILD_SAMPLE})
-    if(${GA_SHARED_LIB})
-        add_subdirectory("${CMAKE_CURRENT_SOURCE_DIR}/sample_shared")
-    else()
-        add_subdirectory("${CMAKE_CURRENT_SOURCE_DIR}/sample")
-    endif()
-endif()
+if(${GA_BUILD_SAMPLE})
+    if(${GA_SHARED_LIB})
+        add_subdirectory("${CMAKE_CURRENT_SOURCE_DIR}/sample_shared")
+    else()
+        add_subdirectory("${CMAKE_CURRENT_SOURCE_DIR}/sample")
+    endif()
+endif()
 
 add_library(GameAnalytics ${LIB_TYPE} ${CPP_SOURCES})
 target_link_libraries(GameAnalytics PRIVATE ${LIBS} PUBLIC ${PUBLIC_LIBS})
@@ -221,43 +221,52 @@ message(STATUS "CMAKE_EXE_LINKER_FLAGS: ${CMAKE_EXE_LINKER_FLAGS}")
 message(STATUS "CMAKE_SHARED_LINKER_FLAGS: ${CMAKE_SHARED_LINKER_FLAGS}")
 # --------------------------- Google Test Setup --------------------------- #
 
-# Set Project Name
-set(UT_PROJECT_NAME "${PROJECT_NAME}UnitTests")
+# Only build tests for static library builds
+# Shared library builds don't export internal symbols needed by tests
+if(NOT GA_SHARED_LIB)
+    message(STATUS "Building unit tests (tests are only available for static library builds)")
+    
+    # Set Project Name
+    set(UT_PROJECT_NAME "${PROJECT_NAME}UnitTests")
 
-# Add Google Test
-set(GTEST_DIR "${EXTERNALS_DIR}/googletest")
-add_subdirectory(${GTEST_DIR} ${PROJECT_SOURCE_DIR}/gtest_build)
+    # Add Google Test
+    set(GTEST_DIR "${EXTERNALS_DIR}/googletest")
+    add_subdirectory(${GTEST_DIR} ${PROJECT_SOURCE_DIR}/gtest_build)
 
-# Add tests
-enable_testing()
+    # Add tests
+    enable_testing()
 
-########################################
-# Test files
-########################################
+    ########################################
+    # Test files
+    ########################################
 
-file(GLOB_RECURSE TEST_SRC_FILES "${PROJECT_SOURCE_DIR}/test/*.cpp")
+    file(GLOB_RECURSE TEST_SRC_FILES "${PROJECT_SOURCE_DIR}/test/*.cpp")
 
-########################################
-# Unit Tests
-#######################################
-add_executable(${UT_PROJECT_NAME} ${TEST_SRC_FILES})
+    ########################################
+    # Unit Tests
+    #######################################
+    add_executable(${UT_PROJECT_NAME} ${TEST_SRC_FILES})
 
-########################################
-# Standard linking to gtest and gmock components
-########################################
-target_link_libraries(${UT_PROJECT_NAME} gtest gtest_main gmock_main)
+    ########################################
+    # Standard linking to gtest and gmock components
+    ########################################
+    target_link_libraries(${UT_PROJECT_NAME} gtest gtest_main gmock_main)
 
-########################################
-# Linking to GA SDK
-########################################
-target_link_libraries(${UT_PROJECT_NAME} ${PROJECT_NAME})
+    ########################################
+    # Linking to GA SDK
+    ########################################
+    target_link_libraries(${UT_PROJECT_NAME} ${PROJECT_NAME})
 
-########################################
-add_test(NAME ${UT_PROJECT_NAME} COMMAND GameAnalyticsUnitTests)
+    ########################################
+    add_test(NAME ${UT_PROJECT_NAME} COMMAND GameAnalyticsUnitTests)
+else()
+    message(STATUS "Skipping unit tests (not available for shared library builds)")
+endif()
 
 # --------------------------- Code Coverage Setup --------------------------- #
 
-if (ENABLE_COVERAGE)
+# Coverage requires tests, which are only available for static library builds
+if (ENABLE_COVERAGE AND NOT GA_SHARED_LIB)
     find_program(GCOV_PATH gcov)
     if (NOT GCOV_PATH)
         message(WARNING "program gcov not found")

setup.py

@@ -42,6 +42,10 @@ def main():
 	if args.compiler and not args.platform.startswith('linux'):
 		parser.error('--compiler can only be used with Linux platforms')
 
+	# Validate coverage is not used with shared library
+	if args.coverage and args.shared:
+		parser.error('--coverage cannot be used with --shared (coverage requires tests which need static library)')
+
 	# Get compiler configuration for this platform (single compiler, like cmake.yml)
 	compiler_config = get_compiler_for_platform(args.platform, args.compiler)
 	c_compiler = compiler_config.get('c', '')