feat: enable macos build#22
Conversation
0a62b8a to
c6cbc94
Compare
|
Current status:
|
8d43b0c to
e55a183
Compare
9f55e84 to
32ac9a6
Compare
|
Update: build passes on CI but the first test crashes. I have to investigate. Maybe a first hint: |
|
@tony-go I made CI build passes on branch enable-macos-1. |
Don't follow you up on this. Why should we use that branch if you are a build that passes on another branch? If you used this branch as a base, please open a PR basis on this one. |
Ok you are right, let's review #33 |
|
Now that #33 is merged, could you please rebase this branch on |
a17b211 to
0fd1c18
Compare
|
hey @G-Ray With your new clone function, normally, I just have to:
The "install": "node-gyp-build "node scripts/build-transmission.js""` not happen on my side. |
|
That is the patch I add to do to make it work: index 97c752e..fc8ad63 100644
--- a/package.json
+++ b/package.json
@@ -6,7 +6,7 @@
"license": "GPL-3.0",
"main": "index.js",
"scripts": {
- "install": "node-gyp-build \"node scripts/build-transmission.js\"",
+ "postInstall": "node-gyp-build \"node scripts/build-transmission.js\"",
"test": "standard && node --test test.js",
"prebuild": "prebuildify --napi --strip",
"prebuild-arm64": "prebuildify --napi --strip --tag-armv"Should I raise a PR? |
So as we discussed, one just need to be sure deleting the
|
a0cc8c8 to
a589f52
Compare
No description provided.