Skip to content

Commit 151f45a

Browse files
authored
Merge pull request #458 from FunD-StockProject/feat/#404-qa
0208 QA
2 parents 64263dc + 6013d45 commit 151f45a

18 files changed

Lines changed: 68 additions & 58 deletions

File tree

package-lock.json

Lines changed: 18 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/assets/Loading.mov

-22.5 KB
Binary file not shown.

src/assets/Loading.webm

-40.5 KB
Binary file not shown.

src/assets/loading.gif

70.5 KB
Loading

src/assets/loading.png

-1.49 KB
Binary file not shown.

src/assets/loading.svg

Lines changed: 0 additions & 26 deletions
This file was deleted.

src/components/Common/LoadingComponent.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
1-
import LoadingSVG from '@assets/loading.svg?react';
1+
import LoadingGIF from '@assets/loading.gif';
22
import { Container } from './Common';
33

44
const LoadingComponent = () => {
55
return (
66
<Container>
7-
<LoadingSVG />
7+
<img src={LoadingGIF} />
88
</Container>
99
);
1010
};

src/components/Loading/Loading.Style.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ const LoadingContent = styled.div({
3535
justifyContent: 'center',
3636
gap: '16px',
3737

38-
['>video']: {
38+
['>img']: {
3939
width: '80px',
4040
height: 'auto',
4141
aspectRatio: '1 / 1',

src/components/Loading/Loading.tsx

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
1-
import LoadingMOV from '@assets/Loading.mov';
2-
import LoadingWEBM from '@assets/Loading.webm';
31
import BackgroundSVG from '@assets/background.svg?react';
2+
import LoadingGIF from '@assets/loading.gif';
43
import { LoadingContainer, LoadingContent } from './Loading.Style';
54

65
const Loading = ({ isLoading, title, desc }: { isLoading?: boolean; title: string; desc?: string }) => {
@@ -12,11 +11,7 @@ const Loading = ({ isLoading, title, desc }: { isLoading?: boolean; title: strin
1211
<LoadingContainer bottom="96px">
1312
<BackgroundSVG />
1413
<LoadingContent>
15-
<video autoPlay loop muted playsInline preload="auto">
16-
<source src={LoadingMOV} type='video/quicktime; codecs="hvc1"' />
17-
<source src={LoadingWEBM} type="video/webm" />
18-
<p>브라우저가 비디오 태그를 지원하지 않습니다.</p>
19-
</video>
14+
<img src={LoadingGIF} />
2015
<div>
2116
<p className="title">{title}</p>
2217
{desc && <p className="desc">{desc}</p>}

src/components/Page/Home/Ranking/Ranking.Style.ts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -153,6 +153,12 @@ const RankingLoading = styled.div({
153153
display: 'flex',
154154
justifyContent: 'center',
155155
alignItems: 'center',
156+
padding: '32px',
157+
158+
['>img']: {
159+
width: '128px',
160+
aspectRatio: '1 / 1',
161+
},
156162
});
157163

158164
export {

0 commit comments

Comments
 (0)