Skip to content

Commit 8829925

Browse files
Copilotjefim
andcommitted
Improve transaction disposal with using statements
Co-authored-by: jefim <1387820+jefim@users.noreply.github.com>
1 parent 9421ca6 commit 8829925

1 file changed

Lines changed: 2 additions & 4 deletions

File tree

  • Frends.PostgreSQL.ExecuteQuery/Frends.PostgreSQL.ExecuteQuery

Frends.PostgreSQL.ExecuteQuery/Frends.PostgreSQL.ExecuteQuery/ExecuteQuery.cs

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ public static async Task<Result> ExecuteQuery([PropertyTab] Input input, [Proper
6161
case ExecuteTypes.Auto:
6262
// Auto-detect: Try ExecuteReader first to check if data is returned
6363
{
64-
var transaction = conn.BeginTransaction(GetIsolationLevel(options.SqlTransactionIsolationLevel));
64+
using var transaction = conn.BeginTransaction(GetIsolationLevel(options.SqlTransactionIsolationLevel));
6565
cmd.Transaction = transaction;
6666

6767
using (var reader = await cmd.ExecuteReaderAsync(cancellationToken))
@@ -80,7 +80,6 @@ public static async Task<Result> ExecuteQuery([PropertyTab] Input input, [Proper
8080
} // Reader is disposed here
8181

8282
await transaction.CommitAsync(cancellationToken);
83-
transaction.Dispose();
8483
}
8584
break;
8685

@@ -95,12 +94,11 @@ public static async Task<Result> ExecuteQuery([PropertyTab] Input input, [Proper
9594
case ExecuteTypes.NonQuery:
9695
// Execute without returning data - use transaction
9796
{
98-
var transaction = conn.BeginTransaction(GetIsolationLevel(options.SqlTransactionIsolationLevel));
97+
using var transaction = conn.BeginTransaction(GetIsolationLevel(options.SqlTransactionIsolationLevel));
9998
cmd.Transaction = transaction;
10099
var rows = await cmd.ExecuteNonQueryAsync(cancellationToken);
101100
result = new Result(JToken.FromObject(new { AffectedRows = rows }));
102101
await transaction.CommitAsync(cancellationToken);
103-
transaction.Dispose();
104102
}
105103
break;
106104

0 commit comments

Comments
 (0)