I cannot get codecov to agree that the new code is littered by tests, so we'll just take it from here. All three PRs now ready for review @nichollsh and @planetmariana. I would suggest the order SPIDER -> Zalmoxis -> PROTEUS.
I was curious and asked copilot while being within your branch. Maybe this helps? It suggests you only have to update the codecov yaml to fix this problem.
"You’re seeing that because Codecov is comparing two different coverage universes, not just your changed lines.
- In this PR, CI uploads only the fast-suite report (unit+smoke) to Codecov with flag unit-tests from ci-pr-checks.yml:466-476.
- On main, the base commit also has nightly/full-suite coverage uploads (flag nightly) from ci-nightly.yml:514-523.
- Your codecov.yml:1-16 sets project status on overall coverage, so Codecov compares base overall (includes nightly) vs head overall (mostly fast suite), which creates an apparent repo-wide drop and marks many “indirect” lines/files as decreased.
"
Originally posted by @stuitje in #648 (comment)
Need to fix how codecov assess coverage % in PRs to get a reasonable number.
I was curious and asked copilot while being within your branch. Maybe this helps? It suggests you only have to update the codecov yaml to fix this problem.
"You’re seeing that because Codecov is comparing two different coverage universes, not just your changed lines.
"
Originally posted by @stuitje in #648 (comment)
Need to fix how codecov assess coverage % in PRs to get a reasonable number.