ST7789 Rotation.

[TimeToProgramming]

Hi, I found this library and wanted to run a 170x320 display. I am rewriting the code for myself to better understand the operation. I have a problem with the rotation settings. The display is bugging out and after a few days of analysis I don't know what the issue is anymore. Could someone help me and explain what I am doing wrong?

`/*FUNCTION st7789_spi_transmit is in Functions.c */

#include "main.h"
#include "ST7789_new.h"
#include "Functions.h"
#include "fonts.h"

#define LCD_RST1 GPIOB->BSRR|=GPIO_BSRR_BS6
#define LCD_RST0 GPIOB->BRR|=GPIO_BRR_BR6

#define LCD_DC1 GPIOB->BSRR|=GPIO_BSRR_BS7
#define LCD_DC0 GPIOB->BRR|=GPIO_BRR_BR7

#define LCD_BLK1 GPIOB->BSRR|=GPIO_BSRR_BS8
#define LCD_BLK0 GPIOB->BRR|=GPIO_BRR_BR8

#define LCD_CS1 GPIOB->BSRR|=GPIO_BSRR_BS1
#define LCD_CS0 GPIOB->BRR|=GPIO_BRR_BR1

/RESOLUTION STRUCT/
typedef struct {
uint16_t width;
uint16_t height;
uint8_t X_SHIFT;
uint8_t Y_SHIFT;
uint8_t resolution;
uint8_t rotation;
}ST7789_Resolution;

static ST7789_Resolution current_resolution;

static void ST7789_WriteCommand(uint8_t cmd)
{

LCD_DC0;
st7789_spi_transmit(&cmd,1);

}

static void ST7789_WriteData(uint8_t *buff, uint32_t buff_size)
{
LCD_DC1;
st7789_spi_transmit(buff,buff_size);

}

static void ST7789_WriteSmallData(uint8_t data)
{

LCD_DC1;
st7789_spi_transmit(&data,1);

}

void ST7789_SetRotation(uint8_t r){
current_resolution.rotation = r;
uint8_t madctl_data = 0x00;
uint16_t temp_width;
switch (r) {
case ST7789_ROTATION_0:
if(current_resolution.resolution & ST7789_RES_135x240){
current_resolution.X_SHIFT = 53;
current_resolution.Y_SHIFT = 40;
}
else if(current_resolution.resolution & ST7789_RES_240x240){
current_resolution.X_SHIFT = 0;
current_resolution.Y_SHIFT = 80;
}
else if(current_resolution.resolution & ST7789_RES_170x320){
current_resolution.X_SHIFT = 35;
current_resolution.Y_SHIFT = 0;
}

        //madctl_data = (ST7789_MADCTL_MX | ST7789_MADCTL_MY | ST7789_MADCTL_RGB);   //0° rotation
        madctl_data = ST7789_MADCTL_RGB;
        break;
    case ST7789_ROTATION_90:
        if(current_resolution.resolution & ST7789_RES_135x240){
            current_resolution.X_SHIFT = 40;
            current_resolution.Y_SHIFT = 52;
        }
        else if(current_resolution.resolution & ST7789_RES_240x240){
            current_resolution.X_SHIFT = 80;
            current_resolution.Y_SHIFT = 0;
        }
        else if(current_resolution.resolution & ST7789_RES_170x320){
            current_resolution.X_SHIFT = 0;
            current_resolution.Y_SHIFT = 35;
        }

        temp_width = current_resolution.width;
        current_resolution.width = current_resolution.height;
        current_resolution.height = temp_width;
        madctl_data = (ST7789_MADCTL_MY | ST7789_MADCTL_MV | ST7789_MADCTL_RGB);   //90° rotation
        break;
    case ST7789_ROTATION_180:
        if(current_resolution.resolution & ST7789_RES_135x240){
            current_resolution.X_SHIFT = 52;
            current_resolution.Y_SHIFT = 40;
        }
        else if(current_resolution.resolution & ST7789_RES_240x240){
            current_resolution.X_SHIFT = 0;
            current_resolution.Y_SHIFT = 0;
        }
        else if(current_resolution.resolution & ST7789_RES_170x320){
            current_resolution.X_SHIFT = 35;
            current_resolution.Y_SHIFT = 0;
        }
         madctl_data =  (ST7789_MADCTL_MY | ST7789_MADCTL_MX | ST7789_MADCTL_RGB);                                         //180° rotation
        break;
    case ST7789_ROTATION_270:
        if(current_resolution.resolution & ST7789_RES_135x240){
            current_resolution.X_SHIFT = 40;
            current_resolution.Y_SHIFT = 53;
        }
        else if(current_resolution.resolution & ST7789_RES_240x240){
            current_resolution.X_SHIFT = 0;
            current_resolution.Y_SHIFT = 0;
        }
        else if(current_resolution.resolution & ST7789_RES_170x320){
            current_resolution.X_SHIFT = 35;
            current_resolution.Y_SHIFT = 0;
        }

        temp_width = current_resolution.width;
        current_resolution.width = current_resolution.height;
        current_resolution.height = temp_width;
        madctl_data = (ST7789_MADCTL_MY | ST7789_MADCTL_MV | ST7789_MADCTL_RGB);   //270° rotation
        break;
}
ST7789_WriteCommand(ST7789_MADCTL);                 //Ustawienie kontrolera dostępu do pamięci
ST7789_WriteSmallData(madctl_data);

}

void ST7789_Init(uint8_t display_size, uint8_t rotation){
/DISPLAY RESET/
current_resolution.resolution = display_size;
LCD_BLK1;
LCD_RST0;
delay(50);
LCD_RST1;
delay(50);
ST7789_WriteCommand(ST7789_SWRESET);
delay(140);
/CONFIG/
/COLORMODE/
ST7789_WriteCommand(ST7789_COLMOD); //COLORMODE
ST7789_WriteSmallData(ST7789_COLOR_MODE_16bit); //16-bit/pixel (RGB565)
/PORCH CONTROL/
ST7789_WriteCommand(0xB2); //Porch control
uint8_t data[] = {0x0C, 0x0C, 0x00, 0x33, 0x33};
ST7789_WriteData(data, sizeof(data));
/Internal LCD Voltage generator settings/
ST7789_WriteCommand(0xB7); //Gate Control
ST7789_WriteSmallData(0x35); //Domyślna wartość
ST7789_WriteCommand(0xBB); //VCOM setting
ST7789_WriteSmallData(0x20); //0.725V (domyślnie 0.75V dla 0x20)
ST7789_WriteCommand(0xC0); //LCMCTRL
ST7789_WriteSmallData(0x2C); //Domyślna wartość
ST7789_WriteCommand(0xC2); //VDV and VRH command Enable
ST7789_WriteSmallData(0x01); //Domyślna wartość
ST7789_WriteCommand(0xC3); //VRH set
ST7789_WriteSmallData(0x0B); //+-4.45V (domyślnie +-4.1V dla 0x0B)
ST7789_WriteCommand(0xC4); //VDV set
ST7789_WriteSmallData(0x20); //Domyślna wartość
ST7789_WriteCommand(0xC6); //Frame rate control in normal mode
ST7789_WriteSmallData(0x0F); //Domyślna wartość (60Hz)
/POWER CONTROL/
ST7789_WriteCommand(0xD0); //Power control
ST7789_WriteSmallData(0xA4); //Domyślna wartość
ST7789_WriteSmallData(0xA1); //Domyślna wartość
/RESOLUTION/
switch (display_size) {
case ST7789_RES_135x240:
current_resolution.width = 135;
current_resolution.height = 240;
ST7789_WriteCommand(ST7789_CASET); //Column Address Set
uint8_t column_addr_135x240[] = {0x00, 0x00, 0x00, 0xEF}; //135 columns
ST7789_WriteData(column_addr_135x240, sizeof(column_addr_135x240));
ST7789_WriteCommand(ST7789_RASET); //Row Address Set
uint8_t row_addr_135x240[] = {0x00, 0x00, 0x01, 0x3F}; //240 rows
ST7789_WriteData(row_addr_135x240, sizeof(row_addr_135x240));
break;
case ST7789_RES_240x240:
current_resolution.width = 240;
current_resolution.height = 240;
ST7789_WriteCommand(ST7789_CASET); //Column Address Set
uint8_t column_addr_240x240[] = {0x00, 0x00, 0x00, 0xEF}; //240 columns
ST7789_WriteData(column_addr_240x240, sizeof(column_addr_240x240));
ST7789_WriteCommand(ST7789_RASET); //Row Address Set
uint8_t row_addr_240x240[] = {0x00, 0x00, 0x00, 0xEF}; //240 rows
ST7789_WriteData(row_addr_240x240, sizeof(row_addr_240x240));
break;
case ST7789_RES_170x320:
current_resolution.width = 170;
current_resolution.height = 320;
ST7789_WriteCommand(ST7789_CASET); //Column Address Set
uint8_t column_addr_170x320[] = {0x00, 0x00, 0x00, 0xA1}; //170 columns
ST7789_WriteData(column_addr_170x320, sizeof(column_addr_170x320));
ST7789_WriteCommand(ST7789_RASET); //Row Address Set
uint8_t row_addr_170x320[] = {0x00, 0x00, 0x01, 0x3F}; //320 rows
ST7789_WriteData(row_addr_170x320, sizeof(row_addr_170x320));
break;
}
/GAMMA SETTING/
ST7789_WriteCommand(0xE0); //Gamma curve selected
uint8_t gamma_data[] = {0xD0, 0x04, 0x0D, 0x11, 0x13, 0x2B, 0x3F, 0x54, 0x4C, 0x18, 0x0D, 0x0B, 0x1F, 0x23};
ST7789_WriteData(gamma_data, sizeof(gamma_data));
ST7789_WriteCommand(0xE1); //Gamma curve adjustment
uint8_t gamma_adjustment[] = {0xD0, 0x04, 0x0C, 0x11, 0x13, 0x2C, 0x3F, 0x44, 0x51, 0x2F, 0x1F, 0x1F, 0x20, 0x23};
ST7789_WriteData(gamma_adjustment, sizeof(gamma_adjustment));
/ROTATION/
ST7789_SetRotation(rotation);
/END COMMANDS/
ST7789_WriteCommand(ST7789_INVON); //Inversion ON
ST7789_WriteCommand(ST7789_SLPOUT); //Out of sleep mode
ST7789_WriteCommand(ST7789_NORON); //Normal Display on
ST7789_Fill_Color(BLACK); //Wypełnienie kolorem czarnym
ST7789_WriteCommand(ST7789_DISPON); //Główne włączenie wyświetlacza
}

void ST7789_Fill_Color(uint16_t color){
ST7789_SetAddressWindow(0, 0, current_resolution.width - 1, current_resolution.height - 1);
uint16_t i;
for (i = 0; i < current_resolution.width; i++){
for (uint16_t j = 0; j < current_resolution.height; j++) {
uint8_t data[] = {color >> 8, color & 0xFF};
ST7789_WriteData(data, sizeof(data));
}
}
}

void ST7789_SetAddressWindow(uint16_t x0, uint16_t y0, uint16_t x1, uint16_t y1){
uint16_t x_start = x0 + current_resolution.X_SHIFT, x_end = x1 + current_resolution.X_SHIFT;
uint16_t y_start = y0 + current_resolution.Y_SHIFT, y_end = y1 + current_resolution.Y_SHIFT;
ST7789_WriteCommand(ST7789_CASET); // Column Address Set
uint8_t data1[] = {x_start >> 8, x_start & 0xFF, x_end >> 8, x_end & 0xFF};
ST7789_WriteData(data1, sizeof(data1));

ST7789_WriteCommand(ST7789_RASET); // Row Address Set
uint8_t data2[] = {y_start >> 8, y_start & 0xFF, y_end >> 8, y_end & 0xFF};
ST7789_WriteData(data2, sizeof(data2));
ST7789_WriteCommand(ST7789_RAMWR);

}

void ST7789_WriteChar(uint16_t x, uint16_t y, char ch, FontDef font, uint16_t color, uint16_t bgcolor){
uint32_t i, b, j;

ST7789_SetAddressWindow(x, y, x + font.width - 1, y + font.height - 1);

for (i = 0; i < font.height; i++) {
	b = font.data[(ch - 32) * font.height + i];
	for (j = 0; j < font.width; j++) {
		if ((b << j) & 0x8000) {
			uint8_t data[] = {color >> 8, color & 0xFF};
			ST7789_WriteData(data, sizeof(data));
		}
		else {
			uint8_t data[] = {bgcolor >> 8, bgcolor & 0xFF};
			ST7789_WriteData(data, sizeof(data));
		}
	}
}

}

void ST7789_WriteString(uint16_t x, uint16_t y, const char *str, FontDef font, uint16_t color, uint16_t bgcolor)
{

while (*str) {
	if (x + font.width >= current_resolution.width) {
		x = 0;
		y += font.height;
		if (y + font.height >= current_resolution.height) {
			break;
		}

		if (*str == ' ') {
			// skip spaces in the beginning of the new line
			str++;
			continue;
		}
	}
	ST7789_WriteChar(x, y, *str, font, color, bgcolor);
	x += font.width;
	str++;
}

}`

[5Breeze]

you can try this：/**

• @brief Set the rotation direction of the display

• @param m -> rotation parameter(please refer it in st7789.h)

• @return none
  /
  void ST7789_SetRotation(uint8_t m)
  {
  ST7789_WriteCommand(ST7789_MADCTL); // MADCTL
  switch (m) {
  case 0:
  ST7789_WriteSmallData(0);
  break;
  case 1:
  ST7789_WriteSmallData((1<<6)|(1<<5));
  break;
  case 2:
  ST7789_WriteSmallData((1<<6)|(1<<7));
  break;
  case 3:
  ST7789_WriteSmallData((1<<7)|(1<<5));
  break;
  default:
  break;
  }
  }
  and replace：
  /*

• @brief Initialize ST7789 controller

• @param none

• @return none
  */
  void ST7789_Init(void)
  {
  #ifdef USE_DMA
  memset(disp_buf, 0, sizeof(disp_buf));
  #endif
  HAL_Delay(10);
  ST7789_RST_Clr();
  HAL_Delay(10);
  ST7789_RST_Set();
  HAL_Delay(20);

  ST7789_WriteCommand(0x36);
  ST7789_WriteSmallData(0x00);

  ST7789_WriteCommand(0x3A);
  ST7789_WriteSmallData(0x05);

  ST7789_WriteCommand(0xB2); // Porch control
  {
  uint8_t data[] = {0x0C, 0x0C, 0x00, 0x33, 0x33};
  ST7789_WriteData(data, sizeof(data));
  }
  ST7789_SetRotation(ST7789_ROTATION); // MADCTL (Display Rotation)

  /* Internal LCD Voltage generator settings */
  ST7789_WriteCommand(0XB7); // Gate Control
  ST7789_WriteSmallData(0x35); // Default value
  ST7789_WriteCommand(0xBB); // Gate Control
  ST7789_WriteSmallData(0x1A); // Default value

  //ST7789_WriteCommand(0x1A); // VCOM setting
  //ST7789_WriteSmallData(0x19); // 0.725v (default 0.75v for 0x20)
  ST7789_WriteCommand(0xC0); // LCMCTRL
  ST7789_WriteSmallData (0x2C); // Default value
  ST7789_WriteCommand (0xC2); // VDV and VRH command Enable
  ST7789_WriteSmallData (0x01); // Default value
  ST7789_WriteCommand (0xC3); // VRH set
  ST7789_WriteSmallData (0x0B); // +-4.45v (defalut +-4.1v for 0x0B)
  ST7789_WriteCommand (0xC4); // VDV set
  ST7789_WriteSmallData (0x20); // Default value
  ST7789_WriteCommand (0xC6); // Frame rate control in normal mode
  ST7789_WriteSmallData (0x0F); // Default value (60HZ)
  ST7789_WriteCommand (0xD0); // Power control
  ST7789_WriteSmallData (0xA4); // Default value
  ST7789_WriteSmallData (0xA1); // Default value
  /**************** Division line ****************/

ST7789_WriteCommand(0xE0);
{
uint8_t data[] = {0x00, 0x03, 0x07, 0x08, 0x07, 0x15, 0x2A, 0x44, 0x42, 0x0A, 0x17, 0x18, 0x25, 0x27};
ST7789_WriteData(data, sizeof(data));
}

ST7789_WriteCommand(0xE1);
{
uint8_t data[] = {0x00, 0x03, 0x08, 0x07, 0x07, 0x23, 0x2A, 0x43, 0x42, 0x09, 0x18, 0x17, 0x25, 0x27};
ST7789_WriteData(data, sizeof(data));
}
ST7789_WriteCommand (ST7789_INVON); // Inversion ON
ST7789_WriteCommand (ST7789_SLPOUT); // Out of sleep mode
ST7789_WriteCommand (ST7789_NORON); // Normal Display on
ST7789_WriteCommand (ST7789_DISPON); // Main screen turned on

HAL_Delay(50);
ST7789_Fill_Color(BLACK);				//	Fill with Black.

}