Modify the medfab to be able to make gas analyzers#583
Conversation
deltaSpawn0040
requested review from
M3739,
Mnemotechnician and
SyaoranFox
as code owners
|
|
||
| - type: latheRecipePack #Euphoria - So that medfabs can make gas analyzers | ||
| id: AtmosToolsForCryogenics | ||
| recipes: | ||
| - GasAnalyzer | ||
|
|
There was a problem hiding this comment.
Please put this under _Floof.
There was a problem hiding this comment.
I don't understand why this would go under _Floof. Is this something that existed on Floof and thus would be considered a port?
There was a problem hiding this comment.
All new prototypes, classes, and other resources must be placed under our namespace to avoid conflicts with upstream and also make it easier for us to trace where each prototype/resource came from. The developer handbook briefly covers this topic: https://docs.spacestation14.com/en/general-development/tips/forking.html?highlight=namespace#put-your-code-in-dedicated-server-folders
There was a problem hiding this comment.
Ah, I see. I read "In general anything you create from scratch (not modifying something that exists from upstream) should go in the Euphoria subfolder, _Euphoria." and thought "Hm, well, medical.yml is something from upstream, so this doesn't apply" but the word "something" was meant to refer to things like prototypes and classes, not files. I never did well with words like "something" and "over there".
I am still confused as to why it would be under _Floof and not _Euphoria?
There was a problem hiding this comment.
Whichever works, but _Euphoria is honestly a mistake because it's too verbose for a namespace
There was a problem hiding this comment.
Alright, thank you for reviewing/replying so quickly. I've moved AtmosToolsForCryogenics to its own little medical.yml file under _Euphoria, tested that works, merged recent stuff from here (even though I don't think that was necessary, I just got paranoid), and then wiped my greasy little fingerprints off of the upstream medical.yml ^w^
2 participants
About the PR
Changes medfabs to be able to make gas analyzers.
Why / Balance
Currently, the vast majority of medical departments come with cryo pods installed, and some start with gas analyzers in them, but some don't. In the cases where they don't, some poor doctor must trudge all the way to science and hope someone's at the window to go and push a button on their autolathe to dispense the tool, then trudge back to medical and find that someone already healed that dead patient with surgery and no one wants to practice cryo. They may then, optionally, proceed to weep because they haven't gotten to do cryo in months.
In my opinion, it's not great that, depending on the map, doctors won't be able to safely check if their cryo pods will kill someone or not without asking someone in another department for a tool that's available to several other departments at round start and simply provides information, and the extent of gameplay this scenario provides for science is clicking a button in the autolathe menu.
Technical details
This isn't a major change, but be warned that this is my first PR anywhere ever. I've done my best to dot every i and make sure every error wasn't my fault, but still... be warned. Is this small? Yes. Do I know for certain everything it will do? Absolutely not. Who even knows. Hopefully you! This is a copy of another PR I made just now because I fucked up :3
Media
Click to show
2026-05-16.09-26-52.copy.mp4
Requirements
Licensing:
Breaking changes
I sure hope there aren't any!
Changelog
🆑