Skip to content

Commit ebb9004

Browse files
talissoncostaclaude
andcommitted
fix: align unsaved changes badge in Edit Feature modal tabs
The create-feature modal was refactored from .js to .tsx on main, so the original fix was lost during rebase. Apply the same fix: remove Row wrappers and redundant padding classes from tab labels, letting .btn-tab__label handle alignment. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent b4eba04 commit ebb9004

File tree

1 file changed

+14
-31
lines changed
  • frontend/web/components/modals/create-feature

1 file changed

+14
-31
lines changed

frontend/web/components/modals/create-feature/index.tsx

Lines changed: 14 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -571,12 +571,10 @@ const CreateFeatureModal: FC<CreateFeatureModalProps> = (props) => {
571571
data-test='value'
572572
tabLabelString='Value'
573573
tabLabel={
574-
<Row className='justify-content-center'>
575-
Value{' '}
576-
{valueChanged && (
577-
<div className='unread ml-2 px-1'>{'*'}</div>
578-
)}
579-
</Row>
574+
<>
575+
Value
576+
{valueChanged && <div className='unread'>*</div>}
577+
</>
580578
}
581579
>
582580
<FeatureValueTab
@@ -615,16 +613,10 @@ const CreateFeatureModal: FC<CreateFeatureModalProps> = (props) => {
615613
data-test='segment_overrides'
616614
tabLabelString='Segment Overrides'
617615
tabLabel={
618-
<Row
619-
className={`justify-content-center ${
620-
segmentsChanged ? 'pr-1' : ''
621-
}`}
622-
>
623-
Segment Overrides{' '}
624-
{segmentsChanged && (
625-
<div className='unread ml-2 px-2'>*</div>
626-
)}
627-
</Row>
616+
<>
617+
Segment Overrides
618+
{segmentsChanged && <div className='unread'>*</div>}
619+
</>
628620
}
629621
>
630622
<SegmentOverridesTab
@@ -660,12 +652,7 @@ const CreateFeatureModal: FC<CreateFeatureModalProps> = (props) => {
660652
</TabItem>
661653
)}
662654
{(!Project.disableAnalytics || hasCodeReferences) && (
663-
<TabItem
664-
tabLabelString='Usage'
665-
tabLabel={
666-
<Row className='justify-content-center'>Usage</Row>
667-
}
668-
>
655+
<TabItem tabLabelString='Usage' tabLabel='Usage'>
669656
<UsageTab
670657
projectId={projectId}
671658
featureId={projectFlag.id}
@@ -691,9 +678,7 @@ const CreateFeatureModal: FC<CreateFeatureModalProps> = (props) => {
691678
<TabItem
692679
data-test='external-resources-links'
693680
tabLabelString='Links'
694-
tabLabel={
695-
<Row className='justify-content-center'>Links</Row>
696-
}
681+
tabLabel='Links'
697682
>
698683
<ExternalResourcesLinkTab
699684
githubId={githubId}
@@ -719,12 +704,10 @@ const CreateFeatureModal: FC<CreateFeatureModalProps> = (props) => {
719704
data-test='settings'
720705
tabLabelString='Settings'
721706
tabLabel={
722-
<Row className='justify-content-center'>
723-
Settings{' '}
724-
{settingsChanged && (
725-
<div className='unread ml-2 px-1'>{'*'}</div>
726-
)}
727-
</Row>
707+
<>
708+
Settings
709+
{settingsChanged && <div className='unread'>*</div>}
710+
</>
728711
}
729712
>
730713
<FeatureSettings

0 commit comments

Comments
 (0)