Less allocations.

Author: cincuranet

Provider/src/FirebirdSql.Data.FirebirdClient/Client/Managed/Version10/GdsDatabase.cs

@@ -368,35 +368,35 @@ public virtual void ConnectionRequest(out int auxHandle, out string ipAddress, o
 
 				auxHandle = XdrStream.ReadInt32();
 
-				// garbage
-				XdrStream.ReadBytes(8);
+				var garbage1 = new byte[8];
+				XdrStream.ReadBytes(garbage1);
 
 				var respLen = XdrStream.ReadInt32();
 				respLen += respLen % 4;
 
-				// sin_family
-				XdrStream.ReadBytes(2);
+				var sin_family = new byte[2];
+				XdrStream.ReadBytes(sin_family);
 				respLen -= 2;
 
-				// sin_port
-				var buffer = XdrStream.ReadBytes(2);
-				portNumber = (ushort)IPAddress.NetworkToHostOrder(BitConverter.ToInt16(buffer, 0));
+				var sin_port = new byte[2];
+				XdrStream.ReadBytes(sin_port);
+				portNumber = (ushort)IPAddress.NetworkToHostOrder(BitConverter.ToInt16(sin_port, 0));
 				respLen -= 2;
 
 				// * The address returned by the server may be incorrect if it is behind a NAT box
 				// * so we must use the address that was used to connect the main socket, not the
 				// * address reported by the server.
-				// sin_addr
-				buffer = XdrStream.ReadBytes(4);
+				var sin_addr = new byte[4];
+				XdrStream.ReadBytes(sin_addr);
 				//ipAddress = string.Format(
 				//    CultureInfo.InvariantCulture,
 				//    "{0}.{1}.{2}.{3}",
 				//    buffer[0], buffer[1], buffer[2], buffer[3]);
 				ipAddress = _connection.IPAddress.ToString();
 				respLen -= 4;
 
-				// garbage
-				XdrStream.ReadBytes(respLen);
+				var garbage2 = new byte[respLen];
+				XdrStream.ReadBytes(garbage2);
 
 				XdrStream.ReadStatusVector();
 			}

Provider/src/FirebirdSql.Data.FirebirdClient/Client/Managed/Version10/GdsEventManager.cs

@@ -56,7 +56,8 @@ public async Task WaitForEventsAsync(RemoteEvent remoteEvent)
 						case IscCodes.op_event:
 							var dbHandle = _database.XdrStream.ReadInt32();
 							var buffer = _database.XdrStream.ReadBuffer();
-							var ast = _database.XdrStream.ReadBytes(8);
+							var ast = new byte[8];
+							_database.XdrStream.ReadBytes(ast);
 							var eventId = _database.XdrStream.ReadInt32();
 
 							remoteEvent.EventCounts(buffer);

Provider/src/FirebirdSql.Data.FirebirdClient/Client/Managed/XdrStream.cs

@@ -334,9 +334,9 @@ private void ResetOperation()
 
 		#region XDR Read Methods
 
-		public byte[] ReadBytes(int count)
+		public byte[] ReadBytes(byte[] buffer)
 		{
-			var buffer = new byte[count];
+			var count = buffer.Length;
 			if (count > 0)
 			{
 				var toRead = count;
@@ -353,9 +353,9 @@ public byte[] ReadBytes(int count)
 			}
 			return buffer;
 		}
-		public async Task<byte[]> ReadBytesAsync(int count)
+		public async Task<byte[]> ReadBytesAsync(byte[] buffer)
 		{
-			var buffer = new byte[count];
+			var count = buffer.Length;
 			if (count > 0)
 			{
 				var toRead = count;
@@ -375,7 +375,8 @@ public async Task<byte[]> ReadBytesAsync(int count)
 
 		public byte[] ReadOpaque(int length)
 		{
-			var buffer = ReadBytes(length);
+			var buffer = new byte[length];
+			ReadBytes(buffer);
 			var padLength = ((4 - length) & 3);
 			if (padLength > 0)
 			{
@@ -416,18 +417,26 @@ public short ReadInt16()
 			return Convert.ToInt16(ReadInt32());
 		}
 
+		private byte[] int32Buffer = new byte[4];
 		public int ReadInt32()
 		{
-			return IPAddress.HostToNetworkOrder(BitConverter.ToInt32(ReadBytes(4), 0));
+			Array.Clear(int32Buffer, 0, 4);
+			ReadBytes(int32Buffer);
+			return IPAddress.HostToNetworkOrder(BitConverter.ToInt32(int32Buffer, 0));
 		}
 		public async Task<int> ReadInt32Async()
 		{
-			return IPAddress.HostToNetworkOrder(BitConverter.ToInt32(await ReadBytesAsync(4).ConfigureAwait(false), 0));
+			Array.Clear(int32Buffer, 0, 4);
+			await ReadBytesAsync(int32Buffer).ConfigureAwait(false);
+			return IPAddress.HostToNetworkOrder(BitConverter.ToInt32(int32Buffer, 0));
 		}
 
+		private byte[] int64Buffer = new byte[8];
 		public long ReadInt64()
 		{
-			return IPAddress.HostToNetworkOrder(BitConverter.ToInt64(ReadBytes(8), 0));
+			Array.Clear(int64Buffer, 0, 8);
+			ReadBytes(int64Buffer);
+			return IPAddress.HostToNetworkOrder(BitConverter.ToInt64(int64Buffer, 0));
 		}
 
 		public Guid ReadGuid()