Skip to content

Commit 59a56f0

Browse files
wlallemandcapflam
authored andcommitted
BUG/MINOR: acme/cli: fix argument check and error in 'acme challenge_ready'
Fix the check or arguments of the 'acme challenge_ready' command which was checking if all arguments are NULL instead of one of the argument. Must be backported to 3.2 and later. (cherry picked from commit 8e250bb) Signed-off-by: Christopher Faulet <cfaulet@haproxy.com> (cherry picked from commit ac2886a) Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
1 parent fc694ea commit 59a56f0

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

src/acme.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2768,8 +2768,8 @@ static int cli_acme_chall_ready_parse(char **args, char *payload, struct appctx
27682768
int remain = 0;
27692769
struct ebmb_node *node = NULL;
27702770

2771-
if (!*args[2] && !*args[3] && !*args[4]) {
2772-
memprintf(&msg, ": not enough parameters\n");
2771+
if (!*args[2] || !*args[3] || !*args[4]) {
2772+
memprintf(&msg, "Not enough parameters: \"acme challenge_ready <certfile> domain <domain>\"\n");
27732773
goto err;
27742774
}
27752775

0 commit comments

Comments
 (0)