Skip to content
This repository was archived by the owner on Dec 1, 2023. It is now read-only.

Commit 45247ac

Browse files
disable exit handler removal
1 parent 5b27284 commit 45247ac

File tree

4 files changed

+1
-8
lines changed

4 files changed

+1
-8
lines changed

dist/messenger.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,6 @@ class Messenger {
4545
connect(channel) {
4646
this.channel = channel;
4747
this.onMessageHandler = async (message) => {
48-
console.log('[ProcessHelper::Messenger]', 'Received message:', message);
4948
if (this.pendingMessages.has(message.id)) {
5049
const fn = this.pendingMessages.get(message.id);
5150
this.pendingMessages.delete(message.id);
@@ -101,7 +100,6 @@ class Messenger {
101100
console.error('[ProcessHelper::Messenger]', 'Error on listener:', err);
102101
}
103102
}));
104-
this.channel.off('exit', this.onExitHandler);
105103
};
106104
this.channel.on('message', this.onMessageHandler);
107105
this.channel.on('exit', this.onExitHandler);

dist/process-helper.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,6 @@ class ProcessHelper extends messenger_1.Messenger {
5151
this.autoRestartListener = undefined;
5252
this.childProcess.kill('SIGTERM');
5353
this.childProcess = undefined;
54-
console.log("children's process killed");
5554
}
5655
else {
5756
console.warn('cannot kill child process because pid is undefined');

src/messenger.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ export class Messenger {
5151
}
5252
}
5353

54-
private sendStatus(status: 'connected' | 'disconnected') {
54+
private sendStatus(status: 'connected') { // use 'onExit' for 'disconnected'
5555
if (!this.channel) {
5656
console.error('[ProcessHelper::Messenger]', 'Cannot send status change, channel is not connected');
5757
return;
@@ -70,7 +70,6 @@ export class Messenger {
7070
this.channel = channel;
7171

7272
this.onMessageHandler = async (message: { event: string, id: string, payload: any, err?: any }) => {
73-
console.log('[ProcessHelper::Messenger]', 'Received message:', message);
7473
if (this.pendingMessages.has(message.id)) {
7574
// we've received a response to our previously sent request
7675

@@ -134,7 +133,6 @@ export class Messenger {
134133
}
135134
}),
136135
);
137-
this.channel!.off('exit', this.onExitHandler!);
138136
};
139137

140138
this.channel.on('message', this.onMessageHandler);
@@ -144,7 +142,6 @@ export class Messenger {
144142
}
145143

146144
protected disconnect() {
147-
// this.sendStatus('disconnected');
148145
this.channel!.off('message', this.onMessageHandler!);
149146

150147
this.pendingMessages.forEach(p => p.reject(new Error('Process was disconnected')));

src/process-helper.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,6 @@ export class ProcessHelper extends Messenger {
7676

7777
this.childProcess.kill('SIGTERM');
7878
this.childProcess = undefined;
79-
console.log("children's process killed");
8079
} else {
8180
console.warn('cannot kill child process because pid is undefined');
8281
}

0 commit comments

Comments
 (0)