From 018e58aa83028fbbf5c31ada8165b2d6fc06a1d5 Mon Sep 17 00:00:00 2001 From: Eng Zer Jun Date: Thu, 2 Jan 2025 00:22:27 +0800 Subject: [PATCH] test: use math/rand/v2 We upgraded our minimum Go version in PR https://github.com/FastFilter/xorfilter/pull/39, so we can use the `math/rand/v2` package too. Reference: https://go.dev/blog/randv2 Signed-off-by: Eng Zer Jun --- binaryfusefilter_test.go | 12 ++++++------ xorfilter_test.go | 6 +++--- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/binaryfusefilter_test.go b/binaryfusefilter_test.go index 1f94b8d..61ac2e3 100644 --- a/binaryfusefilter_test.go +++ b/binaryfusefilter_test.go @@ -2,7 +2,7 @@ package xorfilter import ( "fmt" - "math/rand" + "math/rand/v2" "testing" "github.com/cespare/xxhash" @@ -43,9 +43,9 @@ func TestBinaryFuseNBasic(t *testing.T) { } keys = keys[:cut] for trial := 0; trial < 10; trial++ { - rand.Seed(int64(trial)) + r := rand.New(rand.NewPCG(uint64(trial), uint64(trial))) for i := range keys { - keys[i] = rand.Uint64() + keys[i] = r.Uint64() } filter, _ = NewBinaryFuse[testType](keys) for _, v := range keys { @@ -93,9 +93,9 @@ func TestBinaryFuseNSmall(t *testing.T) { } keys = keys[:cut] for trial := 0; trial < 10; trial++ { - rand.Seed(int64(trial)) + r := rand.New(rand.NewPCG(uint64(trial), uint64(trial))) for i := range keys { - keys[i] = rand.Uint64() + keys[i] = r.Uint64() } filter, _ = NewBinaryFuse[testType](keys) for _, v := range keys { @@ -317,7 +317,7 @@ func TestBinaryFuseN_Issue35(t *testing.T) { for test := 0; test < 100; test++ { hashes := make([]uint64, 0) for i := 0; i < 40000; i++ { - v := encode(int32(rand.Intn(10)), int32(rand.Intn(100000))) + v := encode(rand.Int32N(10), rand.Int32N(100000)) hashes = append(hashes, xxhash.Sum64(v)) } inner, err := NewBinaryFuse[testType](hashes) diff --git a/xorfilter_test.go b/xorfilter_test.go index 2d1deed..ed946f8 100644 --- a/xorfilter_test.go +++ b/xorfilter_test.go @@ -2,7 +2,7 @@ package xorfilter import ( "fmt" - "math/rand" + "math/rand/v2" "testing" "time" "unsafe" @@ -182,7 +182,7 @@ func BenchmarkXor8bigContains50000000(b *testing.B) { func TestFSDIssue35_basic(t *testing.T) { hashes := make([]uint64, 0) for i := 0; i < 2000; i++ { - v := encode(int32(rand.Intn(10)), int32(rand.Intn(100000))) + v := encode(rand.Int32N(10), rand.Int32N(100000)) hashes = append(hashes, xxhash.Sum64(v)) } inner, err := Populate(hashes) @@ -202,7 +202,7 @@ func Test_Issue35_basic(t *testing.T) { for test := 0; test < 100; test++ { hashes := make([]uint64, 0) for i := 0; i < 40000; i++ { - v := encode(int32(rand.Intn(10)), int32(rand.Intn(100000))) + v := encode(rand.Int32N(10), rand.Int32N(100000)) hashes = append(hashes, xxhash.Sum64(v)) } inner, err := PopulateBinaryFuse8(hashes)