Replace ban text with localizable message

[Askaholic]

The server should not be sending any strings that get rendered in the client, because these strings are in English and we can't be sure that the user on the other end has their client set to English (in fact a majority of people probably knows English only as a second language, or does not know it very well at all). In fact issue #444 already covers this, but I'm making another ticket just for this message because changing it would allow us to drop the humanize dependency.

Here is a link to the message:

server/server/lobbyconnection.py

Line 1094 in e4ca993

raise ClientError((f"You are banned from FAF {ban_time_text}.\n "

It should be replaced with something like:

{
    "command": "banned",
    "expires_at": <ISO timestamp>
}

See #183 for inspiration, but note that we should be sending ISO timestamps (in UTC) and not timedeltas.

---

IssueHunt Summary

Backers (Total: $5.00)

• askaholic ($5.00)

Become a backer now!

Or submit a pull request to get the deposits!

Tips

• Checkout the Issuehunt explorer to discover more funded issues.
• Need some help from other developers? Add your repositories on IssueHunt to raise funds.

[issuehunt-oss]

@askaholic has funded $5.00 to this issue.

---

• Submit pull request via IssueHunt to receive this reward.
• Want to contribute? Chip in to this issue via IssueHunt.
• Checkout the IssueHunt Issue Explorer to see more funded issues.
• Need help from developers? Add your repository on IssueHunt to raise funds.

[cb0806151]

Hey @Askaholic, could I try fixing this issue or do you already have someone lined up to work on it?

[Askaholic]

Yea go for it, note that it will also require a PR to https://github.com/FAForever/downlords-faf-client

[cb0806151]

@Askaholic Are you and the team using a Linux OS when developing this application? Running into some issues that seem windows-based

[Askaholic]

Yea I’ve only run the server on Linux, but I think @Sheikah45 was able to get it working on Windows. If you’re on the FAF discord you can also PM me there.

[Sheikah45]

I can confirm I was able to get it working had to use docker desktop and WSL

[cb0806151]

@Askaholic I wasn't originally aware that this was going to need to be handled with linux, and WSL is being uncooperative with my machine. I can set up a linux OS on a spare laptop I have to fix this, but that would take quite a while; because of that, I think it'd be best if I recuse myself from fixing this issue. I should have done further research into it before volunteering and apologize for the time of yours that I have wasted

[Askaholic]

No worries, just let me know if you want to work on it in the future!

[rajdeep-biswas]

Is this still open? I could take this up.

[Askaholic]

@therajdeepbiswas Yea for sure! I should edit the issue because I think we should make it a bit simpler than I originally described. I think the right approach would be to just add an i18n key to the message in addition to the English text.

{
    "command": "notice",
    "style": "error",
    "text": "You are banned from FAF for 1 month",
    "i18n_key": "login.error.banned",
    "i18n_args": ["<ISO timestamp"]
}

I'm not entirely sure how the args stuff would work, that would be something to figure out.