Catch ASG error

Author: zhaoqin-github

app/waf/src/controllers/wafpolicy.controller.ts

@@ -227,9 +227,11 @@ export class WafpolicyController extends BaseController {
         wafpolicy.id,
       );
     } catch (error) {
-      throw new HttpErrors.unprocessableEntity(
-        'check wafpolicy from asg service failed',
-      );
+      if (error.code === 404) {
+        throw new HttpErrors.NotFound(`ASG error: ${error.message}`);
+      } else {
+        throw new HttpErrors.UnprocessableEntity(`ASG error: ${error.message}`);
+      }
     }
 
     if (!resp || !resp[0]) {

app/waf/test/acceptance/wafpolicy.controller.acceptance.ts

@@ -236,6 +236,33 @@ describe('WafpolicyController', () => {
     },
   );
 
+  it(
+    'get ' +
+      prefix +
+      '/wafpolicies/${id}/adcs/${adcId}: ASG fails when check wafpolicy',
+    async () => {
+      const wafpolicy = await givenWafpolicyData(wafapp, {
+        tenantId: 'a random id',
+        public: true,
+      });
+
+      const adc = await givenAdcData(wafapp, {
+        management: {
+          trustedDeviceId: uuid(),
+        },
+      });
+
+      checkWafpolicyStub.throws(new Error('OMG'));
+
+      const resp = await client
+        .get(prefix + `/wafpolicies/${wafpolicy.id}/adcs/${adc.id}`)
+        .set('X-Auth-Token', ExpectedData.userToken)
+        .set('tenant-id', ExpectedData.tenantId)
+        .expect(422);
+
+      expect(resp.body.error.message).equal('ASG error: OMG');
+    },
+  );
   it('get ' + prefix + '/wafpolicies: of all', async () => {
     const wafpolicy = await givenWafpolicyData(wafapp);
 

test/onboard-collection.json

@@ -1992,29 +1992,36 @@
 							"script": {
 								"id": "8a7c44c1-f82e-4877-b56b-406c1f5efb7d",
 								"exec": [
-									"pm.test('response code is 200', function () {",
-									"    pm.response.to.have.status(200);",
+									"pm.test('response code is 200 or 404', function () {",
+									"    console.log(pm.response.code);",
+									"    pm.expect(pm.response.code).to.be.oneOf([200, 404]);",
 									"});",
 									"",
-									"let resp = pm.response.json();",
+									"if (pm.response.code === 404) {",
+									"    // ASG may return 404 sometimes during uploading",
+									"    postman.setNextRequest('wait-wafpolicy-upload');",
+									"    setTimeout(function(){}, 10000)",
+									"} else {",
+									"  let resp = pm.response.json();",
 									"",
-									"console.log(resp.wafpolicyondevice.state);",
+									"  console.log(resp.wafpolicyondevice.state);",
 									"",
-									"let retry = Number(pm.environment.get('UPLOAD_RETRY'));",
-									"if (retry === 0) {",
+									"  let retry = Number(pm.environment.get('UPLOAD_RETRY'));",
+									"  if (retry === 0) {",
 									"    pm.test('Upload WAF policy timeout', function () {",
 									"      pm.expect(false).to.be.true;",
 									"    });",
-									"}",
-									"pm.environment.set('UPLOAD_RETRY', --retry);",
+									"  }",
+									"  pm.environment.set('UPLOAD_RETRY', --retry);",
 									"",
-									"pm.test('WAF policy state is not ERROR', function () {",
+									"  pm.test('WAF policy state is not ERROR', function () {",
 									"    pm.expect(resp.wafpolicyondevice.state).to.not.have.string('ERROR');",
-									"});",
+									"  });",
 									"",
-									"if (resp.wafpolicyondevice.state !== 'AVAILABLE') {",
-									"    postman.setNextRequest('wait-wafpolicy-upload');",
-									"    setTimeout(function(){}, 10000)",
+									"  if (resp.wafpolicyondevice.state !== 'AVAILABLE') {",
+									"      postman.setNextRequest('wait-wafpolicy-upload');",
+									"      setTimeout(function(){}, 10000)",
+									"  }",
 									"}",
 									"",
 									"",