Skip to content

refactor: finalize Search router and delete legacy SearchList shell #95380

Description

@mountiny

Problem

Search list rendering still relied on a legacy SearchList component with a getListItem factory and shared renderItem, even after dedicated views were introduced for most search types. Invoice and trip transaction types still routed through this monolithic shell instead of the dedicated expense views, leaving duplicate prop bundles and unused legacy code.

Solution

This PR finalizes the Search router by routing invoice and trip through existing ExpenseFlatSearchView and ExpenseGroupedSearchView, extracting shared props into commonViewProps, moving isTransactionMatchWithGroupItem to SearchUIUtils, and deleting the unused SearchList component, getListItem factory, and shared renderItem. <Search> is now a pure router over five dedicated views with preserved behavior for every search type.

PR

#95370

Issue OwnerCurrent Issue Owner: @daledah

Metadata

Metadata

Labels

InternalRequires API changes or must be handled by Expensify staffReviewingHas a PR in reviewTaskWeeklyKSv2

Type

No type

Fields

No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions