[Due for payment 2026-03-02] CVP-Missing onboarding tasks in the Concierge chat

[nlemma]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.3.19-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/folder/13176724/test-cases/41237071
Email or phone of affected tester (no customers): agexptest+cvp130226.3m@gmail.com
Issue reported by: Applause Internal Team
Bug source: Regression TC Execution
Device used: Samsung S23FE/ Android 16
App Component: Other

Action Performed:

Preconditions:
User A is a new user created on https://staging.expensify.com by selecting "Organize my own expenses". The "Get paid back from my employer" option was selected from the intent selector during the onboarding flow.
In NewDot, create a valid scan expense and submit it to a non-existent account (User B).

1. Go to User B's email inbox
2. From the email with the subject "Please pay expense", copy the link "open it in Expensify" (can be found in the footer)
3. Change the link to staging and navigate to it
4. Go to the expense details
5. Tap on Pay $X.XX > Pay with business account
6. Tap on Log into your bank account
7. Complete the Plaid flow
8. Approve the expense
9. Tap on Pay $X.XX
10. Navigate to the Concierge chat

Expected Result:

The onboarding tasks are displayed for manage my team expenses.

Actual Result:

Some onboarding tasks, like "Take a test drive", "Connect your corporate cards", and "Set up categories", are missing.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Bug7077481_1771028227086.missing_tasks.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @johncschuster

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When a new user (User B) pays an expense via "Pay with business account", a workspace is created and completePaymentOnboarding is called with the MANAGE_TEAM onboarding purpose. However, only 3 onboarding tasks appear ("Create a workspace", "Invite your team", "Add expense approvals"). Other expected MANAGE_TEAM tasks like "Take a test drive", "Connect your corporate cards", and "Set up categories" are missing.

What is the root cause of that problem?

completePaymentOnboarding calls completeOnboarding without passing selectedInterestedFeatures:

App/src/libs/actions/IOU/index.ts

Lines 11907 to 11918 in a93a316

	completeOnboarding({
	engagementChoice: onboardingPurpose,
	onboardingMessage: onboardingMessages[onboardingPurpose],
	firstName: personalDetails?.firstName,
	lastName: personalDetails?.lastName,
	adminsChatReportID,
	onboardingPolicyID,
	paymentSelected,
	wasInvited: true,
	shouldSkipTestDriveModal: true,
	companySize: introSelected?.companySize as OnboardingCompanySize,
	});

In completeOnboarding, selectedInterestedFeatures defaults to [] (empty array):

App/src/libs/actions/Report/index.ts

Line 4490 in a93a316

shouldSkipTestDriveModal,

Then in prepareOnboardingOnyxData, the task filter checks !!selectedInterestedFeatures:

App/src/libs/ReportUtils.ts

Lines 11462 to 11466 in a93a316

	if (engagementChoice === CONST.ONBOARDING_CHOICES.MANAGE_TEAM) {
	if (!!selectedInterestedFeatures && TASK_TO_FEATURE[task.type] && !selectedInterestedFeatures.includes(TASK_TO_FEATURE[task.type])) {
	return false;
	}
	}

Since !![] is true in JavaScript (arrays are truthy), the filter activates. For every task that has a mapping in TASK_TO_FEATURE (setup categories, connect corporate card, setup tags, add accounting integration):

App/src/CONST/index.ts

Lines 8538 to 8543 in a93a316

	const TASK_TO_FEATURE: Record<string, string> = {
	[CONST.ONBOARDING_TASK_TYPE.SETUP_CATEGORIES]: CONST.POLICY.MORE_FEATURES.ARE_CATEGORIES_ENABLED,
	[CONST.ONBOARDING_TASK_TYPE.ADD_ACCOUNTING_INTEGRATION]: CONST.POLICY.MORE_FEATURES.ARE_CONNECTIONS_ENABLED,
	[CONST.ONBOARDING_TASK_TYPE.CONNECT_CORPORATE_CARD]: CONST.POLICY.MORE_FEATURES.ARE_COMPANY_CARDS_ENABLED,
	[CONST.ONBOARDING_TASK_TYPE.SETUP_TAGS]: CONST.POLICY.MORE_FEATURES.ARE_TAGS_ENABLED,
	};

[].includes(anything) returns false, so !false = true, causing all feature-mapped tasks to be filtered out. Only the 3 tasks without a TASK_TO_FEATURE entry survive.

What changes do you think we should make in order to solve the problem?

Change the default value of selectedInterestedFeatures from [] to undefined in completeOnboarding:

// Before
selectedInterestedFeatures = [],

// After
selectedInterestedFeatures,

App/src/libs/actions/Report/index.ts

Line 4490 in a93a316

shouldSkipTestDriveModal,

This way:

• When completePaymentOnboarding calls completeOnboarding without passing selectedInterestedFeatures, it defaults to undefined. In the filter, !!undefined is false, so the filter is skipped and all MANAGE_TEAM tasks are included.
• When BaseOnboardingInterestedFeatures explicitly passes an empty array [] (user deselected all features), !![] is true, so the filter correctly activates and removes feature-mapped tasks.

https://github.com/Expensify/App/blob/a93

[lorretheboy]

🚨 Edited by proposal-police: This proposal was edited at 2026-02-16 10:02:17 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Missing onboarding tasks in the Concierge chat

What is the root cause of that problem?

completePaymentOnboarding here calls completeOnboarding without selectedInterestedFeatures

App/src/libs/actions/IOU/index.ts

Lines 11907 to 11918 in 329043c

	completeOnboarding({
	engagementChoice: onboardingPurpose,
	onboardingMessage: onboardingMessages[onboardingPurpose],
	firstName: personalDetails?.firstName,
	lastName: personalDetails?.lastName,
	adminsChatReportID,
	onboardingPolicyID,
	paymentSelected,
	wasInvited: true,
	shouldSkipTestDriveModal: true,
	companySize: introSelected?.companySize as OnboardingCompanySize,
	});

And the completeOnboarding defaults it to [] via selectedInterestedFeatures = []

App/src/libs/actions/Report/index.ts

Lines 4478 to 4493 in ac4c228

	async function completeOnboarding({
	engagementChoice,
	onboardingMessage,
	firstName = '',
	lastName = '',
	adminsChatReportID,
	onboardingPolicyID,
	paymentSelected,
	companySize,
	userReportedIntegration,
	wasInvited,
	selectedInterestedFeatures = [],
	shouldSkipTestDriveModal,
	isInvitedAccountant,
	onboardingPurposeSelected,
	shouldWaitForRHPVariantInitialization = false,

The prepareOnboardingOnyxData here checks !!selectedInterestedFeatures — !![] is true

App/src/libs/ReportUtils.ts

Line 11469 in b181d17

if (!!selectedInterestedFeatures && TASK_TO_FEATURE[task.type] && !selectedInterestedFeatures.includes(TASK_TO_FEATURE[task.type])) {

--> Since [].includes(anything) is always false, every task with a TASK_TO_FEATURE mapping gets filtered out (setupCategories, connectCorporateCard, setupTags, addAccountingIntegration)

What changes do you think we should make in order to solve the problem?

We should update condition (root cause) here so that an empty array should not trigger feature-based filtering. Thus, preventing the bug from happening in all places that trigger prepareOnboardingOnyxData

                if (
                    !!selectedInterestedFeatures &&
                    selectedInterestedFeatures.length > 0 &&
                    TASK_TO_FEATURE[task.type] &&
                    !selectedInterestedFeatures.includes(TASK_TO_FEATURE[task.type])
                ) {

App/src/libs/ReportUtils.ts

Line 11469 in b181d17

if (!!selectedInterestedFeatures && TASK_TO_FEATURE[task.type] && !selectedInterestedFeatures.includes(TASK_TO_FEATURE[task.type])) {

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[jjcoffee]

@nkdengineer's proposal sounds good here, I agree that we want to be able to explicitly send an empty array when a user deselects all options, so it makes sense to just change the default.

🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @cead22, see https://stackoverflow.com/c/expensify/questions/7972 for more details.