Infinite loading appears when tap back from a redirect after logging in via deeplink

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.89-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #75808
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Bug source: Exploratory - Critical User Impact
Device used: Android 13 / Xiaomi Poco F5
App Component: Other

Action Performed:

1. Logout if you’re currently logged in
2. Click link in from slack or app note: https://staging.new.expensify.com/r/hellogorgeous
3. Log in using a Google account
4. Verify the app redirects to your most recently accessed report
5. Tap the back button

Expected Result:

User should go back to the Inbox or homepage, and no infinite loading

Actual Result:

Infinite loading appears when tap back from a redirect after logging in via deep link

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @paulnjs

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[samranahm]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Infinite loading appears when tap back from a redirect after logging in via deeplink

What is the root cause of that problem?

When a user logs in via a deep link to a report that doesn't exist:

The openReport function sets isLoadingInitialReportActions: true in optimistic data and app navigates to the last accessed report with forceReplace: true and the original deeplinked report's loading state remains true

When the user taps back, they see the deeplinked report still in a loading state

What changes do you think we should make in order to solve the problem?

We should add logic to clear the isLoadingInitialReportActions flag when navigating away from a deeplink report

Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT_METADATA}${reportID}`, {
    isLoadingInitialReportActions: false,
});

here

App/src/libs/actions/Link.ts

Lines 314 to 325 in 8d19e95

	const navigateHandler = (reportParam?: OnyxEntry<Report>) => {
	// Check if the report exists in the collection
	const report = reportParam ?? reports?.[`${ONYXKEYS.COLLECTION.REPORT}${reportID}`];
	// If the report does not exist, navigate to the last accessed report or Concierge chat
	if (reportID && (!report?.reportID || report.errorFields?.notFound)) {
	const lastAccessedReportID = findLastAccessedReport(false, shouldOpenOnAdminRoom(), undefined, reportID)?.reportID;
	if (lastAccessedReportID) {
	const lastAccessedReportRoute = ROUTES.REPORT_WITH_ID.getRoute(lastAccessedReportID);
	Navigation.navigate(lastAccessedReportRoute, {forceReplace: Navigation.getTopmostReportId() === reportID});
	return;
	}

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[mountiny]

@paulnjs @aldo-expensify Is this regression from #75808 by any chance?

[melvin-bot]

@strepanier03 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[paulnjs]

@mountiny I will check this today

[strepanier03]

I am able to reproduce this. Let me know if we should assign to someone in particular if its a regression or if I should set external.

[melvin-bot]

@strepanier03 Whoops! This issue is 2 days overdue. Let's get this updated quick!