Workspace - "Can't upgrade workspace" modal cannot dismissed by clicking outside the modal

[nlemma]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.74-1
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #76094
Email or phone of affected tester (no customers): applausetester+081201kh@applause.expensifail.com
Issue reported by: Applause Internal Team
Bug source: Pull Request QA execution
Device used: Mac 26.1 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

• Log in with Expensifail account
• Acount is restricted from creating workspace (configured on OD)
• Account does not have workspace

1. Go to staging.new.expensify.com
2. Click FAB > Track distance > Manual
3. Enter amount > Next
4. On confirm page, click Rate
5. Click Upgrade.
6. Click outside "Can't upgrade workspace" modal.

Expected Result:

"Can't upgrade workspace" modal will be dismissed by clicking outside the modal.

Actual Result:

"Can't upgrade workspace" modal cannot dismissed by clicking outside the modal.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug7025116_1765297917492.8.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @Valforte

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @Valforte (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[Nodebrute]

Proposal

Please re-state the problem that we are trying to solve in this issue.

"Can't upgrade workspace" modal cannot dismissed by clicking outside the modal

What is the root cause of that problem?

We don't have any logic to handle the case when user clicks outside the modal

App/src/pages/iou/request/step/IOURequestStepUpgrade.tsx

Lines 252 to 258 in d3bf94b

	<ConfirmModal
	isVisible={isUpgradeWarningModalOpen}
	shouldShowCancelButton={false}
	onConfirm={handleConfirmUpgradeWarning}
	title={translate('workspace.upgrade.commonFeatures.upgradeWorkspaceWarning')}
	prompt={translate('workspace.upgrade.commonFeatures.upgradeWorkspaceWarningForRestrictedPolicyCreationPrompt')}
	confirmText={translate('common.buttonConfirm')}

What changes do you think we should make in order to solve the problem?

Add onBackdropPress={handleConfirmUpgradeWarning} below. This will make the setIsUpgradeWarningModalOpen(false)

App/src/pages/iou/request/step/IOURequestStepUpgrade.tsx

Lines 252 to 258 in d3bf94b

	<ConfirmModal
	isVisible={isUpgradeWarningModalOpen}
	shouldShowCancelButton={false}
	onConfirm={handleConfirmUpgradeWarning}
	title={translate('workspace.upgrade.commonFeatures.upgradeWorkspaceWarning')}
	prompt={translate('workspace.upgrade.commonFeatures.upgradeWorkspaceWarningForRestrictedPolicyCreationPrompt')}
	confirmText={translate('common.buttonConfirm')}

What alternative solutions did you explore? (Optional)

[situchan]

We can demote this as NAB. You can always dismiss modal by clicking "Got it"button.