fix review comments

Author: karthikeyanjp

.github/workflows/publish.yaml

@@ -4,6 +4,7 @@
 # IntelliJ
 /.idea
 *.iml
+/lib
 
 # Visual Studio Code
 /.vscode

.gitignore

@@ -1,19 +1,21 @@
-Contributing
+# Contributing
 
 Thanks for your interest in contributing to this project!
 
-We welcome any kind of contribution, including:
+We welcome any kind of contribution including:
 
-    Documentation
-    Examples
-    New features and feature requests
-    Bug fixes
+- Documentation
+- Examples
+- New features and feature requests
+- Bug fixes
 
-For small changes, open pull requests.
+Please open Pull Requests for small changes.
 
-For larger changes, submit an issue that outlines the following:
+For larger changes please submit an issue with additional details.
 
-    The use case that your changes are applicable to.
-    Steps to reproduce the issue(s) if applicable.
-    A detailed description of what your changes would entail.
-    Alternative solutions or approaches if applicable.
+This issue should outline the following:
+
+- The use case that your changes are applicable to.
+- Steps to reproduce the issue(s) if applicable.
+- Detailed description of what your changes would entail.
+- Alternative solutions or approaches if applicable.

CONTRIBUTING.md

@@ -1,6 +1,6 @@
 [ aws-lambda-ts-lambda-handler ]
 
-Copyright (c) [ 2023 - 2025 ] Evernorth Strategic Development, Inc.
+Copyright (c) 2025 Evernorth Strategic Development, Inc.
 
 Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.

NOTICE

@@ -4,7 +4,7 @@
 
 Minimalistic event handler & HTTP router for Serverless applications.
 
-`aws-lambda-ts-event-handler` is a lightweight and focusted Typescript library that brings elegant HTTP routing to AWS Lambda functions - without the overhead of traditional web frameworks.
+`aws-lambda-ts-event-handler` is a lightweight and focused Typescript library that brings elegant HTTP routing to AWS Lambda functions - without the overhead of traditional web frameworks.
 Designed specifically for serverless workloads on AWS, this library enables developers to define clean and type-safe API routes using Typescript decorations.
 
 **Features**
@@ -23,16 +23,16 @@ See the [package.json](./package.json) file.
 
 ## Building from Source
 
-For detailed instructions to build the project from source, please see [INSTALL](INSTALL.md) document. To add this library to your project, run
+For detailed instructions to build the project from source, please see [INSTALL](INSTALL.md) document. 
+
+## Installation
+
+To add this library to your project, run
 
 ```shell
 npm install --save @evernorth/aws-lambda-ts-event-handler
 ```
 
-## Installation
-
-Please see [INSTALL](INSTALL.md) document.
-
 ## Configuration
 
 If the software is configurable, describe it in detail, either here or in other documentation to which you link.
@@ -81,7 +81,6 @@ const helloHandler = async (
 // Register Route
 app.addRoute("GET", "/v1/hello", helloHandler as AsyncFunction);
 
-// Declare your Lambda handler
 // Declare your Lambda handler
 exports.handler = (
   _event: APIGatewayProxyEvent,
@@ -122,7 +121,7 @@ import {
   JSONData,
   Handler,
   LocalTestServer,
-} from "@cigna/aws-lambda-ts-event-handler";
+} from "@evernorth/aws-lambda-ts-event-handler";
 
 // Initialize the event handler
 const app = new ApiGatewayResolver();
@@ -191,7 +190,7 @@ adds standard CORS headers to the response
 * Request completely sent off
 < HTTP/1.1 200 OK
 < Content-Type: application/json
-< Access-Control-Allow-Origin: *
+< Access-Control-Allow-Origin: * # For security, it is recommended to specify specific allow-listed domains.
 < Access-Control-Allow-Headers: Authorization,Content-Type,X-Amz-Date,X-Api-Key,X-Amz-Security-Token
 < content-length: 25
 < Date: Mon, 10 Mar 2025 20:47:29 GMT
@@ -202,17 +201,11 @@ adds standard CORS headers to the response
 {"message":"Hello World"}%
 ```
 
-## Known issues
-
-Document any known significant shortcomings with the software.
-
-## Getting help
-
-If you have questions, concerns, bug reports, etc., file an issue in this repository's Issue Tracker.
+---
 
-## Getting involved
+## Support
 
-See the [CONTRIBUTING](CONTRIBUTING.md) file for info on how to get involved.
+If you have questions, concerns, bug reports, etc. See [CONTRIBUTING](CONTRIBUTING.md).
 
 ## License
 

README.md

@@ -1,6 +1,6 @@
 module.exports = {
   displayName: {
-    name: 'Digital Typescript Library: EVENT-HANDLER',
+    name: 'Evernorth Typescript Library: aws-lambda-ts-event-handler',
     color: 'yellow',
   },
   'runner': 'groups',

jest.config.js

@@ -1,5 +1,5 @@
 {
-  "name": "@cigna/aws-lambda-ts-event-handler",
+  "name": "@evernorth/aws-lambda-ts-event-handler",
   "version": "0.0.1",
   "description": "Minimalistic event handler & http router for Serverless applications",
   "main": "./lib/index.js",

package.json

@@ -171,8 +171,18 @@ class LocalTestServer {
       res.write(body);
     } catch (error) {
       console.error('Error constructing response:', error);
+
+      // IETF RFC 9457 compliant error response
+      const errorResponse = {
+        type: 'about:blank',
+        title: 'An unexpected error occurred while constructing the response.',
+        status: 500,
+        detail: `Error constructing response: ${error}`,
+      };
+
       res.statusCode = 500;
-      res.write('Internal Server Error');
+      res.setHeader('content-type', 'application/problem+json');
+      res.write(JSON.stringify(errorResponse));
     } finally {
       res.end();
     }
@@ -194,8 +204,16 @@ class LocalTestServer {
           );
         } catch (error) {
           console.error('Error handling request:', error);
+
+          // IETF RFC 9457 compliant error response
+          const errorResponse = {
+            type: 'about:blank',
+            title: 'An unexpected error occurred while handling the request.',
+            status: 500,
+          detail: `Error handling requestg/: ${error}`,
+          };
           res.statusCode = 500;
-          res.write('Internal Server Error');
+          res.write(JSON.stringify(errorResponse));
           res.end();
         }
       },

src/ApiGateway.ts src/ApiGatewayEventRouter.tssrc/ApiGateway.ts renamed to src/ApiGatewayEventRouter.ts

@@ -1,4 +1,4 @@
-export * from './ApiGateway';
+export * from './ApiGatewayEventRouter';
 export * from './helpers';
 export * from './middleware';
 export * from './types';