From 79e7fb6acd127ca4fcca6db8caa0a3a01071e1f4 Mon Sep 17 00:00:00 2001 From: "Spark (Spark Lab)" Date: Thu, 5 Mar 2026 08:14:00 +0800 Subject: [PATCH] fix: replace == None/!= True with is None/is not True (Python anti-patterns) - Fixed 3 instances of '!= True' to 'is not True' in repository files - Fixed 3 instances of '== None' to 'is None' in mem_memorize.py Using == or != with boolean/None values is a Python anti-pattern. The correct way is to use 'is' or 'is not' for identity comparisons. --- src/biz_layer/mem_memorize.py | 6 +++--- .../persistence/repository/core_memory_raw_repository.py | 2 +- .../persistence/repository/group_profile_raw_repository.py | 2 +- .../repository/group_user_profile_memory_raw_repository.py | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/biz_layer/mem_memorize.py b/src/biz_layer/mem_memorize.py index e951a13c..89b4902a 100644 --- a/src/biz_layer/mem_memorize.py +++ b/src/biz_layer/mem_memorize.py @@ -1290,7 +1290,7 @@ async def memorize(request: MemorizeRequest) -> int: # ===== Preprocess and get historical data ===== if request.raw_data_type == RawDataType.CONVERSATION: request = await preprocess_conv_request(request, current_time) - if request == None: + if request is None: logger.warning(f"[mem_memorize] preprocess_conv_request returned None") return 0 @@ -1326,7 +1326,7 @@ async def memorize(request: MemorizeRequest) -> int: ) logger.debug(f"[mem_memorize] Extracting MemCell took: {time.perf_counter() - memcell_start} seconds") - if memcell_result == None: + if memcell_result is None: logger.warning(f"[mem_memorize] Skipped extracting MemCell") return 0 @@ -1345,7 +1345,7 @@ async def memorize(request: MemorizeRequest) -> int: ) logger.info("=" * 80) - if memcell == None: + if memcell is None: # No boundary detected, confirm current messages to accumulation (sync_status: -1 -> 0) await conversation_data_repo.save_conversation_data( request.new_raw_data_list, request.group_id diff --git a/src/infra_layer/adapters/out/persistence/repository/core_memory_raw_repository.py b/src/infra_layer/adapters/out/persistence/repository/core_memory_raw_repository.py index 8c532d48..3998ea0d 100644 --- a/src/infra_layer/adapters/out/persistence/repository/core_memory_raw_repository.py +++ b/src/infra_layer/adapters/out/persistence/repository/core_memory_raw_repository.py @@ -56,7 +56,7 @@ async def ensure_latest( ).update_many({"$set": {"is_latest": False}}) # Update the latest version's is_latest to True - if latest_version.is_latest != True: + if latest_version.is_latest is not True: latest_version.is_latest = True await latest_version.save(session=session) logger.debug( diff --git a/src/infra_layer/adapters/out/persistence/repository/group_profile_raw_repository.py b/src/infra_layer/adapters/out/persistence/repository/group_profile_raw_repository.py index 0935bb94..4d16a01c 100644 --- a/src/infra_layer/adapters/out/persistence/repository/group_profile_raw_repository.py +++ b/src/infra_layer/adapters/out/persistence/repository/group_profile_raw_repository.py @@ -59,7 +59,7 @@ async def ensure_latest( ).update_many({"$set": {"is_latest": False}}) # Update the latest version's is_latest to True - if latest_version.is_latest != True: + if latest_version.is_latest is not True: latest_version.is_latest = True await latest_version.save(session=session) logger.debug( diff --git a/src/infra_layer/adapters/out/persistence/repository/group_user_profile_memory_raw_repository.py b/src/infra_layer/adapters/out/persistence/repository/group_user_profile_memory_raw_repository.py index f0bfbbdf..094a4165 100644 --- a/src/infra_layer/adapters/out/persistence/repository/group_user_profile_memory_raw_repository.py +++ b/src/infra_layer/adapters/out/persistence/repository/group_user_profile_memory_raw_repository.py @@ -83,7 +83,7 @@ async def ensure_latest( ).update_many({"$set": {"is_latest": False}}) # Update the latest version's is_latest to True - if latest_version.is_latest != True: + if latest_version.is_latest is not True: latest_version.is_latest = True await latest_version.save(session=session) logger.debug(