-
Notifications
You must be signed in to change notification settings - Fork 1
New Building Explorer widget #101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v.next
Are you sure you want to change the base?
Conversation
- Added toolkit widget to example app - Refactored sub widgets to separate files - Still working building_explorer widget to act properly example app widgets
- Moved all floor logic into FloorLevelSelector - Added example app to main - Added copyright to files
- Added "Disciplines" to title of sublayer selector
- Added close button to bottom sheet popup - Changed label text style and words
- Added padding to the row to align better with sublayer listings below.
|
I'm thinking there's a lot of design/aesthetic choices that could be made. I'm not sure how much we want to get into on the first cut, or how much of the JavaScript API version we want to replicate. But some thoughts ... I think we should get rid of the ":" in the labels, and "Select Level:" should just be "Level". I'd almost say we don't even need the "Disciplines & Categories" label at all (unless we also bring in the "Construction phase" picker like in the JavaScript version). I think the checkboxes should be on the left of the titles, and the sublayer checkboxes should be indented. That would provide a clear visual hierarchy. Visually the level picker seems rather obscure, off in the corner. Without going overboard, maybe we can bring in the up/down buttons from the JavaScript version, and maybe present it like this: (so the level dropdown is on the left and with down/up buttons on the right) |
- Refactored BuildingSublayerSelector into smaller widgets - changed BuildingExplorer into a StatelessWidget - Added safety in comparator for String values that should represent integers
- Fixed issue where currently selected floor was lost between instances of widget - Replaced hard-coded strings with final String members.
|
@PaulAllanSturm Functionality wise, I have acted on your PR comments. I've not yet acted on the styling suggestions from your last comment. |
A new Toolbox widget has been created to explore the floors and sublayers of a BuildingSceneLayer.
The widget does the following:
An example has been added to the Example app in the toolbox. The example wraps the Building Explorer widget in a modal bottom sheet.