Define XLA.DEFAULT_DEVICE to set default device ID
#1866
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giordano
force-pushed
the
mg/reactant-default-var
branch
from
386197e to
2c169ef
Compare
giordano
commented
Nov 13, 2025
giordano
force-pushed
the
mg/reactant-default-var
branch
from
444cf6b to
3f9be82
Compare
Member
Author
|
To demonstrate this works, on top of #1860 I get julia> using Reactant
julia> Reactant.XLA.default_device()
Reactant.XLA.PJRT.Device(Ptr{Nothing}(0x0000000042369bd0), "TT:0 Wormhole_b0")
julia> ENV["REACTANT_DEFAULT_DEVICE"] = "31"
"31"
julia> Reactant.XLA.default_device()
Reactant.XLA.PJRT.Device(Ptr{Nothing}(0x000000004d618490), "TT:31 Wormhole_b0") |
wsmoses
reviewed
Nov 13, 2025
giordano
changed the title
REACTANT_DEFAULT_DEVICE to set default device ID with env varXLA.DEFAULT_DEVICE to set default device ID
wsmoses
reviewed
Nov 13, 2025
| 0-based index of default device to use, by default 0 (first available device). | ||
| """ | ||
| const DEFAULT_DEVICE = Ref{Int}(0) |
Member
There was a problem hiding this comment.
if we're not doing an env var we can leave this as 1-indexed. [reason for env var is cuz cuda_visible_devices and friends are 0-indexed]
Member
There was a problem hiding this comment.
also if you want we can still do DEFAULT_DEVICE = Ref{Int}(something(tryparse, ...)
giordano
force-pushed
the
mg/reactant-default-var
branch
from
af67d52 to
3bb3be9
Compare
giordano
force-pushed
the
mg/reactant-default-var
branch
from
b840fb3 to
8ea159a
Compare
Member
Author
|
Just confirming this still works: julia> using Reactant
julia> Reactant.XLA.default_device()
Reactant.XLA.PJRT.Device(Ptr{Nothing} @0x00000000321be750, "TT:0 Wormhole_b0")
julia> Reactant.XLA.DEFAULT_DEVICE[] = 16
16
julia> Reactant.XLA.default_device()
Reactant.XLA.PJRT.Device(Ptr{Nothing} @0x0000000032833c10, "TT:16 Wormhole_b0")
julia> Reactant.XLA.DEFAULT_DEVICE[] = 31
31
julia> Reactant.XLA.default_device()
Reactant.XLA.PJRT.Device(Ptr{Nothing} @0x0000000032834660, "TT:31 Wormhole_b0")Yay! |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1866 +/- ##
==========================================
+ Coverage 68.16% 69.92% +1.76%
==========================================
Files 109 122 +13
Lines 11779 13233 +1454
==========================================
+ Hits 8029 9253 +1224
- Misses 3750 3980 +230 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.