Upgrade to gulp v4

Allow running on Node.js 10.x
Also upgrade other dev dependencies

Author: bdukes

gulpfile.js

@@ -16,38 +16,42 @@ const {
 
 const libraries = getLibraries();
 
-libraries.forEach(library =>
-	gulp.task(library.path, () => {
-		const mainFileStream = gulp.src(library.manifest.files);
-		const resourceZipStream = gulp
-			.src(library.manifest.resources || [])
-			.pipe(zip('Resources.zip'));
+function makePackageTask(library) {
+	const packageFn = function() {
+		const resourceZipStream =
+			library.manifest.resources && library.manifest.resources.length
+				? gulp
+						.src(library.manifest.resources)
+						.pipe(zip('Resources.zip'))
+				: null;
 
 		const templateData = {
 			version: library.version,
 			versionFolder: formatVersionFolder(library.version),
 		};
-		const packageFilesStream = gulp
+		const filesStream = gulp
 			.src(['LICENSE.htm', 'CHANGES.htm', '*.dnn'], {
 				cwd: library.path,
 			})
-			.pipe(ejs(templateData, { delimiter: '~' }));
+			.pipe(ejs(templateData, { delimiter: '~' }))
+			.pipe(gulp.src(library.manifest.files));
 
-		return mergeStream(
-			mainFileStream,
-			resourceZipStream,
-			packageFilesStream
-		)
+		const packageStream = resourceZipStream
+			? mergeStream(filesStream, resourceZipStream)
+			: filesStream;
+
+		return packageStream
 			.pipe(zip(`${library.name}_${library.version}.zip`))
 			.pipe(gulp.dest('./_InstallPackages/'));
-	})
-);
+	};
 
-const libraryTaskNames = libraries.map(library => library.path);
+	packageFn.displayName = `Generate ${library.name}_${library.version}.zip`;
+	return packageFn;
+}
 
-gulp.task('default', libraryTaskNames);
+const defaultTask = gulp.parallel(...libraries.map(makePackageTask));
 
-gulp.task('outdated', () => {
+function outdated() {
 	const allUpgradesPromises = libraries.map(library =>
 		getUpgradeVersions(library).then(upgrades =>
 			Object.assign(library, { upgrades })
@@ -70,10 +74,10 @@ gulp.task('outdated', () => {
 		log.info(`
 ${formatPackageUpgrades(validUpgrades)}`);
 	});
-});
+}
 
-['patch', 'minor', 'major'].forEach(upgradeType =>
-	gulp.task(`upgrade-${upgradeType}`, () => {
+function makeUpgradeTask(upgradeType) {
+	const upgradeFn = function() {
 		const allUpgradesPromises = libraries.map(library =>
 			getUpgradeVersions(library).then(upgrades =>
 				Object.assign(library, { upgrades })
@@ -152,5 +156,23 @@ ${formatPackageUpgrades(validUpgrades)}`);
 					)
 				);
 		});
-	})
-);
+	};
+
+	upgradeFn.displayName = `Apply ${upgradeType} upgrades`;
+
+	return upgradeFn;
+}
+
+const upgradePatch = makeUpgradeTask('patch');
+const upgradeMinor = makeUpgradeTask('minor');
+const upgradeMajor = makeUpgradeTask('major');
+const upgrade = gulp.series(upgradePatch, upgradeMinor, upgradeMajor);
+
+module.exports = {
+	outdated,
+	upgradePatch,
+	upgradeMinor,
+	upgradeMajor,
+	upgrade,
+	default: defaultTask,
+};

package.json

@@ -8,7 +8,7 @@
   "scripts": {
     "package": "gulp",
     "outdated": "gulp outdated",
-    "upgrade": "gulp upgrade-patch && gulp upgrade-minor && gulp upgrade-major",
+    "upgrade": "gulp upgradePatch && gulp upgradeMinor && gulp upgradeMajor",
     "new": "yo ./_new"
   },
   "dependencies": {
@@ -80,20 +80,20 @@
     "zeroclipboard": "2.3.0"
   },
   "devDependencies": {
-    "chalk": "^2.4.1",
+    "chalk": "^2.4.2",
     "cliui": "4.1.0",
     "cross-spawn": "6.0.5",
-    "fancy-log": "1.3.2",
-    "glob": "^7.1.2",
-    "globby": "^8.0.1",
-    "gulp": "^3.9.1",
-    "gulp-ejs": "^3.1.3",
-    "gulp-zip": "^4.1.0",
-    "lodash": "4.17.10",
+    "fancy-log": "1.3.3",
+    "glob": "^7.1.3",
+    "globby": "^9.0.0",
+    "gulp": "^4.0.0",
+    "gulp-ejs": "^3.3.0",
+    "gulp-zip": "^4.2.0",
+    "lodash": "4.17.11",
     "merge-stream": "^1.0.1",
-    "package-json": "^4.0.1",
-    "semver": "5.5.0",
-    "yeoman-generator": "^2.0.5",
-    "yo": "^2.0.2"
+    "package-json": "^6.0.0",
+    "semver": "5.6.0",
+    "yeoman-generator": "^3.2.0",
+    "yo": "^2.0.5"
   }
 }