[ 命名建議 ] LeetCode 503. Next Greater Element II

[LPenny-github]

LeetCode:
https://leetcode.com/problems/next-greater-element-ii/

線上教材:
https://leetcode.com/problems/next-greater-element-ii/discuss/98270/JavaC%2B%2BPython-Loop-Twice

---

再麻煩 @twy30 給予命名建議 orz 感激不盡

using System;
using System.Collections.Generic;

public class Solution
{
    public int[] NextGreaterElements(int[] nums)
    {
        int[] inputNumbers = nums;
        Stack<int> nextGreaterNumberStack = new Stack<int>();
        int[] output = new int[inputNumbers.Length];
        Array.Fill(output, -1);

        for (int i = 0; i < inputNumbers.Length * 2 ; ++i)
        {
            int currentIndex = i % inputNumbers.Length;
                
            while (nextGreaterNumberStack.Count > 0 && 
                   inputNumbers[nextGreaterNumberStack.Peek()] < inputNumbers[currentIndex])
            {
                output[nextGreaterNumberStack.Pop()] = inputNumbers[currentIndex];
            }

            nextGreaterNumberStack.Push(currentIndex);
        }
        return output;
    }
}

[twy30]

@LPenny-github

你好 😊

---

            int currentIndex = i % inputNumbers.Length;

我不覺得 currentIndex 有什麼問題，但因為其使用情景很簡單(simple)：

• 「陣列索引變數」是極常見的觀念
• 此變數的生命週期是在連續的 4~5 行程式碼區塊內
• 此變數沒有參與其它的運算，就單純作為「陣列索引」用途

若改成以下名字，也是可以的：

• inputNumbersIndex
• index
• j

---

其它的變數名稱我覺得都 ok 👌

[LPenny-github]

@twy30 十分感激 orz