Fixed bug related to InvestmentData check for Storage (#79)

* The bug is only present when the Storage fieldnames are changed
* In the EMX repositories, this only affected HydroReservoir

Author: JulStraus

NEWS.md

@@ -1,8 +1,14 @@
 # Release notes
 
+## Version 0.8.6 (2025-11-26)
+
+### Bugfixes
+
+* Fix a bug in which field names for the capacities of a `Storage` node resulted in error message for the investment data checks.
+
 ## Version 0.8.5 (2025-10-23)
 
-## Bugfixes
+### Bugfixes
 
 * Fix a bug in which field names for the capacities of a `Storage` node resulted in unconstrained capacities.
 

Project.toml

@@ -1,7 +1,7 @@
 name = "EnergyModelsBase"
 uuid = "5d7e687e-f956-46f3-9045-6f5a5fd49f50"
 authors = ["Lars Hellemo <Lars.Hellemo@sintef.no>, Julian Straus <Julian.Straus@sintef.no>"]
-version = "0.8.5"
+version = "0.8.6"
 
 [deps]
 JuMP = "4076af6c-e467-56ae-b986-b466b2749572"

ext/EMIExt/checks.jl

@@ -53,14 +53,16 @@ function EMB.check_node_data(
         return
     end
 
-    for cap_fields ∈ fieldnames(typeof(data))
-        sub_data = getfield(data, cap_fields)
+    cap_map = Dict(:charge => charge, :level => level, :discharge => discharge)
+
+    for (cap, cap_fun) ∈ cap_map
+        sub_data = getfield(data, cap)
         isnothing(sub_data) && continue
         check_inv_data(
             sub_data,
-            EMB.capacity(getproperty(n, cap_fields)),
+            EMB.capacity(cap_fun(n)),
             𝒯,
-            " of field `" * String(cap_fields) * "`",
+            " of field `" * String(cap) * "`",
             check_timeprofiles,
         )
     end