build not working because of sdl2 bug

[papaj-na-wrotkach]

I cloned the repo and run:

$ mkdir build && cd build
$ cmake .. -DCMAKE_CXX_COMPILER=clang++ && cmake --build .

Instead of a working build I got:

[...]
/home/user/JoyShockMapper/build/_deps/sdl2-src/src/audio/pipewire/SDL_pipewire.c: In function ‘node_event_info’:
/home/user/JoyShockMapper/build/_deps/sdl2-src/src/audio/pipewire/SDL_pipewire.c:593:37: error: passing argument 1 of ‘pw_node_enum_params’ from incompatible pointer type [-Wincompatible-pointer-types]
  593 |             pw_node_enum_params(node->proxy, 0, info->params[i].id, 0, 0, NULL);
      |                                 ~~~~^~~~~~~
      |                                     |
      |                                     struct pw_proxy *
In file included from /usr/include/pipewire-0.3/pipewire/pipewire.h:30,
                 from /home/user/JoyShockMapper/build/_deps/sdl2-src/src/audio/pipewire/SDL_pipewire.h:28,
                 from /home/user/JoyShockMapper/build/_deps/sdl2-src/src/audio/pipewire/SDL_pipewire.c:29:
/usr/include/pipewire-0.3/pipewire/node.h:208:58: note: expected ‘struct pw_node *’ but argument is of type ‘struct pw_proxy *’
  208 | PW_API_NODE_IMPL int pw_node_enum_params(struct pw_node *object,
      |                                          ~~~~~~~~~~~~~~~~^~~~~~
make[2]: *** [_deps/sdl2-build/CMakeFiles/SDL2.dir/build.make:2165: _deps/sdl2-build/CMakeFiles/SDL2.dir/src/audio/pipewire/SDL_pipewire.c.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:265: _deps/sdl2-build/CMakeFiles/SDL2.dir/all] Error 2
make: *** [Makefile:136: all] Error 2

I believe this is because of a bug libsdl-org/SDL#12224 fixed in libsdl-org/SDL@6be87ce and libsdl-org/SDL@d35bef6. Can you use SDL which contains one of those commits?

[mdbott]

Hi,
You could try applying my pull request
as I have updated this sdl2 include here to work correctly.

[papaj-na-wrotkach]

Will try tomorrow.

[papaj-na-wrotkach]

It builds successfully with some warnings.

$ cmake .. -DCMAKE_CXX_COMPILER=clang++ && cmake --build .
-- JSM version is v3.6.1
-- CPM: adding package SDL2@0 (9e079fe9c7931738ed63d257b1d7fb8a07b66824)
CMake Warning (dev) at /usr/share/cmake/Modules/FetchContent.cmake:1953 (message):
  Calling FetchContent_Populate(SDL2) is deprecated, call
  FetchContent_MakeAvailable(SDL2) instead.  Policy CMP0169 can be set to OLD
  to allow FetchContent_Populate(SDL2) to be called directly for now, but the
  ability to call it with declared details will be removed completely in a
  future version.
Call Stack (most recent call first):
  cmake/CPM.cmake:454 (FetchContent_Populate)
  cmake/CPM.cmake:483 (FetchContent_MakeAvailable)
  cmake/CPM.cmake:345 (cpm_fetch_package)
  JoyShockMapper/CMakeLists.txt:174 (CPMAddPackage)
This warning is for project developers.  Use -Wno-dev to suppress it.

[…]

CMake Deprecation Warning at build/_deps/sdl2-src/CMakeLists.txt:3288 (cmake_minimum_required):
  Compatibility with CMake < 3.10 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax
  to tell CMake that the project requires at least <min> but has been updated
  to work with policies introduced by <max> or earlier.

[…]

-- CPM: adding package magic_enum@0 (47e34ada93e0bf70dcea551636755cd66d893768)
CMake Warning (dev) at /usr/share/cmake/Modules/FetchContent.cmake:1953 (message):
  Calling FetchContent_Populate(magic_enum) is deprecated, call
  FetchContent_MakeAvailable(magic_enum) instead.  Policy CMP0169 can be set
  to OLD to allow FetchContent_Populate(magic_enum) to be called directly for
  now, but the ability to call it with declared details will be removed
  completely in a future version.
Call Stack (most recent call first):
  cmake/CPM.cmake:454 (FetchContent_Populate)
  cmake/CPM.cmake:483 (FetchContent_MakeAvailable)
  cmake/CPM.cmake:345 (cpm_fetch_package)
  JoyShockMapper/CMakeLists.txt:217 (CPMAddPackage)
This warning is for project developers.  Use -Wno-dev to suppress it.

CMake Deprecation Warning at build/_deps/magic_enum-src/CMakeLists.txt:1 (cmake_minimum_required):
  Compatibility with CMake < 3.10 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax
  to tell CMake that the project requires at least <min> but has been updated
  to work with policies introduced by <max> or earlier.


-- CPM: adding package pocket_fsm@0 (e447ec24c7a547bd1fbe8d964baa866a9cf146c8)
CMake Warning (dev) at /usr/share/cmake/Modules/FetchContent.cmake:1953 (message):
  Calling FetchContent_Populate(pocket_fsm) is deprecated, call
  FetchContent_MakeAvailable(pocket_fsm) instead.  Policy CMP0169 can be set
  to OLD to allow FetchContent_Populate(pocket_fsm) to be called directly for
  now, but the ability to call it with declared details will be removed
  completely in a future version.
Call Stack (most recent call first):
  cmake/CPM.cmake:454 (FetchContent_Populate)
  cmake/CPM.cmake:483 (FetchContent_MakeAvailable)
  cmake/CPM.cmake:345 (cpm_fetch_package)
  JoyShockMapper/CMakeLists.txt:230 (CPMAddPackage)
This warning is for project developers.  Use -Wno-dev to suppress it.

CMake Deprecation Warning at build/_deps/pocket_fsm-src/CMakeLists.txt:1 (cmake_minimum_required):
  Compatibility with CMake < 3.10 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax
  to tell CMake that the project requires at least <min> but has been updated
  to work with policies introduced by <max> or earlier.


-- CPM: adding package GamepadMotionHelpers@0 (39b578aacf34c3a1c584d8f7f194adc776f88055)
CMake Warning (dev) at /usr/share/cmake/Modules/FetchContent.cmake:1953 (message):
  Calling FetchContent_Populate(GamepadMotionHelpers) is deprecated, call
  FetchContent_MakeAvailable(GamepadMotionHelpers) instead.  Policy CMP0169
  can be set to OLD to allow FetchContent_Populate(GamepadMotionHelpers) to
  be called directly for now, but the ability to call it with declared
  details will be removed completely in a future version.
Call Stack (most recent call first):
  cmake/CPM.cmake:454 (FetchContent_Populate)
  cmake/CPM.cmake:483 (FetchContent_MakeAvailable)
  cmake/CPM.cmake:345 (cpm_fetch_package)
  JoyShockMapper/CMakeLists.txt:243 (CPMAddPackage)
This warning is for project developers.  Use -Wno-dev to suppress it.

CMake Deprecation Warning at build/_deps/gamepadmotionhelpers-src/CMakeLists.txt:1 (cmake_minimum_required):
  Compatibility with CMake < 3.10 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax
  to tell CMake that the project requires at least <min> but has been updated
  to work with policies introduced by <max> or earlier.

[…]

And 48 compilation warnings.

Also, it exits in a weird way when I close it from system tray (the icon has no image).

$ ./JoyShockMapper
Welcome to JoyShockMapper version v3.6.1!
[FIFO] Opened FIFO for reading (fd=12)
[FIFO] Dummy writer opened (fd=13)
AUTOLOAD is available. Files in /home/lolicon/.config/JoyShockMapper/AutoLoad/ folder will get loaded automatically when a matching application is in focus.
0 devices connected
Resetting all mappings to defaults
There is no OnReset.txt file to load.
There is no OnStartup.txt file to load.
terminate called without an active exception
fish: Job 1, './JoyShockMapper' terminated by signal SIGABRT (Abort)