Always reset confirmation slider after onConfirm settles

Move reset() from the catch block into finally so the SafeSlider
returns to its idle state on both success and error paths.  Previously
a successful transfer with no deposit instructions left the slider
spinning indefinitely.

Author: j0ntz

CHANGELOG.md

@@ -2,6 +2,8 @@
 
 ## Unreleased (develop)
 
+- fixed: Infinite buy transfer payload and confirmation error handling
+
 ## 4.46.0 (staging)
 
 - added: Xgram swap exchange plugin support

src/components/scenes/RampConfirmationScene.tsx

@@ -48,10 +48,10 @@ export const RampConfirmationScene: React.FC<Props> = props => {
     setIsConfirming(true)
     try {
       await onConfirm()
-    } catch (err) {
+    } catch (err: unknown) {
       setError(err)
-      reset() // Reset the slider on error
     } finally {
+      reset()
       setIsConfirming(false)
     }
   })

src/plugins/ramps/infinite/workflows/confirmationWorkflow.ts

@@ -81,21 +81,25 @@ export const confirmationWorkflow = async (
           const transfer = await infiniteApi.createTransfer(transferParams)
 
           const instructions = transfer.sourceDepositInstructions
-          if (instructions?.bankName != null && instructions.amount != null) {
-            navigationFlow.navigate('rampBankRoutingDetails', {
-              bank: {
-                name: instructions.bankName,
-                accountNumber: instructions.bankAccountNumber ?? '',
-                routingNumber: instructions.bankRoutingNumber ?? ''
-              },
-              fiatCurrencyCode: cleanFiatCode,
-              fiatAmount: instructions.amount.toString(),
-              onDone: () => {
-                navigationFlow.goBack()
-              }
-            })
+          if (instructions?.bankName == null || instructions.amount == null) {
+            throw new Error(
+              `Transfer ${transfer.id} created but deposit instructions are missing`
+            )
           }
 
+          navigationFlow.navigate('rampBankRoutingDetails', {
+            bank: {
+              name: instructions.bankName,
+              accountNumber: instructions.bankAccountNumber ?? '',
+              routingNumber: instructions.bankRoutingNumber ?? ''
+            },
+            fiatCurrencyCode: cleanFiatCode,
+            fiatAmount: instructions.amount.toString(),
+            onDone: () => {
+              navigationFlow.goBack()
+            }
+          })
+
           resolve({ confirmed: true, transfer })
           return
         }