Bug fixed in pull request - updated frame definitions in trajectory class.

Author: ryanketzner

eosimutils/trajectory.py

@@ -38,7 +38,7 @@ def convert_frame(positions: np.ndarray, velocities: np.ndarray, times: np.ndarr
 
     if from_frame.to_string() == "ITRF":
         from_string = "J2000"
-    elif from_frame.to_string() == "GCRF":
+    elif from_frame.to_string() == "ICRF_EC":
         from_string = "ITRF93"
     else:
         raise NotImplementedError(
@@ -47,7 +47,7 @@ def convert_frame(positions: np.ndarray, velocities: np.ndarray, times: np.ndarr
 
     if to_frame.to_string() == "ITRF":
         to_string = "J2000"
-    elif to_frame.to_string() == "GCRF":
+    elif to_frame.to_string() == "ICRF_EC":
         to_string = "ITRF93"
     else:
         raise NotImplementedError(f"Conversion from {from_frame} to {to_frame} is not implemented.")

examples/trajectory_example.py

@@ -35,7 +35,7 @@
 position1[missing_start:missing_end, :] = np.nan
 velocity1[missing_start:missing_end, :] = np.nan
 
-traj1 = Trajectory(abs_dates, [position1, velocity1], ReferenceFrame.GCRF)
+traj1 = Trajectory(abs_dates, [position1, velocity1], ReferenceFrame.ICRF_EC)
 traj1_itrf = traj1.to_frame(ReferenceFrame.ITRF)  # Convert to ITRF frame.
 
 # Orbit 2: Nearly identical orbit with a small increase in radius.
@@ -50,7 +50,7 @@
 
 position2 = np.column_stack((x2, y2, z2))
 velocity2 = np.column_stack((vx2, vy2, vz2))
-traj2 = Trajectory(abs_dates, [position2, velocity2], ReferenceFrame.GCRF)
+traj2 = Trajectory(abs_dates, [position2, velocity2], ReferenceFrame.ICRF_EC)
 
 # Compute the difference between the two trajectories
 traj_diff = traj1 - traj2

tests/test_trajectory.py

@@ -14,7 +14,7 @@ def setUp(self):
         self.time = AbsoluteDates(np.array([0, 1, 2]))
         self.positions = np.array([[0, 0, 0], [1, 1, 1], [2, 2, 2]])
         self.velocities = np.array([[0, 0, 0], [1, 1, 1], [2, 2, 2]])
-        self.frame = ReferenceFrame("GCRF")
+        self.frame = ReferenceFrame("ICRF_EC")
         self.trajectory = Trajectory(self.time, [self.positions, self.velocities], self.frame)
 
     def test_resample(self):