Skip to content

[Bug] /qs benefit deletes gold #2064

@bfymc

Description

@bfymc

Describe the bug

The /qs benefit command allows a shop owner to divide benefits (gold) between the shop owner and other players. Instead of granting benefits/gold to players, it deletes gold under certain circumstances.

To Reproduce

  1. Create a shop
  2. /qs size 64
  3. /qs price 1
  4. /qs benefit add <player A> 50%
  5. /qs benefit add <player B> 50%
  6. Buy 1g worth of items from the shop
  7. The gold gets deleted

Expected behavior

I would expect for the gold to be given to either player A or player B instead of getting deleted. Preferably, 1g would go to player A, then 1g would go to player B and so on.

The system works when /qs price is set to 2, since 2 is evenly divisible between player A and B.

Screenshots

No response

Additional context

Note: I understand that the gold is probably getting deleted because 1g is indivisible, but I would like to see a fix such that the gold is not deleted under any circumstances.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions