Overview
Currently, in base_bn254_extra_checks and decider_circuit_checks the public inputs are passed in as a vector of Variables. This makes the usage of said Variables rather delicate inside these two functions.
Tasks
Create a struct or structs to deal with these inputs and change the function to take in a struct instead of a vector.
Optional
No optional element but there will be corresponding nightfall_4_PV changes to make as well.
Definition of done
When these two functions take in a struct instead of a vector of Variables.
Links
No links.
Overview
Currently, in
base_bn254_extra_checksanddecider_circuit_checksthe public inputs are passed in as a vector ofVariables. This makes the usage of saidVariables rather delicate inside these two functions.Tasks
Create a
structorstructs to deal with these inputs and change the function to take in astructinstead of a vector.Optional
No optional element but there will be corresponding
nightfall_4_PVchanges to make as well.Definition of done
When these two functions take in a
structinstead of a vector ofVariables.Links
No links.