endpoint for getting file list done

Author: unkcpz

src/client.rs

@@ -2,11 +2,18 @@ use req_packager::grpc::{dataset_service_client::DatasetServiceClient, BrowseDat
 
 #[tokio::main]
 async fn main() -> Result<(), Box<dyn std::error::Error>> {
+    // TODO: 
+    // - client list all the files in a dataset
+    // - client select some files and ask "what vre should I use"?
+    // - with files and vre, create a ro-crate that contains all information inside (with
+    // information of which file is in which vre input slots).
+    // - client get the realtime status update from VRE and get a callback link send back when it
+    // is ready.
     let mut client = DatasetServiceClient::connect("http://[::1]:50051").await?;
 
     // made up repo url and dataset id, should be mocked for test
-    let url_datarepo = "http://onedata.com".to_string();
-    let id_dataset = "xxx-pid".to_string();
+    let url_datarepo = "https://example.com/datasets".to_string();
+    let id_dataset = "1".to_string();
     let request = tonic::Request::new(BrowseDatasetRequest {
         url_datarepo,
         id_dataset,

src/lib.rs

@@ -58,6 +58,8 @@ struct Dataset {
     files: Vec<FileEntry>,
 }
 
+// TODO: rename to DataRepositoryProxy??
+// This play the role to relay the API calls to source data repository through filemetrix service.
 pub struct DataRepoRelayer {
     // TODO: source of tool-registry, mocked by a JSON, in production can be just tool-registry
     // API call address.

src/server.rs

@@ -21,7 +21,7 @@ use url::Url;
 
 use req_packager::VirtualResearchEnv;
 
-#[derive(Clone)]
+#[derive(Clone, Debug)]
 struct Dataset {
     // XXX: I don't want to couple the grpc logic with business logic, so I need real type for both
     // datasetinfo and fileentry.
@@ -56,6 +56,7 @@ impl FilemetrixClient for MockFilemetrixClient {
         url_datarepo: &str,
         id: &str,
     ) -> anyhow::Result<grpc::DatasetInfo> {
+        // XXX: very fragile to use url+id, should be a PID or other primary key in DB.
         match self
             .datasets
             .get(&(url_datarepo.to_string(), id.to_string()))
@@ -169,7 +170,7 @@ impl DispatcherClient for MockDispatcherClient {
     }
 }
 
-#[derive(Serialize, Deserialize, Clone)]
+#[derive(Serialize, Deserialize, Clone, Debug)]
 struct DatasetInfo {
     url: String,
     id: String,
@@ -204,7 +205,7 @@ impl From<DatasetInfo> for grpc::DatasetInfo {
     }
 }
 
-#[derive(Serialize, Deserialize, Clone)]
+#[derive(Serialize, Deserialize, Clone, Debug)]
 struct FileEntry {
     path: String,
     is_dir: bool,
@@ -308,8 +309,8 @@ fn generate_datasets() -> Vec<Dataset> {
         }
 
         let info = DatasetInfo {
-            url: format!("https://example.com/datasets/{i}"),
-            id: Uuid::new_v4().to_string(),
+            url: "https://example.com/datasets".to_string(),
+            id: format!("{i}"),
             description: format!("Mock dataset number {i}"),
             total_files: Some(total_files),
             total_size_bytes: Some(total_size_bytes),