From 799676d86b977a268f8711a23a81f38145adefa1 Mon Sep 17 00:00:00 2001 From: Koen Date: Mon, 13 Apr 2026 02:11:26 +0000 Subject: [PATCH] Fix docs deploy: disable AOT on Playground.Wasm MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit .NET 10's wasm-tools workload rejects RunAOTCompilation when PublishTrimmed is false, which broke the Publish step in docs.yml: error : AOT is not supported without IL trimming (PublishTrimmed=true required). We can't enable trimming because Roslyn + EF Core don't trim cleanly, so disable AOT instead — the playground runs interpreted, trading Roslyn startup speed for a working build. Also drops the wasm-tools workload install from all 4 workflows; without AOT nothing in the publish path invokes emscripten / wasm-opt. Co-Authored-By: Claude Opus 4.6 (1M context) --- .github/workflows/benchmarks.yml | 4 ---- .github/workflows/ci.yml | 4 ---- .github/workflows/docs.yml | 4 ---- .github/workflows/release.yml | 4 ---- .../ExpressiveSharp.Docs.Playground.Wasm.csproj | 12 ++++-------- 5 files changed, 4 insertions(+), 24 deletions(-) diff --git a/.github/workflows/benchmarks.yml b/.github/workflows/benchmarks.yml index 90b5045..f4412ef 100644 --- a/.github/workflows/benchmarks.yml +++ b/.github/workflows/benchmarks.yml @@ -45,10 +45,6 @@ jobs: restore-keys: | nuget-${{ runner.os }}- - # Required by Playground.Wasm's Release AOT compilation. - - name: Install wasm-tools workload - run: dotnet workload install wasm-tools - - name: Restore run: dotnet restore diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 644ad77..f1913a7 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -39,10 +39,6 @@ jobs: restore-keys: | nuget-${{ runner.os }}- - # Required by Playground.Wasm's Release AOT compilation. - - name: Install wasm-tools workload - run: dotnet workload install wasm-tools - - name: Restore run: dotnet restore diff --git a/.github/workflows/docs.yml b/.github/workflows/docs.yml index b7a8e2d..a4c9f51 100644 --- a/.github/workflows/docs.yml +++ b/.github/workflows/docs.yml @@ -26,10 +26,6 @@ jobs: with: dotnet-version: '10.0.x' - # Required by Playground.Wasm's Release AOT compilation. - - name: Install wasm-tools workload - run: dotnet workload install wasm-tools - - name: Publish ExpressiveSharp Playground (Blazor WASM) run: | dotnet publish src/Docs/Playground.Wasm/ExpressiveSharp.Docs.Playground.Wasm.csproj \ diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 1bf88ec..642debb 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -53,10 +53,6 @@ jobs: echo "version=$VERSION" >> "$GITHUB_OUTPUT" echo "Publishing version: $VERSION" - # Required by Playground.Wasm's Release AOT compilation. - - name: Install wasm-tools workload - run: dotnet workload install wasm-tools - - name: Restore run: dotnet restore diff --git a/src/Docs/Playground.Wasm/ExpressiveSharp.Docs.Playground.Wasm.csproj b/src/Docs/Playground.Wasm/ExpressiveSharp.Docs.Playground.Wasm.csproj index 693e848..55e4c24 100644 --- a/src/Docs/Playground.Wasm/ExpressiveSharp.Docs.Playground.Wasm.csproj +++ b/src/Docs/Playground.Wasm/ExpressiveSharp.Docs.Playground.Wasm.csproj @@ -14,16 +14,12 @@ enable false - + false - - true - false