Skip to content

Commit 4f0c526

Browse files
authored
Merge pull request #32 from EFNext/fix/docs-deploy-aot
Fix docs deploy: disable AOT on Playground.Wasm
2 parents 2a61696 + 799676d commit 4f0c526

5 files changed

Lines changed: 4 additions & 24 deletions

File tree

.github/workflows/benchmarks.yml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -45,10 +45,6 @@ jobs:
4545
restore-keys: |
4646
nuget-${{ runner.os }}-
4747
48-
# Required by Playground.Wasm's Release AOT compilation.
49-
- name: Install wasm-tools workload
50-
run: dotnet workload install wasm-tools
51-
5248
- name: Restore
5349
run: dotnet restore
5450

.github/workflows/ci.yml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -39,10 +39,6 @@ jobs:
3939
restore-keys: |
4040
nuget-${{ runner.os }}-
4141
42-
# Required by Playground.Wasm's Release AOT compilation.
43-
- name: Install wasm-tools workload
44-
run: dotnet workload install wasm-tools
45-
4642
- name: Restore
4743
run: dotnet restore
4844

.github/workflows/docs.yml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,10 +26,6 @@ jobs:
2626
with:
2727
dotnet-version: '10.0.x'
2828

29-
# Required by Playground.Wasm's Release AOT compilation.
30-
- name: Install wasm-tools workload
31-
run: dotnet workload install wasm-tools
32-
3329
- name: Publish ExpressiveSharp Playground (Blazor WASM)
3430
run: |
3531
dotnet publish src/Docs/Playground.Wasm/ExpressiveSharp.Docs.Playground.Wasm.csproj \

.github/workflows/release.yml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -53,10 +53,6 @@ jobs:
5353
echo "version=$VERSION" >> "$GITHUB_OUTPUT"
5454
echo "Publishing version: $VERSION"
5555
56-
# Required by Playground.Wasm's Release AOT compilation.
57-
- name: Install wasm-tools workload
58-
run: dotnet workload install wasm-tools
59-
6056
- name: Restore
6157
run: dotnet restore
6258

src/Docs/Playground.Wasm/ExpressiveSharp.Docs.Playground.Wasm.csproj

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -14,16 +14,12 @@
1414
<ImplicitUsings>enable</ImplicitUsings>
1515
<IsPackable>false</IsPackable>
1616

17-
<!-- Roslyn + EF Core trim incompatibly. -->
17+
<!-- Roslyn + EF Core trim incompatibly, so PublishTrimmed stays off. .NET 10
18+
wasm-tools requires trimming for AOT, so AOT is disabled too — the
19+
playground runs interpreted, which trades Roslyn startup speed for a
20+
working build. -->
1821
<PublishTrimmed>false</PublishTrimmed>
1922

20-
<!-- AOT compilation via wasm-tools workload — significantly faster Roslyn
21-
execution at runtime. Only applied on Release publish. We can't strip
22-
IL after AOT because PlaygroundReferences feeds the .dll files back
23-
into Roslyn as MetadataReference instances for compile-time type
24-
resolution — MetadataReference.CreateFromImage needs real PE bytes. -->
25-
<RunAOTCompilation Condition="'$(Configuration)' == 'Release'">true</RunAOTCompilation>
26-
2723
<!-- WebCIL packaging + content-hashed asset names off so SnippetCompiler
2824
can fetch reference DLLs from /_framework/<name>.dll via HttpClient. -->
2925
<WasmEnableWebcil>false</WasmEnableWebcil>

0 commit comments

Comments
 (0)