Rendering bug - Pips repeat endlessly off the right side of the page

[SamClayton]

I've noticed this on at least 2 related builds. The visual representation of pips shows dozens of SYS pips leading for several screen widths off to the right. Tested in Chrome on Windows 10 & Mac Catalina; I believe I reproduced it in another browser (Firefox? Edge?) on Windows.

https://coriolis.io/outfit/type_9_heavy?code=A0pntsFklndssif61c7j7j--04070203070706054a320302023x3w.AwRj4yqo.MwBjIRjAmbykdxgcYQ%3D%3D.H4sIAAAAAAAAAzVOvQ4BYRAczv%2Fhchc%2FFxVylKJWiI5C1EqFTqtQeAQPIOEBlEoPovQAKrUIu2bFbTGZ75vZnYFkAXwSBHdHKJ1TgL8hC%2B4OEC3JNCFDMyUJudNH1ZvWgdqc76BJkzrSMD1N8KKXanBxgcq2CoQ3fmpaBnFIfs28wigDtK6i2jboGHSPysnIInZ64ZuX%2Bk%2FVXpG6lmQcl3gfrO6D1LM6vrHwV9eYlmUSO90pN32DaG9NqzIzybEjKwtpsKm%2FYFJUKFJX%2FOcLyAcAphgBAAA%3D.CwegTCAMUgbKB2MAOEBDANhglmgdgMYCmA%2BgQBbZEBmALmtniAAoCu11ABACrlGcBZNAHNsBTgBEATiID2eTgHcQAcQDMAMmCdyrLCACMkYzGiQgA%3D%3D%3D

[neilser]

I've seen this issue as well, on Windows 10 + Firefox, probably around 3 weeks ago. I was in a hurry and didn't note the build.

[alex-williams]

Relates directly to the _renderPips function in Pips.jsx. Something gets screwed up in the maths of it all and it ends up rendering hundreds of MultiCrew Pips. Applying MC Pips and then refreshing the page, has equally bad effects, as when you refresh the page, you have 6 active Pips as you would normally, but 2 of them are MC Pips, using the MC Pip reset button, causes the MC Pips to go away and you only have 4 pips to work with... this function needs a re-work.

[alex-williams]

React upgrade did not fix the problem, still an issue.

[alex-williams]

I cannot find the source of this bug... it seems to be just this build and I cannot identify a root cause for it. I've never seen it in any build I've made, or that has been shared with me, except this one. Ideally, I need more builds where this happens, to collate the similarities and figure out the cause.