fix - make new_empty method sync

Author: Dvisacker

src/amm/slipstream/mod.rs

@@ -653,7 +653,7 @@ impl AerodromeCLPool {
         }
     }
 
-    pub async fn new_empty(address: Address, chain: NamedChain) -> Result<Self, AMMError> {
+    pub fn new_empty(address: Address, chain: NamedChain) -> Result<Self, AMMError> {
         let pool = AerodromeCLPool {
             address,
             factory: Address::ZERO,

src/amm/uniswap_v2/batch_request.rs

@@ -158,6 +158,7 @@ mod tests {
     use std::str::FromStr;
     use types::exchange::ExchangeName;
 
+    #[allow(unused_variables)]
     const POOL_WITH_LARGE_RESERVES: &str = "0x8ff6c0958199a79ac0a619a88ceb6c0c96f16f89";
     const WETH_USDC: &str = "0x3548029694fbb241d45fb24ba0cd9c9d4e745f16";
 

src/amm/uniswap_v2/mod.rs

@@ -329,6 +329,26 @@ impl UniswapV2Pool {
         }
     }
 
+    pub fn new_empty(address: Address, chain: NamedChain) -> Result<Self, AMMError> {
+        let pool = UniswapV2Pool {
+            address,
+            token_a: Address::ZERO,
+            token_a_decimals: 0,
+            token_a_symbol: String::new(),
+            token_b: Address::ZERO,
+            token_b_decimals: 0,
+            token_b_symbol: String::new(),
+            reserve_0: 0,
+            reserve_1: 0,
+            fee: 0,
+            factory: Address::ZERO,
+            exchange_name: ExchangeName::Unknown,
+            exchange_type: ExchangeType::Unknown,
+            chain,
+        };
+        Ok(pool)
+    }
+
     /// Creates a new instance of the pool from the pair address, and syncs the pool data.
     pub async fn new_from_address<N, P>(
         pair_address: Address,

src/amm/uniswap_v3/batch_request/mod.rs

@@ -195,6 +195,8 @@ where
     Ok((all_tick_data, U256::from(bn)))
 }
 
+// TODO: This function is confusing and not very useful since it only syncs the
+// tick and liquidity (and not the entire data). Remove or rename this function
 pub async fn sync_v3_pool_batch_request<N, P>(
     pool: &mut UniswapV3Pool,
     provider: Arc<P>,

src/amm/uniswap_v3/mod.rs

@@ -654,7 +654,7 @@ impl UniswapV3Pool {
         }
     }
 
-    pub async fn new_empty(address: Address, chain: NamedChain) -> Result<Self, AMMError> {
+    pub fn new_empty(address: Address, chain: NamedChain) -> Result<Self, AMMError> {
         let pool = UniswapV3Pool {
             address,
             factory: Address::ZERO,