Fix SSL status of unreachable domains

Author: timobrembeck

CHANGELOG

@@ -1,5 +1,6 @@
 Unreleased
 
+* Fix SSL status of unreachable domains (Timo Ludwig, #184)
 * Fix URL message for internal server errorrs (Timo Ludwig, #182)
 * Add support for Django 4.2
 * Remove support for Django 4.0

linkcheck/models.py

@@ -387,18 +387,17 @@ def check_external(self, external_recheck_interval=EXTERNAL_RECHECK_INTERVAL):
         }
         try:
             try:
-                # If no exceptions occur, the SSL certificate is valid
-                if self.external_url.startswith('https://'):
-                    self.ssl_status = True
                 # At first try a HEAD request
                 fetch = requests.head
                 response = fetch(self.external_url, **request_params)
+                # If no exceptions occur, the SSL certificate is valid
+                if self.external_url.startswith('https://'):
+                    self.ssl_status = True
             except ConnectionError as e:
                 # This error could also be caused by an incomplete root certificate bundle,
                 # so let's retry without verifying the certificate
                 if "unable to get local issuer certificate" in str(e):
                     request_params['verify'] = False
-                    self.ssl_status = None
                     response = fetch(self.external_url, **request_params)
                 else:
                     # Re-raise exception if it's definitely not a false positive

linkcheck/tests/test_linkcheck.py

@@ -436,6 +436,23 @@ def test_external_check_404_incomplete_cert(self):
         self.assertEqual(uv.redirect_to, '')
         self.assertEqual(uv.type, 'external')
 
+    def test_external_check_unreachable(self):
+        uv = Url(url='https://invalid')
+        uv.check_url()
+        self.assertEqual(uv.status, False)
+        for attr in [uv.message, uv.get_message, uv.error_message]:
+            self.assertEqual(
+                attr,
+                'New Connection Error: Failed to establish a new connection: [Errno -2] Name or service not known',
+            )
+        self.assertEqual(uv.anchor_message, '')
+        self.assertEqual(uv.ssl_status, None)
+        self.assertEqual(uv.ssl_message, 'SSL certificate could not be checked')
+        self.assertEqual(uv.get_status_code_display(), None)
+        self.assertEqual(uv.get_redirect_status_code_display(), None)
+        self.assertEqual(uv.redirect_to, '')
+        self.assertEqual(uv.type, 'external')
+
     def test_external_check_200_utf8(self):
         uv = Url(url=f"{self.live_server_url}/http/200/r%C3%BCckmeldung/")
         uv.check_url()