Commit 9b7b28a
committed
Fix interference with level environment (v1.2.1.1)
New Options:
* Minimum LOD - This setting has returned, now that the underlying issue for its removal has been solved in a different way.
* Show Data Effect in Ghost Mode - The data materialization spawn effect can now be turned on/off for cars in Ghost Mode.
Changes:
* Fundamental changes have been made to how car visual styles are assigned. Previously we would modify isGhost and simulateNetworkCar in order to force our ideal ghost, but this actually had a ton of side effects.
* For the most part PlayerDataReplay.isGhost_ is used to determine if the replay is in GHOST MODE. When in Ghost Mode, the replay will not interact with the environment. So when setting isGhost_ to false for replay/networked style cars, this gave replay cars access to changing the environment (like road popups, explodable mines, etc.).
* The other half of level interference came from the `NitronicCarController` (which simulates fine car movement, like steering and suspension). It's still not clear *what* inside this controller is causing issues, but *this* is the cause of the warp anchor problems in the workshop level Breakout. This controller houses some very intensive CPU calculations, so it's still not clear if this is a lag issue. But for now, the solution is to manually disable the controller when we exceed a certain number of ghost replays/combined with a Minimum LOD that would force the controller to always be enabled.
* Because we've solved the issue with `NitronicCarController`, Minimum LOD can now be a setting again.
* LOD settings have been completely rebranded to make more sense to the average user (using names seen in Graphics settings):
* Speck -> Very Low
* Very Far -> Low
* Far -> Medium
* Medium -> High
* Near -> Ultra
* In-Focus -> Ultra (In-Focus)
* The In-Focus (First Person) LOD option has been completely removed, and how In-Focus LOD types are handled has been changed. Max LOD no longer affects In-Focus LOD types, since these are exclusively used for the car with camera focus.
* The In-Focus (Ultra (In-Focus)) setting is now exclusive to Minimum LOD, what this does is allow the LOD for cars to go one step higher than it would normally for unfocused cars.
Refactors:
* The CreatePlayerDataReplay method patch has been completely removed, in favor of creating our compound data at the start of InitPlayerDataReplay. We can do this now, because we're no longer trying to modify the isGhost argument being passed to InitPlayerDataReplay.1 parent dc6a04c commit 9b7b28a
15 files changed
Lines changed: 420 additions & 326 deletions
File tree
- Distance.ReplayIntensifies
- Harmony/Assembly-CSharp
- CarLevelOfDetail
- PlayerDataReplay
- Properties
- Scripts
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
71 | 71 | | |
72 | 72 | | |
73 | 73 | | |
74 | | - | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
75 | 81 | | |
76 | 82 | | |
| 83 | + | |
| 84 | + | |
77 | 85 | | |
78 | 86 | | |
79 | 87 | | |
80 | 88 | | |
81 | 89 | | |
82 | 90 | | |
83 | | - | |
| 91 | + | |
84 | 92 | | |
85 | | - | |
86 | | - | |
| 93 | + | |
87 | 94 | | |
88 | | - | |
89 | | - | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
90 | 98 | | |
91 | | - | |
92 | | - | |
93 | | - | |
94 | | - | |
95 | | - | |
96 | 99 | | |
97 | 100 | | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
98 | 104 | | |
99 | 105 | | |
100 | 106 | | |
| |||
105 | 111 | | |
106 | 112 | | |
107 | 113 | | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
108 | 121 | | |
109 | 122 | | |
110 | 123 | | |
| |||
176 | 189 | | |
177 | 190 | | |
178 | 191 | | |
179 | | - | |
180 | | - | |
181 | | - | |
182 | | - | |
183 | | - | |
184 | | - | |
185 | | - | |
186 | | - | |
187 | | - | |
| 192 | + | |
188 | 193 | | |
189 | 194 | | |
190 | 195 | | |
| |||
199 | 204 | | |
200 | 205 | | |
201 | 206 | | |
202 | | - | |
203 | | - | |
204 | | - | |
205 | | - | |
206 | | - | |
207 | | - | |
208 | | - | |
209 | | - | |
210 | | - | |
211 | | - | |
212 | | - | |
213 | | - | |
214 | 207 | | |
215 | 208 | | |
216 | 209 | | |
| |||
220 | 213 | | |
221 | 214 | | |
222 | 215 | | |
223 | | - | |
224 | | - | |
225 | | - | |
226 | | - | |
227 | | - | |
228 | | - | |
229 | | - | |
230 | | - | |
231 | | - | |
232 | | - | |
233 | | - | |
234 | | - | |
235 | 216 | | |
236 | 217 | | |
237 | 218 | | |
| |||
347 | 328 | | |
348 | 329 | | |
349 | 330 | | |
350 | | - | |
351 | | - | |
| 331 | + | |
| 332 | + | |
| 333 | + | |
352 | 334 | | |
| 335 | + | |
353 | 336 | | |
354 | 337 | | |
355 | 338 | | |
| |||
Lines changed: 3 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
90 | 90 | | |
91 | 91 | | |
92 | 92 | | |
93 | | - | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
94 | 96 | | |
95 | 97 | | |
96 | 98 | | |
| |||
Lines changed: 26 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
3 | | - | |
4 | 2 | | |
5 | 3 | | |
6 | 4 | | |
| |||
16 | 14 | | |
17 | 15 | | |
18 | 16 | | |
| 17 | + | |
| 18 | + | |
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
| 22 | + | |
22 | 23 | | |
23 | 24 | | |
24 | 25 | | |
25 | 26 | | |
26 | 27 | | |
27 | | - | |
| 28 | + | |
28 | 29 | | |
29 | | - | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
30 | 33 | | |
31 | 34 | | |
32 | 35 | | |
33 | 36 | | |
34 | 37 | | |
35 | 38 | | |
36 | 39 | | |
37 | | - | |
38 | 40 | | |
39 | 41 | | |
40 | 42 | | |
| |||
47 | 49 | | |
48 | 50 | | |
49 | 51 | | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
50 | 71 | | |
51 | 72 | | |
52 | 73 | | |
| |||
Lines changed: 0 additions & 121 deletions
This file was deleted.
Lines changed: 1 addition & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
4 | | - | |
5 | 3 | | |
6 | 4 | | |
7 | 5 | | |
8 | 6 | | |
9 | 7 | | |
10 | 8 | | |
11 | 9 | | |
12 | | - | |
| 10 | + | |
13 | 11 | | |
14 | 12 | | |
15 | 13 | | |
| |||
0 commit comments