small fixes

Author: trangdoan982

apps/roam/src/components/ModifyNodeDialog.tsx

@@ -260,17 +260,20 @@ const ModifyNodeDialog = ({
       alive = false;
       refAlive = false;
     };
-  }, [selectedNodeType, referencedNode]);
+  }, [selectedNodeType, referencedNode, discourseNodes]);
 
   const setValue = useCallback(
     (r: Result) => {
       setContent(r);
       if (!selectedNodeType && r.uid) {
         const detectedType = (r as Record<string, unknown>)
-          ._discourseNodeType as string | undefined;
+          .discourseNodeType as string | undefined;
         if (detectedType) {
           const nt = discourseNodes.find((n) => n.type === detectedType);
-          if (nt) setSelectedNodeType(nt);
+          if (nt) {
+            setSelectedNodeType(nt);
+            setError("");
+          }
         }
       }
     },
@@ -591,6 +594,7 @@ const ModifyNodeDialog = ({
                   if (nt) {
                     setSelectedNodeType(nt);
                     setReferencedNodeValue({ text: "", uid: "" });
+                    setError("");
                   }
                 }}
                 disabled={

apps/roam/src/utils/registerCommandPaletteCommands.ts

@@ -189,19 +189,9 @@ export const registerCommandPaletteCommands = (onloadArgs: OnloadArgs) => {
 
     const selectionStart = uid ? getSelectionStartForBlock(uid) : 0;
 
-    const defaultNodeType =
-      getDiscourseNodes().filter(excludeDefaultNodes)[0]?.type;
-    if (!defaultNodeType) {
-      renderToast({
-        id: "create-discourse-node-command-no-types",
-        content: "No discourse node types found in settings.",
-      });
-      return;
-    }
-
     renderModifyNodeDialog({
       mode: "create",
-      nodeType: defaultNodeType,
+      nodeType: "",
       initialValue: { text: "", uid: "" },
       extensionAPI,
       onSuccess: async (result) => {