feat(settings): auto-generate new thread titles (#382)

Co-authored-by: Thomas Ricouard <ricouard77@gmail.com>

Author: Samigos

docs/mobile-ios-cloudflare-blueprint.md

@@ -237,7 +237,7 @@ Implemented in shared core + daemon/app adapters:
 - Workspace/app extras:
   - `add_clone`, `apply_worktree_changes`, `open_workspace_in`, `get_open_app_icon`
 - Utility commands:
-  - `codex_doctor`, `get_commit_message_prompt`, `generate_commit_message`, `generate_run_metadata`, `local_usage_snapshot`, `send_notification_fallback`, `is_macos_debug_build`, `menu_set_accelerators`
+  - `codex_doctor`, `generate_commit_message`, `generate_run_metadata`, `local_usage_snapshot`, `send_notification_fallback`, `is_macos_debug_build`, `menu_set_accelerators`
 
 Out of scope for this mobile phase:
 

src-tauri/src/bin/codex_monitor_daemon.rs

@@ -1101,107 +1101,43 @@ impl DaemonState {
         codex_aux_core::codex_doctor_core(&self.app_settings, codex_bin, codex_args).await
     }
 
-    async fn get_commit_message_prompt(&self, workspace_id: String) -> Result<String, String> {
-        let repo_root =
-            git_ui_core::resolve_repo_root_for_workspace_core(&self.workspaces, workspace_id)
-                .await?;
-        let diff = git_ui_core::collect_workspace_diff_core(&repo_root)?;
-        if diff.trim().is_empty() {
-            return Err("No changes to generate commit message for".to_string());
-        }
-        let commit_message_prompt = {
-            let settings = self.app_settings.lock().await;
-            settings.commit_message_prompt.clone()
-        };
-        Ok(codex_aux_core::build_commit_message_prompt(
-            &diff,
-            &commit_message_prompt,
-        ))
-    }
-
     async fn generate_commit_message(&self, workspace_id: String) -> Result<String, String> {
         let repo_root = git_ui_core::resolve_repo_root_for_workspace_core(
             &self.workspaces,
             workspace_id.clone(),
         )
         .await?;
         let diff = git_ui_core::collect_workspace_diff_core(&repo_root)?;
-        if diff.trim().is_empty() {
-            return Err("No changes to generate commit message for".to_string());
-        }
         let commit_message_prompt = {
             let settings = self.app_settings.lock().await;
             settings.commit_message_prompt.clone()
         };
-        let prompt = codex_aux_core::build_commit_message_prompt(
-            &diff,
-            &commit_message_prompt,
-        );
-        let response = codex_aux_core::run_background_prompt_core(
+        codex_aux_core::generate_commit_message_core(
             &self.sessions,
             workspace_id,
-            prompt,
+            &diff,
+            &commit_message_prompt,
             |workspace_id, thread_id| {
                 emit_background_thread_hide(&self.event_sink, workspace_id, thread_id);
             },
-            "Timeout waiting for commit message generation",
-            "Unknown error during commit message generation",
         )
-        .await?;
-
-        let trimmed = response.trim().to_string();
-        if trimmed.is_empty() {
-            return Err("No commit message was generated".to_string());
-        }
-        Ok(trimmed)
+        .await
     }
 
     async fn generate_run_metadata(
         &self,
         workspace_id: String,
         prompt: String,
     ) -> Result<Value, String> {
-        let cleaned_prompt = prompt.trim();
-        if cleaned_prompt.is_empty() {
-            return Err("Prompt is required.".to_string());
-        }
-
-        let title_prompt = codex_aux_core::build_run_metadata_prompt(cleaned_prompt);
-        let response_text = codex_aux_core::run_background_prompt_core(
+        codex_aux_core::generate_run_metadata_core(
             &self.sessions,
             workspace_id,
-            title_prompt,
+            &prompt,
             |workspace_id, thread_id| {
                 emit_background_thread_hide(&self.event_sink, workspace_id, thread_id);
             },
-            "Timeout waiting for metadata generation",
-            "Unknown error during metadata generation",
         )
-        .await?;
-
-        let trimmed = response_text.trim();
-        if trimmed.is_empty() {
-            return Err("No metadata was generated".to_string());
-        }
-        let json_value = codex_aux_core::extract_json_value(trimmed)
-            .ok_or_else(|| "Failed to parse metadata JSON".to_string())?;
-        let title = json_value
-            .get("title")
-            .and_then(|v| v.as_str())
-            .map(|v| v.trim().to_string())
-            .filter(|v| !v.is_empty())
-            .ok_or_else(|| "Missing title in metadata".to_string())?;
-        let worktree_name = json_value
-            .get("worktreeName")
-            .or_else(|| json_value.get("worktree_name"))
-            .and_then(|v| v.as_str())
-            .map(codex_aux_core::sanitize_run_worktree_name)
-            .filter(|v| !v.is_empty())
-            .ok_or_else(|| "Missing worktree name in metadata".to_string())?;
-        Ok(json!({
-            "title": title,
-            "worktreeName": worktree_name
-        }))
+        .await
     }
 
     async fn local_usage_snapshot(

src-tauri/src/bin/codex_monitor_daemon/rpc.rs

@@ -695,11 +695,6 @@ pub(super) async fn handle_rpc_request(
             let codex_args = parse_optional_string(&params, "codexArgs");
             state.codex_doctor(codex_bin, codex_args).await
         }
-        "get_commit_message_prompt" => {
-            let workspace_id = parse_string(&params, "workspaceId")?;
-            let prompt = state.get_commit_message_prompt(workspace_id).await?;
-            Ok(Value::String(prompt))
-        }
         "generate_commit_message" => {
             let workspace_id = parse_string(&params, "workspaceId")?;
             let message = state.generate_commit_message(workspace_id).await?;

src-tauri/src/codex/mod.rs

@@ -550,42 +550,6 @@ pub(crate) async fn respond_to_server_request(
         .await
 }
 
-/// Gets the diff content for commit message generation
-#[tauri::command]
-pub(crate) async fn get_commit_message_prompt(
-    workspace_id: String,
-    state: State<'_, AppState>,
-    app: AppHandle,
-) -> Result<String, String> {
-    if remote_backend::is_remote_mode(&*state).await {
-        let value = remote_backend::call_remote(
-            &*state,
-            app,
-            "get_commit_message_prompt",
-            json!({ "workspaceId": workspace_id }),
-        )
-        .await?;
-        return serde_json::from_value(value).map_err(|err| err.to_string());
-    }
-
-    // Get the diff from git
-    let diff = crate::git::get_workspace_diff(&workspace_id, &state).await?;
-
-    if diff.trim().is_empty() {
-        return Err("No changes to generate commit message for".to_string());
-    }
-
-    let commit_message_prompt = {
-        let settings = state.app_settings.lock().await;
-        settings.commit_message_prompt.clone()
-    };
-
-    Ok(crate::shared::codex_aux_core::build_commit_message_prompt(
-        &diff,
-        &commit_message_prompt,
-    ))
-}
-
 #[tauri::command]
 pub(crate) async fn remember_approval_rule(
     workspace_id: String,
@@ -634,22 +598,15 @@ pub(crate) async fn generate_commit_message(
 
     let diff = crate::git::get_workspace_diff(&workspace_id, &state).await?;
 
-    if diff.trim().is_empty() {
-        return Err("No changes to generate commit message for".to_string());
-    }
-
     let commit_message_prompt = {
         let settings = state.app_settings.lock().await;
         settings.commit_message_prompt.clone()
     };
-    let prompt = crate::shared::codex_aux_core::build_commit_message_prompt(
-        &diff,
-        &commit_message_prompt,
-    );
-    let response = crate::shared::codex_aux_core::run_background_prompt_core(
+    crate::shared::codex_aux_core::generate_commit_message_core(
         &state.sessions,
         workspace_id,
-        prompt,
+        &diff,
+        &commit_message_prompt,
         |workspace_id, thread_id| {
             let _ = app.emit(
                 "app-server-event",
@@ -665,17 +622,8 @@ pub(crate) async fn generate_commit_message(
                 },
             );
         },
-        "Timeout waiting for commit message generation",
-        "Unknown error during commit message generation",
     )
-    .await?;
-
-    let trimmed = response.trim().to_string();
-    if trimmed.is_empty() {
-        return Err("No commit message was generated".to_string());
-    }
-
-    Ok(trimmed)
+    .await
 }
 
 #[tauri::command]
@@ -695,16 +643,10 @@ pub(crate) async fn generate_run_metadata(
         .await;
     }
 
-    let cleaned_prompt = prompt.trim();
-    if cleaned_prompt.is_empty() {
-        return Err("Prompt is required.".to_string());
-    }
-
-    let title_prompt = crate::shared::codex_aux_core::build_run_metadata_prompt(cleaned_prompt);
-    let response_text = crate::shared::codex_aux_core::run_background_prompt_core(
+    crate::shared::codex_aux_core::generate_run_metadata_core(
         &state.sessions,
         workspace_id,
-        title_prompt,
+        &prompt,
         |workspace_id, thread_id| {
             let _ = app.emit(
                 "app-server-event",
@@ -720,34 +662,6 @@ pub(crate) async fn generate_run_metadata(
                 },
             );
         },
-        "Timeout waiting for metadata generation",
-        "Unknown error during metadata generation",
     )
-    .await?;
-
-    let trimmed = response_text.trim();
-    if trimmed.is_empty() {
-        return Err("No metadata was generated".to_string());
-    }
-
-    let json_value = crate::shared::codex_aux_core::extract_json_value(trimmed)
-        .ok_or_else(|| "Failed to parse metadata JSON".to_string())?;
-    let title = json_value
-        .get("title")
-        .and_then(|v| v.as_str())
-        .map(|v| v.trim().to_string())
-        .filter(|v| !v.is_empty())
-        .ok_or_else(|| "Missing title in metadata".to_string())?;
-    let worktree_name = json_value
-        .get("worktreeName")
-        .or_else(|| json_value.get("worktree_name"))
-        .and_then(|v| v.as_str())
-        .map(crate::shared::codex_aux_core::sanitize_run_worktree_name)
-        .filter(|v| !v.is_empty())
-        .ok_or_else(|| "Missing worktree name in metadata".to_string())?;
-
-    Ok(json!({
-        "title": title,
-        "worktreeName": worktree_name
-    }))
+    .await
 }

src-tauri/src/lib.rs

@@ -229,7 +229,6 @@ pub fn run() {
             codex::start_review,
             codex::respond_to_server_request,
             codex::remember_approval_rule,
-            codex::get_commit_message_prompt,
             codex::generate_commit_message,
             codex::generate_run_metadata,
             codex::resume_thread,

src-tauri/src/remote_backend/mod.rs

@@ -130,7 +130,6 @@ fn can_retry_after_disconnect(method: &str) -> bool {
             | "file_read"
             | "get_config_model"
             | "get_git_commit_diff"
-            | "get_commit_message_prompt"
             | "get_git_diffs"
             | "get_git_log"
             | "get_git_remote"
@@ -255,7 +254,6 @@ mod tests {
     fn retries_only_retry_safe_methods_after_disconnect() {
         assert!(can_retry_after_disconnect("resume_thread"));
         assert!(can_retry_after_disconnect("list_threads"));
-        assert!(can_retry_after_disconnect("get_commit_message_prompt"));
         assert!(can_retry_after_disconnect("local_usage_snapshot"));
         assert!(!can_retry_after_disconnect("send_user_message"));
         assert!(!can_retry_after_disconnect("start_thread"));