refactor: Exit codes, check for multiple function defenitions

Author: IB004

src/compiler.cpp

@@ -70,11 +70,11 @@ int main(int argc, char* argv[]) {
             auto srcs = result["source"].as<std::vector<std::string>>();
             if (srcs.size() > 1) {
                 std::cerr << "Module can be compiled from only one source file.\n";
-                exit(1);
+                exit(func::error_codes::E_PARAMS);
             }
             if(drv.parse(srcs[0]) != 0) {
                 std::cerr << "Failed to parse - exiting.\n";
-                exit(1);
+                exit(func::error_codes::E_SYTNTAX);
             }
         } else {
             exit(0); // No input files were given.
@@ -87,12 +87,12 @@ int main(int argc, char* argv[]) {
             target_arch = Arch::X64;
         } else {
             std::cerr << "Unknown architecture: " << arch_str << "\n";
-            exit(1);
+            exit(func::error_codes::E_PARAMS);
         }
 
     } catch(const cxxopts::exceptions::exception& e) {
         std::cerr << "Error parsing options: " << e.what() << '\n';
-        exit(1);
+        exit(func::error_codes::E_PARAMS);
     }
 
     func::print_visitor print_visitor{ std::cout };
@@ -132,21 +132,24 @@ int main(int argc, char* argv[]) {
             }
             default: {
                 std::cerr << "Unsupported architecture\n";
-                exit(1);
+                exit(func::error_codes::E_PARAMS);
             }
         }
 
     } catch(func::unexpected_type_exception& e) {
         std::cerr << "Syntax error: unexpected type " << e << "\n";
-        exit(1);
+        exit(func::error_codes::E_TYPE);
     } catch(func::symbol_not_found_exception& e) {
         std::cerr << "Syntax error: symbol not found " << e << "\n";
-        exit(1);
+        exit(func::error_codes::E_SYMBOL);
+    } catch(func::symbol_redeclaration_exception& e) {
+        std::cerr << "Syntax error: symbol redeclaration " << e << "\n";
+        exit(func::error_codes::E_SYMBOL);
     } catch(func::syntax_exception& e) {
         std::cerr << "Syntax error: " << e << "\n";
-        exit(1);
+        exit(func::error_codes::E_SYTNTAX);
     } catch(func::global_syntax_exception& e) {
         std::cerr << "Syntax error: " << e << "\n";
-        exit(1);
+        exit(func::error_codes::E_SYTNTAX);
     }
 }

src/exception.hpp

@@ -6,6 +6,14 @@
 #include <string>
 namespace func {
 
+enum error_codes{
+    E_SYTNTAX = 1,
+    E_SYMBOL = 2,
+    E_TYPE = 3,
+    E_PARAMS = 4,
+    E_OTHER = 5,
+};
+
 struct syntax_exception {
     std::string reason;
     yy::location loc;

src/visitor/llvm_visitor/llvm_visitor.cpp

@@ -89,6 +89,11 @@ void llvm_visitor::visit(const function& node) {
         return;
     }
 
+    if (!f->empty()){
+        throw syntax_exception{ "Multiple defenition of function '" + node.get_identifier() + "'.",
+                                node.get_loc() };
+    }
+
     BasicBlock* bb = BasicBlock::Create(ctx, "entry", f);
     builder.SetInsertPoint(bb);
 
@@ -128,7 +133,7 @@ void llvm_visitor::visit(const function& node) {
     std::string error_msg;
     llvm::raw_string_ostream os(error_msg);
     if(llvm::verifyFunction(*f, &os)) {
-        throw syntax_exception{ error_msg, node.get_loc() };
+        throw unexpected_type_exception {error_msg, node.get_loc()};
     }
 
     fpm.run(*f, fam);

tests/negative/call_undeclared.fc

@@ -1,6 +1,6 @@
 // test: call-undeclared-func-test
 // compile-fail: true
-// exit-code: 1
+// exit-code: 2
 
 int write(int _);
 void exit(int _);

tests/negative/call_wrong_type_args.fc

@@ -1,6 +1,6 @@
 // test: call-with-wrong-type-of-arguments-test
 // compile-fail: true
-// exit-code: 1
+// exit-code: 3
 
 int write(int _);
 void exit(int _);

tests/negative/call_wrong_type_args_2.fc

@@ -1,6 +1,6 @@
 // test: call-with-wrong-type-of-func-arguments-test
 // compile-fail: true
-// exit-code: 1
+// exit-code: 3
 
 int write(int _);
 void exit(int _);

tests/negative/declare_diff_body.fc

@@ -2,17 +2,19 @@
 // compile-fail: true
 // exit-code: 1
 
+int write(int _);
 void exit(int _);
 
-int foo(int arg){
-    return 1;
-};
+int foo(){
+    return 97;
+}
 
-int foo(int arg){
-    return 2;
-};
+int foo(){
+    return 98;
+}
 
 void main(){
+    write(foo());
     exit(0);
 }
 

tests/negative/declare_diff_sign.fc

@@ -1,6 +1,6 @@
 // test: declare-with-different-signature-test
 // compile-fail: true
-// exit-code: 1
+// exit-code: 2
 
 void exit(int _);