Update python and pre-commits (#384)

* Replace black with ruff and add python version

* Fix parser

* Update CI too

Author: noemifrisina

.github/workflows/code.yml

@@ -46,7 +46,7 @@ jobs:
       fail-fast: false
       matrix:
         os: ["ubuntu-latest"] # can add windows-latest, macos-latest
-        python: ["3.12"]
+        python: ["3.12", "3.13"]
         install: ["-e .[dev]"]
         # Make one version be non-editable to test both paths of version code
         include:

.pre-commit-config.yaml

@@ -1,22 +1,21 @@
 repos:
 
-# Automatic source code formatting
-- repo: https://github.com/psf/black
-  rev: 24.1.1
-  hooks:
-  - id: black
-    args: [--safe, --quiet]
-
-
 # Linter
 - repo: local
   hooks:
     - id: ruff
-      name: Run ruff
-      stages: [pre-commit]
+      name: lint with ruff
+      language: system
+      entry: ruff check --force-exclude --fix
+      types: [python]
+      require_serial: true
+
+    - id: ruff-format
+      name: format with ruff
       language: system
-      entry: ruff check
+      entry: ruff format --force-exclude
       types: [python]
+      require_serial: true
 
 
 # Other syntax checks

pyproject.toml

@@ -13,6 +13,7 @@ classifiers = [
     "Natural Language :: English",
     "Programming Language :: Python :: 3.11",
     "Programming Language :: Python :: 3.12",
+    "Programming Language :: Python :: 3.13",
 ]
 keywords = ["nexus", "NXmx"]
 dependencies = [

src/nexgen/command_line/ED_mrc_to_nexus.py

@@ -344,7 +344,6 @@ def overwrite_from_command_line(
 
 
 def log_dict(logger: Logger, dictionary: dict, skip: list = None) -> None:
-
     if skip is None:
         skip = [1]
 
@@ -366,7 +365,6 @@ def log_dict(logger: Logger, dictionary: dict, skip: list = None) -> None:
 
 
 def main():
-
     args = parse_input_arguments()
     metadata_template = Metadata(args.input_files)
     logger.info("Starting MRC to Nexus conversion.")
@@ -478,7 +476,6 @@ def main():
 
 
 def parse_input_arguments():
-
     msg = "Convert electron diffraction data from an MRC format "
     msg += "to a NeXus format"
     parser = ArgumentParser(description=msg, add_help=True)

src/nexgen/command_line/ED_nexus.py

@@ -25,7 +25,6 @@
 
 
 def write_from_SINGLA(args):
-
     singla_nexus_writer(
         args.master_file,
         args.det_distance,
@@ -60,7 +59,7 @@ def write_from_SINGLA_from_config(args):
         )
         ED_coord_system["convention"] = params.coord_system.convention
     else:
-        logger.info("The following convention will be applied:\n" f"{ED_coord_system}")
+        logger.info(f"The following convention will be applied:\n{ED_coord_system}")
 
     if params.coord_system.origin:
         logger.info(

src/nexgen/command_line/I19_2_cli.py

@@ -307,7 +307,7 @@ def nexgen_writer(args):
     help="Data entry key of dataset in raw .h5 file. Defaults to data.",
 )
 parser_nex.add_argument(
-    "-bits" "--bit-depth",
+    "-bits--bit-depth",
     type=int,
     choices=[8, 16, 32],
     default=32,

src/nexgen/command_line/nexus_generator.py

@@ -393,7 +393,8 @@ def _parse_cli() -> argparse.ArgumentParser:
         help="Data entry key of dataset in raw .h5 file. Defaults to data.",
     )
     nxmx_parser.add_argument(
-        "-bits" "--bit-depth",
+        "-bits",
+        "--bit-depth",
         type=int,
         choices=[8, 16, 32],
         default=32,

src/nexgen/nxs_copy/copy_nexus.py

@@ -41,7 +41,10 @@ def images_nexus(
     original_nexus = Path(original_nexus).expanduser().resolve()
     nxs_filename = get_nexus_filename(data_file[0], copy=True)
     copy_logger.debug(f"New NeXus file name: {nxs_filename}")
-    with h5py.File(original_nexus, "r") as nxs_in, h5py.File(nxs_filename, "x") as nxs_out:
+    with (
+        h5py.File(original_nexus, "r") as nxs_in,
+        h5py.File(nxs_filename, "x") as nxs_out,
+    ):
         if simple_copy is True:
             # Copy the whole tree
             get_nexus_tree(nxs_in, nxs_out, skip=False)
@@ -92,9 +95,10 @@ def pseudo_events_nexus(
     original_nexus = Path(original_nexus).expanduser().resolve()
     nxs_filename = get_nexus_filename(data_file[0], copy=True)
     copy_logger.debug(f"New NeXus file name: {nxs_filename}")
-    with h5py.File(original_nexus, "r") as nxs_in, h5py.File(
-        nxs_filename, "x"
-    ) as nxs_out:
+    with (
+        h5py.File(original_nexus, "r") as nxs_in,
+        h5py.File(nxs_filename, "x") as nxs_out,
+    ):
         nxs_out.attrs["default"] = "entry"
         # Copy the whole tree except for nxdata
         nxentry = get_nexus_tree(nxs_in, nxs_out)

src/nexgen/nxs_utils/__init__.py

@@ -34,5 +34,5 @@
     "TransformationType",
     "Facility",
     "CetaDetector",
-    "TVIPSDetector"
+    "TVIPSDetector",
 ]

src/nexgen/nxs_write/write_utils.py

@@ -239,8 +239,7 @@ def mask_and_flatfield_writer_for_event_data(
         )
     else:
         NXclassUtils_logger.warning(
-            f"No {dset_name} file found in working directory."
-            "Writing an ExternalLink."
+            f"No {dset_name} file found in working directory.Writing an ExternalLink."
         )
         file_loc = Path(dset_data_file)
         image_key = "image" if "tristan" in detector_name.lower() else "/"