Hlsl path tracer #224
Open
Hlsl path tracer #224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…htracer doesn't need create params
…params into render_common
# Conflicts: # 31_HLSLPathTracer/app_resources/hlsl/common.hlsl # 31_HLSLPathTracer/app_resources/hlsl/render.comp.hlsl # 31_HLSLPathTracer/app_resources/hlsl/render_common.hlsl # 31_HLSLPathTracer/app_resources/hlsl/render_rwmc_common.hlsl # 31_HLSLPathTracer/app_resources/hlsl/scene.hlsl # 31_HLSLPathTracer/main.cpp
…xis scaling for triangle and rectangle
…lights # Conflicts: # 31_HLSLPathTracer/app_resources/hlsl/render.comp.hlsl # 31_HLSLPathTracer/app_resources/hlsl/scene.hlsl # 31_HLSLPathTracer/main.cpp
Comment on lines
164
to
167
| for (uint32_t virtualThreadBase = glsl::gl_WorkGroupID().x * WorkgroupSize; virtualThreadBase < 1920*1080; virtualThreadBase += glsl::gl_NumWorkGroups().x * WorkgroupSize) // not sure why 1280*720 doesn't cover draw surface | ||
| { | ||
| virtualThreadIndex = virtualThreadBase + glsl::gl_LocalInvocationIndex().x; | ||
| const int32_t2 coords = (int32_t2)math::Morton<uint32_t>::decode2d(virtualThreadIndex); |
Member
Author
There was a problem hiding this comment.
you must have a bug here, check whether the image you store to is 720p and not 1080p, you should be querying the size from the image.
my hunch here is that you've messed up the math::Morton<uint32_t>::decode2d and you're computing the same pixel multiple times
btw you can use Morton only locally within a workgroup to translate the 64 workgroup invocations int a 8,8 offset.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@keptsecret after you merge
masteragain, you'll probably have the UI mess up and show changed from the merge commit, so close and reopen again