Skip to content

Commit eede016

Browse files
damyanpalsepkow
andauthored
Make LongVectors tests run as part of standard test passes (microsoft#7873)
Currently, the various test runners (lit, hcttest.cmd) only run execution tests where the Priority metadata is <2. Previously, the LongVectors tests didn't set a value for priority, and this resulted in them never being selected. This change adds the missing priority metadata - and then fixes up the tests so they don't immediately fail if the runtime/device doesn't support SM 6.9! --------- Co-authored-by: Alex Sepkowski <alexsepkowski@gmail.com>
1 parent 283365c commit eede016

File tree

1 file changed

+9
-2
lines changed

1 file changed

+9
-2
lines changed

tools/clang/unittests/HLSLExec/LongVectors.cpp

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1432,6 +1432,7 @@ class DxilConf_SM69_Vectorized {
14321432
TEST_CLASS_PROPERTY(
14331433
"Kits.Specification",
14341434
"Device.Graphics.D3D12.DXILCore.ShaderModel69.CoreRequirement")
1435+
TEST_METHOD_PROPERTY(L"Priority", L"0")
14351436
END_TEST_CLASS()
14361437

14371438
TEST_CLASS_SETUP(classSetup) {
@@ -1501,8 +1502,14 @@ class DxilConf_SM69_Vectorized {
15011502
OverrideInputSize);
15021503
}
15031504

1504-
// Only skip unsupported tests for RITP runs.
1505-
const bool SkipUnsupported = IsRITP;
1505+
bool FailIfRequirementsNotMet = false;
1506+
#ifdef _HLK_CONF
1507+
FailIfRequirementsNotMet = true;
1508+
#endif
1509+
WEX::TestExecution::RuntimeParameters::TryGetValue(
1510+
L"FailIfRequirementsNotMet", FailIfRequirementsNotMet);
1511+
1512+
const bool SkipUnsupported = !FailIfRequirementsNotMet;
15061513
createDevice(&D3DDevice, ExecTestUtils::D3D_SHADER_MODEL_6_9,
15071514
SkipUnsupported);
15081515
}

0 commit comments

Comments
 (0)