From 9fbe32237d6a8f6a24d6225ecd1e1cc609cdbf82 Mon Sep 17 00:00:00 2001 From: nYeonG4001 <2371324@hansung.ac.kr> Date: Sun, 12 Apr 2026 10:47:09 +0900 Subject: [PATCH] =?UTF-8?q?fix:=20=ED=9A=8C=EC=9B=90=EA=B0=80=EC=9E=85=20?= =?UTF-8?q?=EC=9D=B4=EC=9A=A9=EC=95=BD=EA=B4=80=20=EB=8F=99=EC=9D=98=20?= =?UTF-8?q?=EA=B2=80=EC=A6=9D=20=EC=9E=84=EC=8B=9C=20=EB=B9=84=ED=99=9C?= =?UTF-8?q?=EC=84=B1=ED=99=94=20(=ED=94=84=EB=A1=A0=ED=8A=B8=20=EB=AF=B8?= =?UTF-8?q?=EC=82=AC=EC=9A=A9)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../domain/user/dto/SignupRequest.java | 5 ++- .../domain/user/service/AuthService.java | 7 ++-- .../domain/user/service/AuthServiceTest.java | 35 +++++-------------- 3 files changed, 14 insertions(+), 33 deletions(-) diff --git a/src/main/java/com/devpick/domain/user/dto/SignupRequest.java b/src/main/java/com/devpick/domain/user/dto/SignupRequest.java index b92bff35..c17a59d2 100644 --- a/src/main/java/com/devpick/domain/user/dto/SignupRequest.java +++ b/src/main/java/com/devpick/domain/user/dto/SignupRequest.java @@ -2,7 +2,6 @@ import jakarta.validation.constraints.Email; import jakarta.validation.constraints.NotBlank; -import jakarta.validation.constraints.NotNull; import jakarta.validation.constraints.Pattern; import jakarta.validation.constraints.Size; @@ -22,10 +21,10 @@ public record SignupRequest( @Size(min = 2, max = 20, message = "닉네임은 2자 이상 20자 이하입니다.") String nickname, - @NotNull(message = "이용약관 동의 여부는 필수입니다.") + // @NotNull(message = "이용약관 동의 여부는 필수입니다.") // 프론트 미사용 — 재활성화 시 주석 해제 Boolean termsAgreed, - @NotNull(message = "개인정보처리방침 동의 여부는 필수입니다.") + // @NotNull(message = "개인정보처리방침 동의 여부는 필수입니다.") // 프론트 미사용 — 재활성화 시 주석 해제 Boolean privacyAgreed ) { } diff --git a/src/main/java/com/devpick/domain/user/service/AuthService.java b/src/main/java/com/devpick/domain/user/service/AuthService.java index 2729a10c..3d07a356 100644 --- a/src/main/java/com/devpick/domain/user/service/AuthService.java +++ b/src/main/java/com/devpick/domain/user/service/AuthService.java @@ -44,9 +44,10 @@ public class AuthService { */ @Transactional public SignupResponse signup(SignupRequest request) { - if (!Boolean.TRUE.equals(request.termsAgreed()) || !Boolean.TRUE.equals(request.privacyAgreed())) { - throw new DevpickException(ErrorCode.AUTH_CONSENT_REQUIRED); - } + // 프론트 미사용 — 재활성화 시 주석 해제 + // if (!Boolean.TRUE.equals(request.termsAgreed()) || !Boolean.TRUE.equals(request.privacyAgreed())) { + // throw new DevpickException(ErrorCode.AUTH_CONSENT_REQUIRED); + // } if (!emailVerificationRedisService.isVerified(request.email())) { throw new DevpickException(ErrorCode.AUTH_EMAIL_NOT_VERIFIED_FOR_SIGNUP); diff --git a/src/test/java/com/devpick/domain/user/service/AuthServiceTest.java b/src/test/java/com/devpick/domain/user/service/AuthServiceTest.java index 4bf3b975..a8a06a61 100644 --- a/src/test/java/com/devpick/domain/user/service/AuthServiceTest.java +++ b/src/test/java/com/devpick/domain/user/service/AuthServiceTest.java @@ -54,33 +54,14 @@ class AuthServiceTest { // ── signup ────────────────────────────────────────────────────────── - @Test - @DisplayName("이용약관 미동의 — termsAgreed=false이면 AUTH_CONSENT_REQUIRED 예외가 발생한다") - void signup_termsNotAgreed_throwsException() { - // given - SignupRequest request = new SignupRequest("test@devpick.kr", "password123!", "하영", false, true); - - // when & then - assertThatThrownBy(() -> authService.signup(request)) - .isInstanceOf(DevpickException.class) - .satisfies(e -> assertThat(((DevpickException) e).getErrorCode()) - .isEqualTo(ErrorCode.AUTH_CONSENT_REQUIRED)); - verify(userRepository, never()).save(any(User.class)); - } - - @Test - @DisplayName("개인정보처리방침 미동의 — privacyAgreed=false이면 AUTH_CONSENT_REQUIRED 예외가 발생한다") - void signup_privacyNotAgreed_throwsException() { - // given - SignupRequest request = new SignupRequest("test@devpick.kr", "password123!", "하영", true, false); - - // when & then - assertThatThrownBy(() -> authService.signup(request)) - .isInstanceOf(DevpickException.class) - .satisfies(e -> assertThat(((DevpickException) e).getErrorCode()) - .isEqualTo(ErrorCode.AUTH_CONSENT_REQUIRED)); - verify(userRepository, never()).save(any(User.class)); - } + // 프론트 미사용 — 재활성화 시 주석 해제 + // @Test + // @DisplayName("이용약관 미동의 — termsAgreed=false이면 AUTH_CONSENT_REQUIRED 예외가 발생한다") + // void signup_termsNotAgreed_throwsException() { ... } + + // @Test + // @DisplayName("개인정보처리방침 미동의 — privacyAgreed=false이면 AUTH_CONSENT_REQUIRED 예외가 발생한다") + // void signup_privacyNotAgreed_throwsException() { ... } @Test @DisplayName("정상 회원가입 — 이메일 인증 완료 후 회원가입 시 User가 저장되고 is_email_verified=true로 생성된다")