test(jetsocat): stabilize jmux proxy hello world test

Make the async JMUX write test wait for listeners explicitly, use the
tokio command variant, close the read server stdin, and disable proxy
auto-detection for the final client invocation. This removes a local
Windows-only source of flakiness while keeping the test behavior the
same.

Author: CBenoit

testsuite/tests/cli/jetsocat.rs

@@ -1,4 +1,3 @@
-use std::io::Read;
 use std::sync::Arc;
 use std::time::Duration;
 
@@ -216,77 +215,84 @@ fn jmux_proxy_read_hello_world() {
     client_output.success().stdout("hello world\n");
 }
 
-#[test]
-fn jmux_proxy_write_hello_world() {
+#[tokio::test]
+async fn jmux_proxy_write_hello_world() {
+    use tokio::io::AsyncReadExt as _;
+
     // Find 3 available ports at once to avoid conflicts.
     let ports = find_unused_ports(3);
     let read_server_port = ports[0];
     let jmux_server_port = ports[1];
     let proxy_listen_port = ports[2];
 
     // Start read server first.
-    let mut read_server = jetsocat_cmd()
+    let mut read_server = jetsocat_tokio_cmd()
         .env(
             "JETSOCAT_ARGS",
             format!("forward tcp-listen://127.0.0.1:{read_server_port} stdio --no-proxy"),
         )
+        .stdin(std::process::Stdio::null())
         .stdout(std::process::Stdio::piped())
+        .kill_on_drop(true)
         .spawn()
         .expect("failed to start read server");
 
-    // Give the read server time to start.
-    std::thread::sleep(LISTENER_WAIT_DURATION);
+    wait_for_port_bound(read_server_port).await.expect("read server ready");
 
     // Start JMUX server that will accept JMUX connections.
-    let mut jmux_server = jetsocat_cmd()
+    let mut jmux_server = jetsocat_tokio_cmd()
         .env(
             "JETSOCAT_ARGS",
             format!("jmux-proxy tcp-listen://127.0.0.1:{jmux_server_port} --allow-all --no-proxy"),
         )
+        .kill_on_drop(true)
         .spawn()
         .expect("failed to start JMUX server");
 
-    // Give the JMUX server time to start.
-    std::thread::sleep(LISTENER_WAIT_DURATION);
+    wait_for_port_bound(jmux_server_port).await.expect("JMUX server ready");
 
     // Start JMUX client proxy that connects to the JMUX server and provides a local TCP listener.
-    let mut jmux_client = jetsocat_cmd()
+    let mut jmux_client = jetsocat_tokio_cmd()
         .env(
             "JETSOCAT_ARGS",
             format!(
                 "jmux-proxy tcp://127.0.0.1:{jmux_server_port} tcp-listen://127.0.0.1:{proxy_listen_port}/127.0.0.1:{read_server_port} --no-proxy",
             ),
         )
+        .kill_on_drop(true)
         .spawn()
         .expect("failed to start JMUX client");
 
-    // Give the JMUX client time to establish connection and set up listener.
-    std::thread::sleep(LISTENER_WAIT_DURATION);
+    wait_for_port_bound(proxy_listen_port)
+        .await
+        .expect("JMUX client proxy ready");
 
     // Connect to the JMUX client's local listener.
     jetsocat_assert_cmd()
         .env(
             "JETSOCAT_ARGS",
-            format!("forward tcp://127.0.0.1:{proxy_listen_port} 'cmd://echo hello world'"),
+            format!("forward tcp://127.0.0.1:{proxy_listen_port} 'cmd://echo hello world' --no-proxy"),
         )
         .timeout(COMMAND_TIMEOUT)
         .assert()
         .success();
 
     // Kill all processes.
-    let _ = jmux_client.kill();
-    let _ = jmux_server.kill();
-    let _ = read_server.kill();
-    let _ = jmux_client.wait();
-    let _ = jmux_server.wait();
-    let _ = read_server.wait();
+    let _ = jmux_client.start_kill();
+    let _ = jmux_server.start_kill();
+    let _ = read_server.start_kill();
+    let _ = jmux_client.wait().await;
+    let _ = jmux_server.wait().await;
+    let _ = read_server.wait().await;
 
     // Check that the read server received the payload.
     let mut read_server_stdout = String::new();
     read_server
         .stdout
+        .take()
         .unwrap()
         .read_to_string(&mut read_server_stdout)
+        .await
         .unwrap();
     assert_eq!(read_server_stdout.trim(), "hello world");
 }