(SP: 1)[SHOP] remove unsafe dead cart helpers and clean review nits

Author: liudmylasovetovs

frontend/docs/shop/checkout-notifications-contract.md

@@ -26,7 +26,7 @@ This is a launch rule, not a UI preference.
 
 Notification flows depend on a reliable recipient. If a guest order is created
 without email, the notification pipeline can fail or dead-letter because there
-is no guaranteed recipient identity. :contentReference[oaicite:2]{index=2}
+is no guaranteed recipient identity.
 
 The system must not rely only on:
 

frontend/lib/cart.ts

@@ -2,14 +2,12 @@ import { z } from 'zod';
 
 import { logWarn } from '@/lib/logging';
 import { createCartItemKey } from '@/lib/shop/cart-item-key';
-import { fromCents } from '@/lib/shop/money';
 import {
   type CartClientItem as ValidationCartClientItem,
   cartClientItemSchema,
   type CartRehydrateItem,
   type CartRehydrateResult,
   cartRehydrateResultSchema,
-  type CartRemovedItem,
   MAX_QUANTITY_PER_LINE,
 } from '@/lib/validation/shop';
 
@@ -166,44 +164,6 @@ function normalizeItemsForStorage(
   }));
 }
 
-export function computeSummaryFromItems(
-  items: CartRehydrateItem[]
-): CartSummary {
-  if (!items.length) {
-    return {
-      totalAmountMinor: 0,
-      totalAmount: 0,
-      itemCount: 0,
-      currency: 'USD',
-      pricingFingerprint: undefined,
-    };
-  }
-
-  const currency = (items[0]?.currency ?? 'USD') as CartSummary['currency'];
-
-  let totalMinor = 0;
-  let itemCount = 0;
-
-  for (const item of items) {
-    if (item.currency !== currency) {
-      throw new Error(
-        `Cart contains mixed currencies (${currency} and ${item.currency}). Clear cart and try again.`
-      );
-    }
-
-    totalMinor += item.lineTotalMinor;
-    itemCount += item.quantity;
-  }
-
-  return {
-    totalAmountMinor: totalMinor,
-    totalAmount: fromCents(totalMinor),
-    itemCount,
-    currency,
-    pricingFingerprint: undefined,
-  };
-}
-
 function isRecord(value: unknown): value is Record<string, unknown> {
   return !!value && typeof value === 'object' && !Array.isArray(value);
 }
@@ -307,14 +267,6 @@ export async function rehydrateCart(
   return parsed;
 }
 
-export function buildCartFromItems(
-  items: CartRehydrateItem[],
-  removed: CartRemovedItem[] = []
-): Cart {
-  const summary = computeSummaryFromItems(items);
-  return { items, removed, summary };
-}
-
 export function clearStoredCart(ownerId?: string | null): void {
   if (typeof window === 'undefined') return;
 

frontend/lib/services/shop/shipping/checkout-quote.ts

@@ -48,7 +48,7 @@ function readNonNegativeIntEnv(name: string): number | null {
   if (!/^\d+$/.test(trimmed)) return null;
 
   const parsed = Number.parseInt(trimmed, 10);
-  if (!Number.isSafeInteger(parsed) || parsed < 0) return null;
+  if (!Number.isSafeInteger(parsed)) return null;
 
   return parsed;
 }

frontend/lib/tests/shop/checkout-price-change-fail-closed.test.ts

@@ -133,6 +133,7 @@ afterAll(async () => {
 
 async function seedProduct(priceMinor: number): Promise<string> {
   const slug = `checkout-price-change-${crypto.randomUUID()}`;
+  const price = (priceMinor / 100).toFixed(2);
 
   const [product] = await db
     .insert(products)
@@ -142,7 +143,7 @@ async function seedProduct(priceMinor: number): Promise<string> {
       description: null,
       imageUrl: 'https://example.com/checkout-price-change.png',
       imagePublicId: null,
-      price: '9.00',
+      price,
       originalPrice: null,
       currency: 'USD',
       category: null,
@@ -164,7 +165,7 @@ async function seedProduct(priceMinor: number): Promise<string> {
     currency: 'USD',
     priceMinor,
     originalPriceMinor: null,
-    price: (priceMinor / 100).toFixed(2),
+    price,
     originalPrice: null,
   });
 
@@ -309,8 +310,7 @@ describe('checkout fail-closed for changed price mismatch', () => {
     expect(json.success).toBe(true);
     expect(json.order?.totalAmount).toBe(9);
 
-    const orderId =
-      typeof json.order?.id === 'string' ? String(json.order.id) : null;
+    const orderId = typeof json.order?.id === 'string' ? json.order.id : null;
     expect(orderId).toBeTruthy();
 
     if (orderId) {

frontend/lib/tests/shop/checkout-shipping-authoritative-total.test.ts

@@ -1,6 +1,6 @@
 import crypto from 'node:crypto';
 
-import { eq, inArray } from 'drizzle-orm';
+import { eq, inArray, type InferInsertModel } from 'drizzle-orm';
 import { NextRequest, NextResponse } from 'next/server';
 import {
   afterAll,
@@ -91,6 +91,10 @@ type SeedData = {
   cityRef: string;
   warehouseRef: string;
 };
+type ProductInsert = InferInsertModel<typeof products>;
+type ProductPriceInsert = InferInsertModel<typeof productPrices>;
+type NovaPoshtaCityInsert = InferInsertModel<typeof npCities>;
+type NovaPoshtaWarehouseInsert = InferInsertModel<typeof npWarehouses>;
 
 beforeAll(async () => {
   const checkoutRoute = await import('@/app/api/shop/checkout/route');
@@ -168,8 +172,7 @@ async function seedShippingCheckoutData(): Promise<SeedData> {
   const productId = crypto.randomUUID();
   const cityRef = crypto.randomUUID();
   const warehouseRef = crypto.randomUUID();
-
-  await db.insert(products).values({
+  const productRow: ProductInsert = {
     id: productId,
     slug: `checkout-shipping-total-${productId.slice(0, 8)}`,
     title: 'Checkout Shipping Total Test Product',
@@ -188,29 +191,26 @@ async function seedShippingCheckoutData(): Promise<SeedData> {
     isFeatured: false,
     stock: 25,
     sku: null,
-  } as any);
-
-  await db.insert(productPrices).values({
+  };
+  const productPriceRow: ProductPriceInsert = {
     id: crypto.randomUUID(),
     productId,
     currency: 'UAH',
     priceMinor: 4000,
     originalPriceMinor: null,
     price: '40.00',
     originalPrice: null,
-  } as any);
-
-  await db.insert(npCities).values({
+  };
+  const cityRow: NovaPoshtaCityInsert = {
     ref: cityRef,
     nameUa: 'Kyiv',
     nameRu: 'Kiev',
     area: 'Kyivska',
     region: 'Kyiv',
     settlementType: 'City',
     isActive: true,
-  } as any);
-
-  await db.insert(npWarehouses).values({
+  };
+  const warehouseRow: NovaPoshtaWarehouseInsert = {
     ref: warehouseRef,
     cityRef,
     settlementRef: cityRef,
@@ -220,7 +220,12 @@ async function seedShippingCheckoutData(): Promise<SeedData> {
     address: 'Address 1',
     isPostMachine: false,
     isActive: true,
-  } as any);
+  };
+
+  await db.insert(products).values(productRow);
+  await db.insert(productPrices).values(productPriceRow);
+  await db.insert(npCities).values(cityRow);
+  await db.insert(npWarehouses).values(warehouseRow);
 
   createdProductIds.push(productId);
   createdCityRefs.push(cityRef);