bugfix(pathfinder): Improve initialization of uninitialized variable in Pathfinder::classifyFence (TheSuperHackers#2460)

Author: Caball009

Core/GameEngine/Include/GameLogic/AIPathfind.h

@@ -917,6 +917,11 @@ class Pathfinder : PathfindServicesInterface, public Snapshot
 	Int						m_queuePRHead;
 	Int						m_queuePRTail;
 	Int						m_cumulativeCellsAllocated;
+
+#if RTS_ZEROHOUR && RETAIL_COMPATIBLE_CRC
+public:
+	Bool					m_classifyFenceZeroInit;
+#endif
 };
 
 

Core/GameEngine/Source/GameLogic/AI/AIPathfind.cpp

@@ -4104,6 +4104,10 @@ void Pathfinder::reset()
 	s_useFixedPathfinding = false;
 	s_forceCleanCells = false;
 #endif
+
+#if RTS_ZEROHOUR && RETAIL_COMPATIBLE_CRC
+	m_classifyFenceZeroInit = false;
+#endif
 }
 
 /**
@@ -4243,10 +4247,18 @@ void Pathfinder::classifyFence( Object *obj, Bool insert )
 #if RETAIL_COMPATIBLE_CRC
 	//CRCDEBUG_LOG(("Pathfinder::classifyFence - (%d,%d)", cellBounds.hi.x, cellBounds.hi.y));
 
-	// In retail, the values in the stack often look like this. We set them
-	// to reduce the likelihood of mismatch.
-	cellBounds.hi.x = 253961804;
-	cellBounds.hi.y = 4202797;
+	// For retail the values on the stack are often either 0 or larger than the map size.
+	// We initialize them to reduce the likelihood of a mismatch.
+	if (m_classifyFenceZeroInit)
+	{
+		cellBounds.hi.x = 0;
+		cellBounds.hi.y = 0;
+	}
+	else
+	{
+		cellBounds.hi.x = 1000000;
+		cellBounds.hi.y = 1000000;
+	}
 #else
 	cellBounds.hi.x = REAL_TO_INT_CEIL((pos->x + 0.5f)/PATHFIND_CELL_SIZE_F);
 	cellBounds.hi.y = REAL_TO_INT_CEIL((pos->y + 0.5f)/PATHFIND_CELL_SIZE_F);

GeneralsMD/Code/GameEngine/Source/GameLogic/System/GameLogic.cpp

@@ -2489,6 +2489,12 @@ void GameLogic::processDestroyList()
 {
 	//USE_PERF_TIMER(processDestroyList)
 
+#if RTS_ZEROHOUR && RETAIL_COMPATIBLE_CRC
+	// TheSuperHackers @info Set m_classifyFenceZeroInit to true for the first object. It's set to false when this function exits.
+	// Pathfinder::classifyFence may be called indirectly from Object::~Object.
+	TheAI->pathfinder()->m_classifyFenceZeroInit = !m_objectsToDestroy.empty();
+#endif
+
 	for( ObjectPointerListIterator iterator = m_objectsToDestroy.begin(); iterator != m_objectsToDestroy.end(); iterator++ )
 	{
 		Object* currentObject = (*iterator);
@@ -2547,6 +2553,10 @@ void GameLogic::processDestroyList()
 		removeObjectFromLookupTable( currentObject );
 
 		Object::friend_deleteInstance(currentObject);//actual delete
+
+#if RTS_ZEROHOUR && RETAIL_COMPATIBLE_CRC
+		TheAI->pathfinder()->m_classifyFenceZeroInit = false;
+#endif
 	}
 
 	m_objectsToDestroy.clear();//list full of bad pointers now, clear it.  If anyone's deletion resulted