fix and turn on compiler warnings

Denzy7 · Denzy7 · commit c56e072db822 · 2025-10-14T09:30:40.000+03:00
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -208,9 +208,8 @@ check_symbol_exists(pthread_setname_np "pthread.h" DENGINE_HAS_PTHREAD_SETNAME_N
 set(CMAKE_REQUIRED_FLAGS "")
 
 configure_file(dengine_config.h.in dengine_config/dengine_config.h)
-
-if (NOT MSVC)
-    add_compile_options(-Wall)
+if(MSYS OR UNIX OR MINGW)
+    add_compile_options("-Wall" "-Wextra" "-Wformat" "-Wno-unused-parameter")
 endif()
 
 set(dengine 
diff --git a/lib/dengine-core/include/dengine/shader.h b/lib/dengine-core/include/dengine/shader.h
@@ -106,7 +106,7 @@ int dengine_shader_make_standard(StandardShader stdshader, Shader* shader);
 
 void dengine_shader_set_shadercache(int state);
 
-const uint32_t dengine_shader_sampler2target(const uint32_t sampler);
+uint32_t dengine_shader_sampler2target(const uint32_t sampler);
 
 #ifdef __cplusplus
 }
diff --git a/lib/dengine-core/src/input.c b/lib/dengine-core/src/input.c
@@ -474,7 +474,7 @@ void _dengine_input_gamepad_linux_resetpads()
 }
 int _dengine_input_gamepad_linux_getpadfds()
 {
-    int axes = 0;
+    uint32_t axes = 0;
     DIR* dir;
     int count = 0;
     char path[PATH_MAX];
diff --git a/lib/dengine-core/src/material.c b/lib/dengine-core/src/material.c
@@ -45,6 +45,7 @@ void dengine_material_set_shader_color(const Shader* shader, Material* material)
     glGetProgramiv(shader->program_id, GL_ACTIVE_UNIFORM_MAX_LENGTH, &max_uniform_ln); DENGINE_CHECKGL;
     glGetIntegerv(GL_MAX_TEXTURE_IMAGE_UNITS, &max_units); DENGINE_CHECKGL;
     char* uniform_name = malloc(max_uniform_ln);
+    uint32_t max_units_u = max_units;
 
     memset(&material->textures, 0, sizeof(material->textures));
     material->textures_count = 0;
@@ -54,7 +55,7 @@ void dengine_material_set_shader_color(const Shader* shader, Material* material)
         /*printf("active: %s\n", uniform_name);*/
         if (type == GL_SAMPLER_2D || type == GL_SAMPLER_CUBE)
         {
-            if(material->textures_count > max_units)
+            if(material->textures_count > max_units_u)
             {
                 dengineutils_logging_log("WARNING::This OpenGL driver has a maximum of %d texture units."
                                          "%s will not be activated", max_units, uniform_name);
@@ -81,7 +82,7 @@ void dengine_material_set_shader_color(const Shader* shader, Material* material)
     }
 
     //clamp to the max units
-    if(material->textures_count > max_units)
+    if(material->textures_count > max_units_u)
         material->textures_count = max_units;
 
     free(uniform_name);
diff --git a/lib/dengine-core/src/shader.c b/lib/dengine-core/src/shader.c
@@ -583,7 +583,7 @@ void dengine_shader_set_shadercache(int state)
     shadercache = state;
 }
 
-const uint32_t dengine_shader_sampler2target(const uint32_t sampler)
+uint32_t dengine_shader_sampler2target(const uint32_t sampler)
 {
     DENGINE_DEBUG_ENTER;
 
diff --git a/lib/dengine-core/src/texture.c b/lib/dengine-core/src/texture.c
@@ -268,7 +268,7 @@ void dengine_texture_make_color(const int width, const int height, const float*
     {
         data = malloc(width * height * channels * sizeof(float));
         float* _data = data;
-        for(size_t i = 0; i < width * height; i++)
+        for(int i = 0; i < width * height; i++)
         {
             for(int j = 0; j < channels; j++)
             {
@@ -280,7 +280,7 @@ void dengine_texture_make_color(const int width, const int height, const float*
     {
         data =  malloc(width * height * channels);
         uint8_t* _data = data;
-        for(size_t i = 0; i < width * height; i++)
+        for(int i = 0; i < width * height; i++)
         {
             for(int j = 0; j < channels; j++)
             {
diff --git a/lib/dengine-core/src/window.c b/lib/dengine-core/src/window.c
@@ -7,9 +7,7 @@
 #include "dengine/input.h" //setwindow
 #include "dengine-utils/logging.h"//log
 #include "dengine-utils/dynlib.h" //getsym
-#include "dengine-utils/thread.h"
 #include "dengine-utils/macros.h" //ARY_SZ
-#include "dengine-utils/timer.h"
 #include "dengine-utils/debug.h"
 
 #include <stdio.h>  //printf
@@ -289,7 +287,6 @@ int dengine_window_init()
 
     int init = 0;
 #ifdef DENGINE_WIN_X11
-    XInitThreads();
     x_dpy = XOpenDisplay(NULL);
     if(x_dpy)
     {
diff --git a/lib/dengine-gui/src/gui.c b/lib/dengine-gui/src/gui.c
@@ -10,16 +10,13 @@
 #include "dengine/input.h"
 #include "dengine/entrygl.h"
 #include "dengine/viewport.h"
-#include "dengine/window.h"
 
 #include "dengine-utils/logging.h"
 #include "dengine-utils/debug.h"
-#include "dengine-utils/macros.h"
 
 #define STB_TRUETYPE_IMPLEMENTATION
 #include <stb_truetype.h> //stbtt
 
-#include "dengine_config.h"
 #ifdef DENGINE_ANDROID
 #include "dengine-utils/platform/android.h"
 #endif
@@ -181,13 +178,12 @@ int denginegui_set_font(const void* ttf, const float fontsize, const uint32_t bi
     void* sysfontmem = NULL;
     if (!ttf) {
         const char* file = _denginegui_get_defaultfont();
-        FILE* f = fopen(file, "rb");
-        if (!f) {
-            dengineutils_logging_log("WARNING::cannot read default font %s", file);
+        if (file == NULL) {
+            dengineutils_logging_log("WARNING::Cannot read default font. Load embfont OpenSans_Light");
             mem = OpenSans_Light_ttf;
-            dengineutils_logging_log("WARNING::Load embfont OpenSans_Light");
         }else
         {
+            FILE* f = fopen(file, "rb");
             fseek(f, 0, SEEK_END);
             size_t sz = ftell(f);
             rewind(f);
diff --git a/lib/dengine-scene/src/ecs.c b/lib/dengine-scene/src/ecs.c
@@ -5,7 +5,6 @@
 #include "dengine-utils/logging.h"
 #include "dengine_config.h"// DENGINE_ECS_MAXCHILDREN
 #ifdef DENGINE_SCRIPTING_PYTHON
-#include "dengine-script/python/python.h"
 #include "dengine-scene/scriptingsync/python/entity.h"
 #endif
 
diff --git a/lib/dengine-scene/src/scene.c b/lib/dengine-scene/src/scene.c
@@ -14,10 +14,6 @@
 
 #include "dengine/viewport.h" //get_view
 #include "dengine-script/script.h"
-#ifdef DENGINE_SCRIPTING_PYTHON
-#include "dengine-script/python/python.h"
-#include "dengine-scene/scriptingsync/python/entity.h"
-#endif
 
 typedef struct
 {
diff --git a/lib/dengine-script/src/python/modules/filesysmodule.c b/lib/dengine-script/src/python/modules/filesysmodule.c
@@ -1,5 +1,5 @@
 #include "dengine-utils/filesys.h"
-#include "dengine-script/script.h"
+#include <Python.h>
 
 static PyObject* filesys_get_cachedir(PyObject* self, PyObject* args)
 {
diff --git a/lib/dengine-script/src/python/modules/scenemodule.c b/lib/dengine-script/src/python/modules/scenemodule.c
@@ -1,5 +1,5 @@
 #include "dengine-script/python/modules/scenemodule.h"
-#include "dengine-script/script.h"
+#include <Python.h>
 #include "dengine-script/python/modules/commonmodule.h" //Vec3Object
 #include <structmember.h>                                                        
 
diff --git a/lib/dengine-script/src/python/modules/timermodule.c b/lib/dengine-script/src/python/modules/timermodule.c
@@ -1,5 +1,5 @@
-#include "dengine-script/script.h"
 #include "dengine-utils/timer.h"
+#include <Python.h>
 
 static PyObject* timer_get_current(PyObject* self, PyObject* args)
 {
diff --git a/lib/dengine-script/src/python/python.c b/lib/dengine-script/src/python/python.c
@@ -1,10 +1,13 @@
 #include "dengine-script/python/python.h"
 #include "dengine-script/script.h"
 #include "dengine-utils/logging.h"
+#include "pylifecycle.h"
+#ifndef DENGINE_USE_SYSTEM_PYTHON
 #include "dengine-utils/os.h"
 #include "dengine-utils/filesys.h"
 #include "dengine-utils/stream.h"
 #include "dengine-utils/zipread.h"
+#endif
 
 extern PyObject* PyInit_inpt(); //input_mod
 extern PyObject* PyInit_timer(); //timer_mod
@@ -107,7 +110,7 @@ int denginescript_python_isinit()
 
 void denginescript_python_terminate()
 {
-    Py_Finalize();
+    Py_FinalizeEx();
 }
 
 int denginescript_python_init()
diff --git a/lib/dengine-script/src/script.c b/lib/dengine-script/src/script.c
@@ -1,7 +1,6 @@
 #include "dengine-script/script.h"
 
 #include <stdio.h>
-#include <stdlib.h> //free
 #include <string.h> //strdup, memset
 
 #include "dengine-utils/logging.h"
diff --git a/lib/dengine-utils/src/assets.c b/lib/dengine-utils/src/assets.c
@@ -31,7 +31,7 @@ int dengineutils_assets_zip_load(const char* extrapaths)
         "/usr/share/dengine-%s/assets.zip",
         "/usr/local/share/dengine-%s/assets.zip",
     };
-    for(int i = 0; i < DENGINE_ARY_SZ(possible_assetszip_paths); i++)
+    for(size_t i = 0; i < DENGINE_ARY_SZ(possible_assetszip_paths); i++)
     {
         snprintf(buf, sizeof(buf), possible_assetszip_paths[i], DENGINE_VERSION);
         FILE* ok = fopen(buf, "rb");
diff --git a/lib/dengine-utils/src/debug.c b/lib/dengine-utils/src/debug.c
@@ -3,7 +3,6 @@
 #include "dengine-utils/logging.h"
 #include "dengine-utils/timer.h"
 #include "dengine-utils/filesys.h"
-#include "dengine-utils/thread.h" /* mutex */
 #include "dengine-utils/macros.h" /* arysz */
 
 #include "dengine_config.h"
@@ -43,7 +42,7 @@ void dengineutils_debug_init()
     }
     fmt=malloc(DENGINE_DEBUG_TRACESTRLN);
 
-    for(int i = 0; i < DENGINE_ARY_SZ(_sigtable_exit); i++)
+    for(size_t i = 0; i < DENGINE_ARY_SZ(_sigtable_exit); i++)
     {
         signal(_sigtable_exit[i].sig,_dengineutils_debug_hand_termandexit);
     }
@@ -128,7 +127,7 @@ void dengineutils_debug_enter(const char* function,const char* file,const int li
 void _dengineutils_debug_hand_termandexit(int sig)
 {
     const char* sigstr = "SIG____ (Not implemented!)";
-    for(int i = 0; i < DENGINE_ARY_SZ(_sigtable_exit); i++)
+    for(size_t i = 0; i < DENGINE_ARY_SZ(_sigtable_exit); i++)
     {
         if(sig == _sigtable_exit[i].sig)
             sigstr = _sigtable_exit[i].str;
diff --git a/lib/dengine-utils/src/logging.c b/lib/dengine-utils/src/logging.c
@@ -223,7 +223,7 @@ void dengineutils_logging_log(const char* message, ...)
     const LogPair* pair = NULL;
     const char* delim = "";
     LogTarget target = TARGET_NONE;
-    for(int i = 0; i < DENGINE_ARY_SZ(logpairs); i++)
+    for(size_t i = 0; i < DENGINE_ARY_SZ(logpairs); i++)
     {
         if(strstr(LOG_BUFFER, logpairs[i].triggerstr))
         {
diff --git a/lib/dengine-utils/src/types.c b/lib/dengine-utils/src/types.c
@@ -5,7 +5,6 @@
 
 #include "dengine-utils/types.h"
 #include "dengine-utils/macros.h"
-#include "dengine_config.h"
 
 typedef struct
 {
diff --git a/main/dengitor/src/glarea.c b/main/dengitor/src/glarea.c
@@ -175,7 +175,7 @@ DENGINE_EXPORT void dengitor_glarea_onrealize(GtkGLArea* area)
     Texture plane_tex;
     memset(&plane_tex, 0, sizeof(plane_tex));
 
-    for(int i = 0; i < DENGINE_ARY_SZ(plane_tex_files_tgt); i++)
+    for(uint32_t i = 0; i < DENGINE_ARY_SZ(plane_tex_files_tgt); i++)
     {
         char prtbf[512];
 
@@ -348,7 +348,7 @@ DENGINE_EXPORT void dengitor_glarea_evbox_onbtnpress(GtkEventBox* evbox, GdkEven
     }
     if(button->button == GDK_BUTTON_SECONDARY && dengitor->glarea.glarea_mode == DENGITOR_GLAREA_MODE_SCENE)
     {
-        GdkWindow* window = gtk_widget_get_window( GTK_WIDGET(dengitor->glarea.glarea) );
+        /*GdkWindow* window = gtk_widget_get_window( GTK_WIDGET(dengitor->glarea.glarea) );*/
         /*gdk_window_set_cursor(window, dengitor->cursor_blank);*/
     }
     dengitor_glearea_onevent();
diff --git a/nsl/src/nsl-bulletphysics/basic.cpp b/nsl/src/nsl-bulletphysics/basic.cpp
@@ -191,7 +191,7 @@ extern "C" int basic_world_start(void*)
     }
 
     Material cube_mat_pool[4];
-    for(int i = 0; i < DENGINE_ARY_SZ(cube_mat_pool); i++)
+    for(size_t i = 0; i < DENGINE_ARY_SZ(cube_mat_pool); i++)
     {
         dengine_material_setup(&cube_mat_pool[i]);
         dengine_material_set_shader_color(&stdshdr, &cube_mat_pool[i]);
diff --git a/nsl/src/nsl-bulletphysics/car.cpp b/nsl/src/nsl-bulletphysics/car.cpp
@@ -1,5 +1,4 @@
 #include "denginebulletcommon.h"
-#include <vector> //bruh
 
 typedef struct
 {
diff --git a/nsl/src/nsl-test/pingpongposition.c b/nsl/src/nsl-test/pingpongposition.c
@@ -1,5 +1,4 @@
 #include <dengine/dengine.h>
-#include <stdlib.h>
 #include <math.h>
 
 int pingpongposition_update(Entity* entity)
diff --git a/nsl/src/nsl-test/pingpongscale.c b/nsl/src/nsl-test/pingpongscale.c
@@ -1,6 +1,5 @@
 #include <dengine/dengine.h>
 #include <math.h>
-#include <stdlib.h>
 
 int pingpongscale_update(Entity* entity)
 {
diff --git a/nsl/src/nsl-test/printmouse.c b/nsl/src/nsl-test/printmouse.c
@@ -1,5 +1,4 @@
 #include <dengine/dengine.h>
-#include <stdlib.h>
 #include <time.h>
 int printmouse_start(void* args)
 {
diff --git a/tests/src/testdengine-gui/textbench.c b/tests/src/testdengine-gui/textbench.c
@@ -4,7 +4,7 @@ int testdengine_gui_textbench(int argc, char** argv)
 {
         
     char textbuf[128];
-    for(int i = 0; i < DENGINE_ARY_SZ(textbuf); i++)
+    for(uint32_t i = 0; i < DENGINE_ARY_SZ(textbuf); i++)
     {
         textbuf[i] = dengineutils_rng_int(91) + 32;
     }
diff --git a/tests/src/testdengine-lighting/lighting-standard.c b/tests/src/testdengine-lighting/lighting-standard.c
@@ -220,7 +220,7 @@ int testdengine_lighting_standard(int argc, char** argv)
     char fps[20];
     char shadowtogglestr[50];
 
-    int curpstr = 0;
+    uint32_t curpstr = 0;
     char* postrs[]=
     {
         "Cube", "Camera", "DirectionalLight (pos)'", "PointLight", "Spotlight", "Spotlight target"
@@ -410,7 +410,7 @@ int testdengine_lighting_standard(int argc, char** argv)
         denginegui_panel(0, fontsz, tex_widths,tex_widths,&dLight.shadow.shadow_map.depth, NULL, NULL);
 
         int postrs_count = DENGINE_ARY_SZ(postrs);
-        snprintf(postr, sizeof (postr), "Click to change pos mode : %s <%d of %d> , x:%.2f, y:%.2f, z:%.2f", postrs[curpstr], curpstr + 1, postrs_count, ptr[0], ptr[1], ptr[2]);
+        snprintf(postr, sizeof (postr), "Click to change pos mode : %s <%u of %d> , x:%.2f, y:%.2f, z:%.2f", postrs[curpstr], curpstr + 1, postrs_count, ptr[0], ptr[1], ptr[2]);
         if(denginegui_button(offset, h - 4 * fontsz, w - 2 * offset, 2 * fontsz, postr, NULL))
         {
             curpstr++;
diff --git a/tests/src/testdengine-scene/scene-ecs.c b/tests/src/testdengine-scene/scene-ecs.c
@@ -359,7 +359,7 @@ int testdengine_scece_ecs_main(int argc, char **argv)
     dengineutils_rng_set_seedwithtime();
     //feel free to increase pool
     Texture cube_tex_pool[6];
-    for(int i = 0; i < DENGINE_ARY_SZ(cube_tex_pool); i++)
+    for(size_t i = 0; i < DENGINE_ARY_SZ(cube_tex_pool); i++)
     {
         Texture* cube_tex = &cube_tex_pool[i];
         memset(cube_tex, 0, sizeof(Texture));
diff --git a/tests/src/testdengine-utils/util-vtor.c b/tests/src/testdengine-utils/util-vtor.c
@@ -1,6 +1,4 @@
 #include <stdlib.h>
-#include <stdio.h>
-#include <string.h>
 
 #include <dengine-utils/vtor.h>
 #include <dengine-utils/logging.h>
@@ -35,7 +33,7 @@ int main(int argc, char *argv[])
         vtor_pushback(vtor1, &randomflt);
     }
     float* data1 = vtor1->data;
-    for (int i = 0; i < vtor1->count; i++) {
+    for (size_t i = 0; i < vtor1->count; i++) {
         dengineutils_logging_log("readback vtor1 %f", data1[i]);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -106,7 +106,7 @@ int dengine_shader_make_standard(StandardShader stdshader, Shader* shader);`
`106`	`106`
`107`	`107`	`void dengine_shader_set_shadercache(int state);`
`108`	`108`
`109`		`-const uint32_t dengine_shader_sampler2target(const uint32_t sampler);`
	`109`	`+uint32_t dengine_shader_sampler2target(const uint32_t sampler);`
`110`	`110`
`111`	`111`	`#ifdef __cplusplus`
`112`	`112`	`}`
Original file line number	Diff line number	Diff line change
`@@ -474,7 +474,7 @@ void _dengine_input_gamepad_linux_resetpads()`
`474`	`474`	`}`
`475`	`475`	`int _dengine_input_gamepad_linux_getpadfds()`
`476`	`476`	`{`
`477`		`- int axes = 0;`
	`477`	`+ uint32_t axes = 0;`
`478`	`478`	`DIR* dir;`
`479`	`479`	`int count = 0;`
`480`	`480`	`char path[PATH_MAX];`
Original file line number	Diff line number	Diff line change
`@@ -583,7 +583,7 @@ void dengine_shader_set_shadercache(int state)`
`583`	`583`	`shadercache = state;`
`584`	`584`	`}`
`585`	`585`
`586`		`-const uint32_t dengine_shader_sampler2target(const uint32_t sampler)`
	`586`	`+uint32_t dengine_shader_sampler2target(const uint32_t sampler)`
`587`	`587`	`{`
`588`	`588`	`DENGINE_DEBUG_ENTER;`
`589`	`589`
Original file line number	Diff line number	Diff line change
`@@ -268,7 +268,7 @@ void dengine_texture_make_color(const int width, const int height, const float*`
`268`	`268`	`{`
`269`	`269`	`data = malloc(width * height * channels * sizeof(float));`
`270`	`270`	`float* _data = data;`
`271`		`- for(size_t i = 0; i < width * height; i++)`
	`271`	`+ for(int i = 0; i < width * height; i++)`
`272`	`272`	`{`
`273`	`273`	`for(int j = 0; j < channels; j++)`
`274`	`274`	`{`
`@@ -280,7 +280,7 @@ void dengine_texture_make_color(const int width, const int height, const float*`
`280`	`280`	`{`
`281`	`281`	`data = malloc(width * height * channels);`
`282`	`282`	`uint8_t* _data = data;`
`283`		`- for(size_t i = 0; i < width * height; i++)`
	`283`	`+ for(int i = 0; i < width * height; i++)`
`284`	`284`	`{`
`285`	`285`	`for(int j = 0; j < channels; j++)`
`286`	`286`	`{`
Original file line number	Diff line number	Diff line change
`@@ -14,10 +14,6 @@`
`14`	`14`
`15`	`15`	`#include "dengine/viewport.h" //get_view`
`16`	`16`	`#include "dengine-script/script.h"`
`17`		`-#ifdef DENGINE_SCRIPTING_PYTHON`
`18`		`-#include "dengine-script/python/python.h"`
`19`		`-#include "dengine-scene/scriptingsync/python/entity.h"`
`20`		`-#endif`
`21`	`17`
`22`	`18`	`typedef struct`
`23`	`19`	`{`