From 1a66d5fd21a80c08483009941a81a8206656fe43 Mon Sep 17 00:00:00 2001 From: Jordan Stephens Date: Fri, 23 Jan 2026 18:01:48 -0800 Subject: [PATCH 1/3] print a url to set missing config vars --- action.yaml | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/action.yaml b/action.yaml index ecfb0ef..3a317bc 100644 --- a/action.yaml +++ b/action.yaml @@ -77,6 +77,24 @@ runs: params+=("-f") params+=("$filename") done + empty=() + for source in $CONFIG_ENV_VARS; do + if [ -z "${!source}" ]; then + empty+=("$source") + fi + done + + # if there are any empty variables, print instructions on how to update + # the github environment variables + if [ ${#empty[@]} -gt 0 ]; then + echo "Some Defang config vars do not have values. To use Github Secrets, add" + echo "these variables to your environment:" + for source in "${empty[@]}"; do + echo "- $source" + done + echo "Here is a link to your repository environments settings:" + echo "https://github.com/${GITHUB_REPOSITORY}/settings/environments" + fi for source in $CONFIG_ENV_VARS; do echo "Updating $source" echo defang config "${params[@]}" set -e $source From de9ba3e7f54bbfbebb5cc4af862bb499a8dd51ef Mon Sep 17 00:00:00 2001 From: muddysound Date: Mon, 26 Jan 2026 14:54:06 -0800 Subject: [PATCH 2/3] teardown with project name --- .github/workflows/test.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index dbf7e82..7aaa06a 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -51,4 +51,4 @@ jobs: command: "compose up --dry-run --project-name github-action-test" - name: Teardown - run: defang config rm DEFANG_GH_ACTION_TEST_MESSAGE + run: defang config rm --project-name github-action-test DEFANG_GH_ACTION_TEST_MESSAGE From 503d67cd809b5701b866a2efabf8b340a187f194 Mon Sep 17 00:00:00 2001 From: Jordan Stephens Date: Mon, 26 Jan 2026 16:21:47 -0800 Subject: [PATCH 3/3] Apply suggestion from @edwardrf Co-authored-by: Hao Jiang --- action.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/action.yaml b/action.yaml index 3a317bc..c653d23 100644 --- a/action.yaml +++ b/action.yaml @@ -88,7 +88,7 @@ runs: # the github environment variables if [ ${#empty[@]} -gt 0 ]; then echo "Some Defang config vars do not have values. To use Github Secrets, add" - echo "these variables to your environment:" + echo "these variables to your environment secrets:" for source in "${empty[@]}"; do echo "- $source" done