fix: show local camera feed during try-on loading to eliminate black screen#14
Open
tomershlasky wants to merge 1 commit into
Open
fix: show local camera feed during try-on loading to eliminate black screen#14tomershlasky wants to merge 1 commit into
tomershlasky wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem\n\nUsers see a black screen when opening the try-on modal while the WebRTC connection is being established (can take 10–15s). The local camera stream was being passed to the WebRTC connection but never rendered in the
<video>element — leavingbg-gray-900visible during the entire loading phase.\n\n## Fix\n\nAfterstartCamera()succeeds, immediately setvideoRef.current.srcObject = mediaStreamso the local camera feed is shown while connecting. When the remote AI stream arrives,handleRemoteStreamnaturally overwrites it.\n\nChanged:examples/ecommerce/components/TryOnModal.tsx— 3 lines added ininit()\n\n## Notes\n\n- Almog confirmed this happens before the session starts (and also on the demo site / B2C product)\n- The underlying server-side latency (slow moderation, ICE connectivity) is a separate infra concern; this makes the UX acceptable regardless of connection time\n\nRequested by Almog in Slack (#webrtc)Generated by Claude Code